Merge pull request mod-playerbots#2205 from mod-playerbots/test-staging

Test staging to master

Author: kadeshar

PULL_REQUEST_TEMPLATE.md

@@ -43,21 +43,21 @@ any impact on performance, you may skip these question. If necessary, a maintain
 ## Impact Assessment
 <!-- As a generic test, before and after measure of pmon (playerbot pmon tick) can help you here. -->
 - Does this change increase per-bot/per-tick processing or risk scaling poorly with thousands of bots?
-    - [ ] No, not at all
-    - [ ] Minimal impact (**explain below**)
-    - [ ] Moderate impact (**explain below**)
+    - - [ ] No, not at all
+    - - [ ] Minimal impact (**explain below**)
+    - - [ ] Moderate impact (**explain below**)
 
 
 
 - Does this change modify default bot behavior?
-    - [ ] No
-    - [ ] Yes (**explain why**)
+    - - [ ] No
+    - - [ ] Yes (**explain why**)
 
 
 
 - Does this change add new decision branches or increase maintenance complexity?
-    - [ ] No
-    - [ ] Yes (**explain below**)
+    - - [ ] No
+    - - [ ] Yes (**explain below**)
 
 
 
@@ -68,8 +68,8 @@ the message is in a translatable format, and list in the table the message_key a
 Search for GetBotTextOrDefault in the codebase for examples.
 -->
 Does this change add bot messages to translate?
-- [ ] No
-- [ ] Yes (**list messages in the table**)
+    - - [ ] No
+    - - [ ] Yes (**list messages in the table**)
 
 | Message key  | Default message |
 | --------------- | ------------------ |
@@ -82,8 +82,8 @@ AI assistance is allowed, but all submitted code must be fully understood, revie
 We expect contributors to be honest about what they do and do not understand.
 -->
 Was AI assistance used while working on this change?
-- [ ] No
-- [ ] Yes (**explain below**)
+    - - [ ] No
+    - - [ ] Yes (**explain below**)
 <!--
 If yes, please specify:
 - Purpose of usage (e.g. brainstorming, refactoring, documentation, code generation).
@@ -94,10 +94,10 @@ If yes, please specify:
 
 ## Final Checklist
 
-- [ ] Stability is not compromised.
-- [ ] Performance impact is understood, tested, and acceptable.
-- [ ] Added logic complexity is justified and explained.
-- [ ] Documentation updated if needed (Conf comments, WiKi commands).
+- - [ ] Stability is not compromised.
+- - [ ] Performance impact is understood, tested, and acceptable.
+- - [ ] Added logic complexity is justified and explained.
+- - [ ] Documentation updated if needed (Conf comments, WiKi commands).
 
 ## Notes for Reviewers
 <!-- Anything else that's helpful to review or test your pull request. -->

src/Ai/Base/Actions/FollowActions.cpp

@@ -5,18 +5,211 @@
 
 #include "FollowActions.h"
 
+#include <algorithm>
+#include <cmath>
+#include <array>
+
 #include "Event.h"
 #include "Formations.h"
 #include "LastMovementValue.h"
+#include "MotionMaster.h"
 #include "PlayerbotAI.h"
 #include "Playerbots.h"
 #include "ServerFacade.h"
+#include "Transport.h"
+#include "Map.h"
+
+namespace
+{
+    Transport* GetTransportForPosTolerant(Map* map, WorldObject* ref, uint32 phaseMask, float x, float y, float z)
+    {
+        if (!map || !ref)
+            return nullptr;
+
+        std::array<float, 4> const probes = { z, z + 0.5f, z + 1.5f, z - 0.5f };
+        for (float const pz : probes)
+        {
+            if (Transport* t = map->GetTransportForPos(phaseMask, x, y, pz, ref))
+                return t;
+        }
+
+        return nullptr;
+    }
+
+    // Attempts to find a point on the leader's transport that is closer to the bot,
+    // by probing along the segment from master -> bot and returning the last point
+    // that is still detected as being on the expected transport.
+    bool FindBoardingPointOnTransport(Map* map, Transport* expectedTransport, WorldObject* ref,
+        float masterX, float masterY, float masterZ,
+        float botX, float botY, float botZ,
+        float& outX, float& outY, float& outZ)
+    {
+        if (!map || !expectedTransport || !ref)
+            return false;
+
+        uint32 const phaseMask = ref->GetPhaseMask();
+
+        // Ensure master is actually detected on that transport (tolerant).
+        if (GetTransportForPosTolerant(map, ref, phaseMask, masterX, masterY, masterZ) != expectedTransport)
+            return false;
+
+        // The raycast in GetTransportForPos starts at (z + 2). Probe with a safe Z.
+        float const probeZ = std::max(masterZ, botZ);
+
+        // Adaptive step count: small platforms need tighter sampling.
+        float const dx2 = botX - masterX;
+        float const dy2 = botY - masterY;
+        float const dist2d = std::sqrt(dx2 * dx2 + dy2 * dy2);
+        int32 const steps = std::clamp(static_cast<int32>(dist2d / 0.75f), 10, 28);
+
+        float const dx = (botX - masterX) / static_cast<float>(steps);
+        float const dy = (botY - masterY) / static_cast<float>(steps);
+
+        // Master must actually be on the expected transport for this to work.
+        if (map->GetTransportForPos(ref->GetPhaseMask(), masterX, masterY, probeZ, ref) != expectedTransport)
+            return false;
+
+        float lastX = masterX;
+        float lastY = masterY;
+        bool found = false;
+
+        for (int32 i = 1; i <= steps; ++i)
+        {
+            float const px = masterX + dx * i;
+            float const py = masterY + dy * i;
+
+            Transport* const t = GetTransportForPosTolerant(map, ref, phaseMask, px, py, probeZ);
+            if (t != expectedTransport)
+                break;
+
+            lastX = px;
+            lastY = py;
+            found = true;
+        }
+
+        if (!found)
+            return false;
+
+        outX = lastX;
+        outY = lastY;
+        outZ = masterZ; // keep deck-level Z to encourage stepping onto the platform/boat
+        return true;
+    }
+}
 
 bool FollowAction::Execute(Event /*event*/)
 {
     Formation* formation = AI_VALUE(Formation*, "formation");
     std::string const target = formation->GetTargetName();
 
+    // Transport handling for moving transports only (boats/zeppelins).
+    Player* master = botAI->GetMaster();
+    if (master && master->IsInWorld() && bot->IsInWorld() && bot->GetMapId() == master->GetMapId())
+    {
+        Map* map = master->GetMap();
+        uint32 const mapId = bot->GetMapId();
+        Transport* transport = nullptr;
+        bool masterOnTransport = false;
+
+        if (master->GetTransport())
+        {
+            transport = master->GetTransport();
+            masterOnTransport = true;
+        }
+        else if (map)
+        {
+            transport = GetTransportForPosTolerant(map, master, master->GetPhaseMask(),
+                master->GetPositionX(), master->GetPositionY(), master->GetPositionZ());
+            masterOnTransport = (transport != nullptr);
+        }
+
+        // Ignore static transports (elevators/trams): only keep boats/zeppelins here.
+        if (transport && transport->IsStaticTransport())
+            transport = nullptr;
+
+        if (transport && map && bot->GetTransport() != transport)
+        {
+            float const botProbeZ = std::max(bot->GetPositionZ(), transport->GetPositionZ());
+            Transport* botSurfaceTransport = GetTransportForPosTolerant(map, bot, bot->GetPhaseMask(),
+                bot->GetPositionX(), bot->GetPositionY(), botProbeZ);
+
+            if (botSurfaceTransport == transport)
+            {
+                transport->AddPassenger(bot, true);
+                bot->StopMovingOnCurrentPos();
+                return true;
+            }
+
+            float const boardingAssistDistance = 60.0f;
+            float const dist2d = ServerFacade::instance().GetDistance2d(bot, master);
+            bool const inAssist = ServerFacade::instance().IsDistanceLessOrEqualThan(dist2d, boardingAssistDistance);
+
+            if (inAssist)
+            {
+                float destX = masterOnTransport ? master->GetPositionX() : transport->GetPositionX();
+                float destY = masterOnTransport ? master->GetPositionY() : transport->GetPositionY();
+                float destZ = masterOnTransport ? master->GetPositionZ() : transport->GetPositionZ();
+                float edgeX = 0.0f;
+                float edgeY = 0.0f;
+                float edgeZ = 0.0f;
+
+                if (masterOnTransport &&
+                    FindBoardingPointOnTransport(map, transport, master,
+                        master->GetPositionX(), master->GetPositionY(), master->GetPositionZ(),
+                        bot->GetPositionX(), bot->GetPositionY(), bot->GetPositionZ(),
+                        edgeX, edgeY, edgeZ))
+                {
+                    destX = edgeX;
+                    destY = edgeY;
+                    destZ = edgeZ;
+                }
+
+                MovementPriority const priority = botAI->GetState() == BOT_STATE_COMBAT
+                    ? MovementPriority::MOVEMENT_COMBAT
+                    : MovementPriority::MOVEMENT_NORMAL;
+
+                bool const movingAllowed = IsMovingAllowed(mapId, destX, destY, destZ);
+                bool const dupMove = IsDuplicateMove(mapId, destX, destY, destZ);
+                bool const waiting = IsWaitingForLastMove(priority);
+
+                if (movingAllowed && !dupMove && !waiting)
+                {
+                    if (bot->IsSitState())
+                        bot->SetStandState(UNIT_STAND_STATE_STAND);
+
+                    if (bot->IsNonMeleeSpellCast(true))
+                    {
+                        bot->CastStop();
+                        botAI->InterruptSpell();
+                    }
+
+                    if (MotionMaster* mm = bot->GetMotionMaster())
+                    {
+                        mm->MovePoint(
+                            /*id*/ 0,
+                            /*coords*/ destX, destY, destZ,
+                            /*forcedMovement*/ FORCED_MOVEMENT_NONE,
+                            /*speed*/ 0.0f,
+                            /*orientation*/ 0.0f,
+                            /*generatePath*/ false,
+                            /*forceDestination*/ false);
+                    }
+                    else
+                        return false;
+
+                    float delay = 1000.0f * MoveDelay(bot->GetExactDist(destX, destY, destZ));
+                    delay = std::clamp(delay, 0.0f, static_cast<float>(sPlayerbotAIConfig.maxWaitForMove));
+
+                    AI_VALUE(LastMovement&, "last movement")
+                        .Set(mapId, destX, destY, destZ, bot->GetOrientation(), delay, priority);
+                    ClearIdleState();
+                    return true;
+                }
+            }
+        }
+    }
+    // end unified transport handling
+
     bool moved = false;
     if (!target.empty())
     {

src/Ai/Raid/Naxxramas/Action/RaidNaxxActions.h

@@ -37,10 +37,10 @@ class GrobbulusRotateAction : public RotateAroundTheCenterPointAction
     uint32 GetCurrWaypoint() override;
 };
 
-class GrobblulusMoveCenterAction : public MoveInsideAction
+class GrobbulusMoveCenterAction : public MoveInsideAction
 {
 public:
-    GrobblulusMoveCenterAction(PlayerbotAI* ai) : MoveInsideAction(ai, 3281.23f, -3310.38f, 5.0f) {}
+    GrobbulusMoveCenterAction(PlayerbotAI* ai) : MoveInsideAction(ai, 3281.23f, -3310.38f, 5.0f) {}
 };
 
 class GrobbulusMoveAwayAction : public MovementAction
@@ -173,26 +173,26 @@ class RazuviousTargetAction : public AttackAction
     RazuviousBossHelper helper;
 };
 
-class HorsemanAttractAlternativelyAction : public AttackAction
+class FourHorsemenAttractAlternativelyAction : public AttackAction
 {
 public:
-    HorsemanAttractAlternativelyAction(PlayerbotAI* ai) : AttackAction(ai, "horseman attract alternatively"), helper(ai)
+    FourHorsemenAttractAlternativelyAction(PlayerbotAI* ai) : AttackAction(ai, "four horsemen attract alternatively"), helper(ai)
     {
     }
     bool Execute(Event event) override;
 
 protected:
-    FourhorsemanBossHelper helper;
+    FourHorsemenBossHelper helper;
 };
 
-class HorsemanAttactInOrderAction : public AttackAction
+class FourHorsemenAttackInOrderAction : public AttackAction
 {
 public:
-    HorsemanAttactInOrderAction(PlayerbotAI* ai) : AttackAction(ai, "horseman attact in order"), helper(ai) {}
+    FourHorsemenAttackInOrderAction(PlayerbotAI* ai) : AttackAction(ai, "four horsemen attack in order"), helper(ai) {}
     bool Execute(Event event) override;
 
 protected:
-    FourhorsemanBossHelper helper;
+    FourHorsemenBossHelper helper;
 };
 
 // class SapphironGroundMainTankPositionAction : public MovementAction

src/Ai/Raid/Naxxramas/Action/RaidNaxxActions_Anubrekhan.cpp

@@ -1,7 +1,6 @@
-#include "RaidNaxxActions.h"
-
 #include "ObjectGuid.h"
 #include "Playerbots.h"
+#include "RaidNaxxActions.h"
 
 bool AnubrekhanChooseTargetAction::Execute(Event /*event*/)
 {
@@ -66,13 +65,10 @@ bool AnubrekhanPositionAction::Execute(Event /*event*/)
         {
             uint32 nearest = FindNearestWaypoint();
             uint32 next_point;
-            if (inPhase)
-                next_point = (nearest + 1) % intervals;
-            else
-                next_point = nearest;
+            next_point = (nearest + 1) % intervals;
 
-            return MoveTo(bot->GetMapId(), waypoints[next_point].first, waypoints[next_point].second, bot->GetPositionZ(), false, false,
-                          false, false, MovementPriority::MOVEMENT_COMBAT);
+            return MoveTo(bot->GetMapId(), waypoints[next_point].first, waypoints[next_point].second,
+                          bot->GetPositionZ(), false, false, false, false, MovementPriority::MOVEMENT_COMBAT);
         }
         else
             return MoveInside(533, 3272.49f, -3476.27f, bot->GetPositionZ(), 3.0f, MovementPriority::MOVEMENT_COMBAT);

…/Action/RaidNaxxActions_FourHorseman.cpp …/Action/RaidNaxxActions_FourHorsemen.cppsrc/Ai/Raid/Naxxramas/Action/RaidNaxxActions_FourHorseman.cpp renamed to src/Ai/Raid/Naxxramas/Action/RaidNaxxActions_FourHorsemen.cpp src/Ai/Raid/Naxxramas/Action/RaidNaxxActions_FourHorseman.cpp renamed to src/Ai/Raid/Naxxramas/Action/RaidNaxxActions_FourHorsemen.cpp

@@ -2,7 +2,7 @@
 
 #include "Playerbots.h"
 
-bool HorsemanAttractAlternativelyAction::Execute(Event /*event*/)
+bool FourHorsemenAttractAlternativelyAction::Execute(Event /*event*/)
 {
     if (!helper.UpdateBossAI())
         return false;
@@ -13,13 +13,13 @@ bool HorsemanAttractAlternativelyAction::Execute(Event /*event*/)
         return true;
 
     Unit* attackTarget = helper.CurrentAttackTarget();
-    if (context->GetValue<Unit*>("current target")->Get() != attackTarget)
+    if (attackTarget && context->GetValue<Unit*>("current target")->Get() != attackTarget)
         return Attack(attackTarget);
 
     return false;
 }
 
-bool HorsemanAttactInOrderAction::Execute(Event /*event*/)
+bool FourHorsemenAttackInOrderAction::Execute(Event /*event*/)
 {
     if (!helper.UpdateBossAI())
         return false;

src/Ai/Raid/Naxxramas/Action/RaidNaxxActions_Sapphiron.cpp

@@ -70,7 +70,6 @@ bool SapphironFlightPositionAction::MoveToNearestIcebolt()
     if (!group)
         return false;
 
-    Group::MemberSlotList const& slots = group->GetMemberSlots();
     Player* playerWithIcebolt = nullptr;
     float minDistance;
     for (GroupReference* ref = group->GetFirstMember(); ref; ref = ref->next())