diff --git a/.agents/skills/start/SKILL.md b/.agents/skills/start/SKILL.md index 171fb16..c8f0433 100644 --- a/.agents/skills/start/SKILL.md +++ b/.agents/skills/start/SKILL.md @@ -213,7 +213,7 @@ git checkout dev && git pull origin dev Now create the feature branch: ```bash -gh issue develop --base dev --name feature/ --checkout +gh issue develop --base dev --name feature/- --checkout ``` > `--base` is required: `gh issue develop` reads the default base from the GitHub API, not from local working state, so `git checkout dev` on its own does not influence which branch the new feature branch is cut from. @@ -278,7 +278,7 @@ git checkout dev && git pull origin dev Find and check out the existing branch, or create a new one linked to the issue: ```bash -gh issue develop --base dev --name feature/ --checkout +gh issue develop --base dev --name feature/- --checkout ``` > `--base` is required: `gh issue develop` reads the default base from the GitHub API, not from local working state. @@ -313,4 +313,4 @@ When done, say: **"The code is ready for review. Please run `make dev` and test - The issue is assigned to `@me` at creation. If you are creating a ticket on someone else's behalf, remove the assignee after creation with `gh issue edit --remove-assignee @me`. - Apply resolved labels and milestone to every new issue. Label resolution order: per-invocation flag → pool selection from `bug, documentation, enhancement, chore` → omit `--label` entirely. Never apply a label outside `bug, documentation, enhancement, chore`. - Milestone resolution order: per-invocation flag → auto-detected from GitHub open milestones. Never prompt for a milestone more than once per invocation. - + diff --git a/.agents/skills/submit-for-review/SKILL.md b/.agents/skills/submit-for-review/SKILL.md index be30c00..31d60a8 100644 --- a/.agents/skills/submit-for-review/SKILL.md +++ b/.agents/skills/submit-for-review/SKILL.md @@ -71,12 +71,11 @@ Do not proceed until `make check` passes cleanly. ## Step 3 — Identify linked issue -Check for a linked issue by inspecting the branch name (should follow `feature/` linked via `gh issue develop`) or by running: -``` -gh pr view --json number,body 2>/dev/null -``` +Extract the issue number from the branch name. Branches created by `/start` follow the pattern `feature/-` (e.g. `feature/42-fix-login`). + +Parse the number from the branch name returned in Step 1. If the branch name matches `feature/-...`, use the extracted number as the linked issue. If the branch name does not contain a leading number after `feature/`, proceed without an issue reference but warn the user: -If a linked issue number is identifiable, note it for the PR body. If not identifiable, proceed without it but mention this to the user. +> "Could not extract an issue number from branch name ``. The PR will not include an issue reference. Was this branch created outside of `/start`?" --- @@ -367,4 +366,4 @@ If a single `gh issue create` call fails, report the failure for that finding an - `/submit-for-review` merges only to `dev` — never directly to `main`. - If `make merge` fails for any reason, report it and stop — do not attempt workarounds. - The follow-up issue offer in Step 9 runs only after a successful merge and only when the review produced non-blocking findings. Never prompt the user for follow-ups when the review blocked the merge — those findings should be fixed, not ticketed. - + diff --git a/.claude/commands/start.md b/.claude/commands/start.md index 3c3513e..ca98ac5 100644 --- a/.claude/commands/start.md +++ b/.claude/commands/start.md @@ -208,7 +208,7 @@ git checkout dev && git pull origin dev Now create the feature branch: ```bash -gh issue develop --base dev --name feature/ --checkout +gh issue develop --base dev --name feature/- --checkout ``` > `--base` is required: `gh issue develop` reads the default base from the GitHub API, not from local working state, so `git checkout dev` on its own does not influence which branch the new feature branch is cut from. @@ -273,7 +273,7 @@ git checkout dev && git pull origin dev Find and check out the existing branch, or create a new one linked to the issue: ```bash -gh issue develop --base dev --name feature/ --checkout +gh issue develop --base dev --name feature/- --checkout ``` > `--base` is required: `gh issue develop` reads the default base from the GitHub API, not from local working state. @@ -308,4 +308,4 @@ When done, say: **"The code is ready for review. Please run `make dev` and test - The issue is assigned to `@me` at creation. If you are creating a ticket on someone else's behalf, remove the assignee after creation with `gh issue edit --remove-assignee @me`. - Apply resolved labels and milestone to every new issue. Label resolution order: per-invocation flag → pool selection from `bug, documentation, enhancement, chore` → omit `--label` entirely. Never apply a label outside `bug, documentation, enhancement, chore`. - Milestone resolution order: per-invocation flag → auto-detected from GitHub open milestones. Never prompt for a milestone more than once per invocation. - + diff --git a/.claude/commands/submit-for-review.md b/.claude/commands/submit-for-review.md index 1fc51d3..0cfa625 100644 --- a/.claude/commands/submit-for-review.md +++ b/.claude/commands/submit-for-review.md @@ -66,12 +66,11 @@ Do not proceed until `make check` passes cleanly. ## Step 3 — Identify linked issue -Check for a linked issue by inspecting the branch name (should follow `feature/` linked via `gh issue develop`) or by running: -``` -gh pr view --json number,body 2>/dev/null -``` +Extract the issue number from the branch name. Branches created by `/start` follow the pattern `feature/-` (e.g. `feature/42-fix-login`). + +Parse the number from the branch name returned in Step 1. If the branch name matches `feature/-...`, use the extracted number as the linked issue. If the branch name does not contain a leading number after `feature/`, proceed without an issue reference but warn the user: -If a linked issue number is identifiable, note it for the PR body. If not identifiable, proceed without it but mention this to the user. +> "Could not extract an issue number from branch name ``. The PR will not include an issue reference. Was this branch created outside of `/start`?" --- @@ -362,4 +361,4 @@ If a single `gh issue create` call fails, report the failure for that finding an - `/submit-for-review` merges only to `dev` — never directly to `main`. - If `make merge` fails for any reason, report it and stop — do not attempt workarounds. - The follow-up issue offer in Step 9 runs only after a successful merge and only when the review produced non-blocking findings. Never prompt the user for follow-ups when the review blocked the merge — those findings should be fixed, not ticketed. - + diff --git a/.cursor/rules/start.mdc b/.cursor/rules/start.mdc index 14acaa0..858828e 100644 --- a/.cursor/rules/start.mdc +++ b/.cursor/rules/start.mdc @@ -214,7 +214,7 @@ git checkout dev && git pull origin dev Now create the feature branch: ```bash -gh issue develop --base dev --name feature/ --checkout +gh issue develop --base dev --name feature/- --checkout ``` > `--base` is required: `gh issue develop` reads the default base from the GitHub API, not from local working state, so `git checkout dev` on its own does not influence which branch the new feature branch is cut from. @@ -279,7 +279,7 @@ git checkout dev && git pull origin dev Find and check out the existing branch, or create a new one linked to the issue: ```bash -gh issue develop --base dev --name feature/ --checkout +gh issue develop --base dev --name feature/- --checkout ``` > `--base` is required: `gh issue develop` reads the default base from the GitHub API, not from local working state. @@ -314,4 +314,4 @@ When done, say: **"The code is ready for review. Please run `make dev` and test - The issue is assigned to `@me` at creation. If you are creating a ticket on someone else's behalf, remove the assignee after creation with `gh issue edit --remove-assignee @me`. - Apply resolved labels and milestone to every new issue. Label resolution order: per-invocation flag → pool selection from `bug, documentation, enhancement, chore` → omit `--label` entirely. Never apply a label outside `bug, documentation, enhancement, chore`. - Milestone resolution order: per-invocation flag → auto-detected from GitHub open milestones. Never prompt for a milestone more than once per invocation. - + diff --git a/.cursor/rules/submit-for-review.mdc b/.cursor/rules/submit-for-review.mdc index f274c95..0e647df 100644 --- a/.cursor/rules/submit-for-review.mdc +++ b/.cursor/rules/submit-for-review.mdc @@ -72,12 +72,11 @@ Do not proceed until `make check` passes cleanly. ## Step 3 — Identify linked issue -Check for a linked issue by inspecting the branch name (should follow `feature/` linked via `gh issue develop`) or by running: -``` -gh pr view --json number,body 2>/dev/null -``` +Extract the issue number from the branch name. Branches created by `/start` follow the pattern `feature/-` (e.g. `feature/42-fix-login`). + +Parse the number from the branch name returned in Step 1. If the branch name matches `feature/-...`, use the extracted number as the linked issue. If the branch name does not contain a leading number after `feature/`, proceed without an issue reference but warn the user: -If a linked issue number is identifiable, note it for the PR body. If not identifiable, proceed without it but mention this to the user. +> "Could not extract an issue number from branch name ``. The PR will not include an issue reference. Was this branch created outside of `/start`?" --- @@ -368,4 +367,4 @@ If a single `gh issue create` call fails, report the failure for that finding an - `/submit-for-review` merges only to `dev` — never directly to `main`. - If `make merge` fails for any reason, report it and stop — do not attempt workarounds. - The follow-up issue offer in Step 9 runs only after a successful merge and only when the review produced non-blocking findings. Never prompt the user for follow-ups when the review blocked the merge — those findings should be fixed, not ticketed. - + diff --git a/.gemini/skills/start/SKILL.md b/.gemini/skills/start/SKILL.md index 20d594a..5008a87 100644 --- a/.gemini/skills/start/SKILL.md +++ b/.gemini/skills/start/SKILL.md @@ -213,7 +213,7 @@ git checkout dev && git pull origin dev Now create the feature branch: ```bash -gh issue develop --base dev --name feature/ --checkout +gh issue develop --base dev --name feature/- --checkout ``` > `--base` is required: `gh issue develop` reads the default base from the GitHub API, not from local working state, so `git checkout dev` on its own does not influence which branch the new feature branch is cut from. @@ -278,7 +278,7 @@ git checkout dev && git pull origin dev Find and check out the existing branch, or create a new one linked to the issue: ```bash -gh issue develop --base dev --name feature/ --checkout +gh issue develop --base dev --name feature/- --checkout ``` > `--base` is required: `gh issue develop` reads the default base from the GitHub API, not from local working state. @@ -313,4 +313,4 @@ When done, say: **"The code is ready for review. Please run `make dev` and test - The issue is assigned to `@me` at creation. If you are creating a ticket on someone else's behalf, remove the assignee after creation with `gh issue edit --remove-assignee @me`. - Apply resolved labels and milestone to every new issue. Label resolution order: per-invocation flag → pool selection from `bug, documentation, enhancement, chore` → omit `--label` entirely. Never apply a label outside `bug, documentation, enhancement, chore`. - Milestone resolution order: per-invocation flag → auto-detected from GitHub open milestones. Never prompt for a milestone more than once per invocation. - + diff --git a/.gemini/skills/submit-for-review/SKILL.md b/.gemini/skills/submit-for-review/SKILL.md index d542089..6503e61 100644 --- a/.gemini/skills/submit-for-review/SKILL.md +++ b/.gemini/skills/submit-for-review/SKILL.md @@ -71,12 +71,11 @@ Do not proceed until `make check` passes cleanly. ## Step 3 — Identify linked issue -Check for a linked issue by inspecting the branch name (should follow `feature/` linked via `gh issue develop`) or by running: -``` -gh pr view --json number,body 2>/dev/null -``` +Extract the issue number from the branch name. Branches created by `/start` follow the pattern `feature/-` (e.g. `feature/42-fix-login`). + +Parse the number from the branch name returned in Step 1. If the branch name matches `feature/-...`, use the extracted number as the linked issue. If the branch name does not contain a leading number after `feature/`, proceed without an issue reference but warn the user: -If a linked issue number is identifiable, note it for the PR body. If not identifiable, proceed without it but mention this to the user. +> "Could not extract an issue number from branch name ``. The PR will not include an issue reference. Was this branch created outside of `/start`?" --- @@ -367,4 +366,4 @@ If a single `gh issue create` call fails, report the failure for that finding an - `/submit-for-review` merges only to `dev` — never directly to `main`. - If `make merge` fails for any reason, report it and stop — do not attempt workarounds. - The follow-up issue offer in Step 9 runs only after a successful merge and only when the review produced non-blocking findings. Never prompt the user for follow-ups when the review blocked the merge — those findings should be fixed, not ticketed. - + diff --git a/skills/start.md b/skills/start.md index 623c7d0..d2d15a1 100644 --- a/skills/start.md +++ b/skills/start.md @@ -264,12 +264,12 @@ Now create the feature branch: {{#if BRANCH_DEV}} ```bash -gh issue develop --base {{BRANCH_DEV}} --name feature/ --checkout +gh issue develop --base {{BRANCH_DEV}} --name feature/- --checkout ``` {{/if}} {{#if !BRANCH_DEV}} ```bash -gh issue develop --name feature/ --checkout +gh issue develop --name feature/- --checkout ``` {{/if}} @@ -345,12 +345,12 @@ Find and check out the existing branch, or create a new one linked to the issue: {{#if BRANCH_DEV}} ```bash -gh issue develop --base {{BRANCH_DEV}} --name feature/ --checkout +gh issue develop --base {{BRANCH_DEV}} --name feature/- --checkout ``` {{/if}} {{#if !BRANCH_DEV}} ```bash -gh issue develop --name feature/ --checkout +gh issue develop --name feature/- --checkout ``` {{/if}} diff --git a/skills/submit-for-review.md b/skills/submit-for-review.md index ce725cb..a2a2564 100644 --- a/skills/submit-for-review.md +++ b/skills/submit-for-review.md @@ -74,12 +74,11 @@ Do not proceed until `{{CHECK_CMD}}` passes cleanly. ## Step 3 — Identify linked issue -Check for a linked issue by inspecting the branch name (should follow `feature/` linked via `gh issue develop`) or by running: -``` -gh pr view --json number,body 2>/dev/null -``` +Extract the issue number from the branch name. Branches created by `/start` follow the pattern `feature/-` (e.g. `feature/42-fix-login`). + +Parse the number from the branch name returned in Step 1. If the branch name matches `feature/-...`, use the extracted number as the linked issue. If the branch name does not contain a leading number after `feature/`, proceed without an issue reference but warn the user: -If a linked issue number is identifiable, note it for the PR body. If not identifiable, proceed without it but mention this to the user. +> "Could not extract an issue number from branch name ``. The PR will not include an issue reference. Was this branch created outside of `/start`?" ---