diff --git a/.agents/skills/submit-for-review/SKILL.md b/.agents/skills/submit-for-review/SKILL.md index b7b281e..be30c00 100644 --- a/.agents/skills/submit-for-review/SKILL.md +++ b/.agents/skills/submit-for-review/SKILL.md @@ -35,7 +35,13 @@ If the current branch matches any of the above, **abort immediately** and say: First, move to the repository root so the command resolves against the correct Makefile / project config: ``` -cd "$(git rev-parse --show-toplevel)" +git rev-parse --show-toplevel +``` + +Then `cd` into the path returned above: + +``` +cd ``` Then verify the make target exists before running it. Extract the target name from `make check` (e.g. `make check` → `check`) and run: @@ -192,7 +198,13 @@ Wait for the review to complete and report its verdict. Before merging, verify the merge target exists. Move to the repo root, extract the target name from `make merge` (e.g. `make merge` → `merge`), and run: ``` -cd "$(git rev-parse --show-toplevel)" && make -n 2>/dev/null +git rev-parse --show-toplevel +``` + +Then `cd` into the path returned above and check the target: + +``` +cd && make -n 2>/dev/null ``` If `make -n` exits non-zero, **stop** and say: @@ -355,4 +367,4 @@ If a single `gh issue create` call fails, report the failure for that finding an - `/submit-for-review` merges only to `dev` — never directly to `main`. - If `make merge` fails for any reason, report it and stop — do not attempt workarounds. - The follow-up issue offer in Step 9 runs only after a successful merge and only when the review produced non-blocking findings. Never prompt the user for follow-ups when the review blocked the merge — those findings should be fixed, not ticketed. - + diff --git a/.claude/commands/submit-for-review.md b/.claude/commands/submit-for-review.md index 82a6a32..1fc51d3 100644 --- a/.claude/commands/submit-for-review.md +++ b/.claude/commands/submit-for-review.md @@ -30,7 +30,13 @@ If the current branch matches any of the above, **abort immediately** and say: First, move to the repository root so the command resolves against the correct Makefile / project config: ``` -cd "$(git rev-parse --show-toplevel)" +git rev-parse --show-toplevel +``` + +Then `cd` into the path returned above: + +``` +cd ``` Then verify the make target exists before running it. Extract the target name from `make check` (e.g. `make check` → `check`) and run: @@ -187,7 +193,13 @@ Wait for the review to complete and report its verdict. Before merging, verify the merge target exists. Move to the repo root, extract the target name from `make merge` (e.g. `make merge` → `merge`), and run: ``` -cd "$(git rev-parse --show-toplevel)" && make -n 2>/dev/null +git rev-parse --show-toplevel +``` + +Then `cd` into the path returned above and check the target: + +``` +cd && make -n 2>/dev/null ``` If `make -n` exits non-zero, **stop** and say: @@ -350,4 +362,4 @@ If a single `gh issue create` call fails, report the failure for that finding an - `/submit-for-review` merges only to `dev` — never directly to `main`. - If `make merge` fails for any reason, report it and stop — do not attempt workarounds. - The follow-up issue offer in Step 9 runs only after a successful merge and only when the review produced non-blocking findings. Never prompt the user for follow-ups when the review blocked the merge — those findings should be fixed, not ticketed. - + diff --git a/.cursor/rules/submit-for-review.mdc b/.cursor/rules/submit-for-review.mdc index 05f2d96..f274c95 100644 --- a/.cursor/rules/submit-for-review.mdc +++ b/.cursor/rules/submit-for-review.mdc @@ -36,7 +36,13 @@ If the current branch matches any of the above, **abort immediately** and say: First, move to the repository root so the command resolves against the correct Makefile / project config: ``` -cd "$(git rev-parse --show-toplevel)" +git rev-parse --show-toplevel +``` + +Then `cd` into the path returned above: + +``` +cd ``` Then verify the make target exists before running it. Extract the target name from `make check` (e.g. `make check` → `check`) and run: @@ -193,7 +199,13 @@ Wait for the review to complete and report its verdict. Before merging, verify the merge target exists. Move to the repo root, extract the target name from `make merge` (e.g. `make merge` → `merge`), and run: ``` -cd "$(git rev-parse --show-toplevel)" && make -n 2>/dev/null +git rev-parse --show-toplevel +``` + +Then `cd` into the path returned above and check the target: + +``` +cd && make -n 2>/dev/null ``` If `make -n` exits non-zero, **stop** and say: @@ -356,4 +368,4 @@ If a single `gh issue create` call fails, report the failure for that finding an - `/submit-for-review` merges only to `dev` — never directly to `main`. - If `make merge` fails for any reason, report it and stop — do not attempt workarounds. - The follow-up issue offer in Step 9 runs only after a successful merge and only when the review produced non-blocking findings. Never prompt the user for follow-ups when the review blocked the merge — those findings should be fixed, not ticketed. - + diff --git a/.gemini/skills/submit-for-review/SKILL.md b/.gemini/skills/submit-for-review/SKILL.md index 9d72f64..d542089 100644 --- a/.gemini/skills/submit-for-review/SKILL.md +++ b/.gemini/skills/submit-for-review/SKILL.md @@ -35,7 +35,13 @@ If the current branch matches any of the above, **abort immediately** and say: First, move to the repository root so the command resolves against the correct Makefile / project config: ``` -cd "$(git rev-parse --show-toplevel)" +git rev-parse --show-toplevel +``` + +Then `cd` into the path returned above: + +``` +cd ``` Then verify the make target exists before running it. Extract the target name from `make check` (e.g. `make check` → `check`) and run: @@ -192,7 +198,13 @@ Wait for the review to complete and report its verdict. Before merging, verify the merge target exists. Move to the repo root, extract the target name from `make merge` (e.g. `make merge` → `merge`), and run: ``` -cd "$(git rev-parse --show-toplevel)" && make -n 2>/dev/null +git rev-parse --show-toplevel +``` + +Then `cd` into the path returned above and check the target: + +``` +cd && make -n 2>/dev/null ``` If `make -n` exits non-zero, **stop** and say: @@ -355,4 +367,4 @@ If a single `gh issue create` call fails, report the failure for that finding an - `/submit-for-review` merges only to `dev` — never directly to `main`. - If `make merge` fails for any reason, report it and stop — do not attempt workarounds. - The follow-up issue offer in Step 9 runs only after a successful merge and only when the review produced non-blocking findings. Never prompt the user for follow-ups when the review blocked the merge — those findings should be fixed, not ticketed. - + diff --git a/skills/submit-for-review.md b/skills/submit-for-review.md index 91312ce..ce725cb 100644 --- a/skills/submit-for-review.md +++ b/skills/submit-for-review.md @@ -38,7 +38,13 @@ If the current branch matches any of the above, **abort immediately** and say: First, move to the repository root so the command resolves against the correct Makefile / project config: ``` -cd "$(git rev-parse --show-toplevel)" +git rev-parse --show-toplevel +``` + +Then `cd` into the path returned above: + +``` +cd ``` Then verify the make target exists before running it. Extract the target name from `{{CHECK_CMD}}` (e.g. `make check` → `check`) and run: @@ -211,7 +217,13 @@ Wait for the review to complete and report its verdict. Before merging, verify the merge target exists. Move to the repo root, extract the target name from `{{MERGE_CMD}}` (e.g. `make merge` → `merge`), and run: ``` -cd "$(git rev-parse --show-toplevel)" && make -n 2>/dev/null +git rev-parse --show-toplevel +``` + +Then `cd` into the path returned above and check the target: + +``` +cd && make -n 2>/dev/null ``` If `make -n` exits non-zero, **stop** and say: