Minor auto-refactor code cleanup on a massive scale (#2479)

Co-authored-by: labkey-tchad <[email protected]>

Author: labkey-jeckels

buildTestModules/communityArtifacts/src/org/labkey/communityartifacts/CommunityArtifactsController.java

@@ -40,7 +40,7 @@ public class BeginAction extends SimpleViewAction
     {
         public ModelAndView getView(Object o, BindException errors)
         {
-            return new JspView("/org/labkey/communityartifacts/view/hello.jsp");
+            return new JspView<>("/org/labkey/communityartifacts/view/hello.jsp");
         }
 
         @Override

buildTestModules/starterArtifacts/src/org/labkey/starterartifacts/StarterArtifactsController.java

@@ -40,7 +40,7 @@ public class BeginAction extends SimpleViewAction
     {
         public ModelAndView getView(Object o, BindException errors)
         {
-            return new JspView("/org/labkey/starterartifacts/view/hello.jsp");
+            return new JspView<>("/org/labkey/starterartifacts/view/hello.jsp");
         }
 
         @Override

data/qc/src/org/labkey/AbstractAssayValidator.java

@@ -31,9 +31,9 @@ public abstract class AbstractAssayValidator
     private String _email;
     private String _password;
     private File _errorFile;
-    private Map<String, String> _runProperties = new HashMap<>();
-    private Map<String, String> _transformFile = new HashMap<>();
-    private List<String> _errors = new ArrayList<>();
+    private final Map<String, String> _runProperties = new HashMap<>();
+    private final Map<String, String> _transformFile = new HashMap<>();
+    private final List<String> _errors = new ArrayList<>();
     private String _host;
 
     public enum Props {

data/qc/src/org/labkey/AssayTransformNoOp.java

@@ -15,16 +15,7 @@
  */
 package org.labkey;
 
-import java.io.BufferedReader;
-import java.io.BufferedWriter;
 import java.io.File;
-import java.io.FileReader;
-import java.io.FileWriter;
-import java.io.IOException;
-import java.io.PrintWriter;
-import java.util.Arrays;
-import java.util.List;
-import java.util.stream.Collectors;
 
 public class AssayTransformNoOp extends AbstractAssayValidator
 {

data/qc/src/org/labkey/AssayValidator.java

@@ -51,8 +51,8 @@ public void runQC(File inputFile, String username, String password, String host)
         if (getRunProperties().containsKey(Props.runDataFile.name()))
         {
             List<Map<String, String>> dataMap = parseRunData(new File(getRunProperties().get(Props.runDataFile.name())));
-            Map<String, String> ptidMap = new HashMap<String, String>();
-            Map<String, String> animalMap = new HashMap<String, String>();
+            Map<String, String> ptidMap = new HashMap<>();
+            Map<String, String> animalMap = new HashMap<>();
 
             for (Map<String, String> row : dataMap)
             {

modules/crawlerTest/src/org/labkey/crawlertest/CrawlerTestController.java

@@ -38,7 +38,7 @@ public CrawlerTestController()
     }
 
     @RequiresPermission(ReadPermission.class)
-    public class InjectJspAction extends SimpleViewAction<InjectForm>
+    public static class InjectJspAction extends SimpleViewAction<InjectForm>
     {
         @Override
         public void validate(InjectForm form, BindException errors)

modules/dumbster/src/com/dumbster/smtp/SimpleSmtpServer.java

@@ -59,7 +59,7 @@ public class SimpleSmtpServer implements Runnable {
   /**
    * Port the server listens on - set to the default SMTP port initially.
    */
-  private int port = DEFAULT_SMTP_PORT;
+  private final int port;
 
   /**
    * Timeout listening on server socket.
@@ -166,7 +166,6 @@ public synchronized void stop() {
    * @param out   output stream
    * @param input input stream
    * @return List of SmtpMessage
-   * @throws IOException
    */
   private List<SmtpMessage> handleTransaction(PrintWriter out, BufferedReader input) throws IOException {
     // Initialize the state machine

modules/editableModule/src/org/labkey/editablemodule/EditableModuleController.java

@@ -36,11 +36,12 @@ public EditableModuleController()
     }
 
     @RequiresPermission(ReadPermission.class)
-    public class HelloAction extends SimpleViewAction
+    public static class HelloAction extends SimpleViewAction<Object>
     {
+        @Override
         public ModelAndView getView(Object o, BindException errors)
         {
-            return new JspView("/org/labkey/editablemodule/view/hello.jsp");
+            return new JspView<>("/org/labkey/editablemodule/view/hello.jsp");
         }
 
         @Override

modules/linkedschematest/src/org/labkey/linkedschematest/TestLinkedSchemaCustomizer.java

@@ -42,7 +42,7 @@
  */
 public class TestLinkedSchemaCustomizer implements LinkedSchemaCustomizer
 {
-    private static Logger LOG = LogManager.getLogger(TestLinkedSchemaCustomizer.class);
+    private static final Logger LOG = LogManager.getLogger(TestLinkedSchemaCustomizer.class);
 
     // Name of the parameter declaration
     private static final String PARAM_FAMILY = "PARAM_FAMILY";

modules/linkedschematest/src/org/labkey/linkedschematest/TestTableCustomizer.java

@@ -23,7 +23,6 @@
 import org.labkey.api.data.TableInfo;
 
 import java.util.Collection;
-import java.util.List;
 
 public class TestTableCustomizer implements TableCustomizer
 {