Explicitly narrow number conversions

labkey-tchad · labkey-tchad · commit b2f9354d5708 · 2025-10-02T11:23:12.000-07:00
diff --git a/src/org/labkey/test/BaseWebDriverTest.java b/src/org/labkey/test/BaseWebDriverTest.java
@@ -543,7 +543,7 @@ Statement createFailOnTimeoutStatement(Statement statement, Class<?> testClass)
                 else
                     minutes = ClassTimeout.DEFAULT;
 
-                minutes *= timeoutMultiplier;
+                minutes = Math.round(minutes * timeoutMultiplier);
 
                 if (minutes == 0)
                     minutes = 1;
diff --git a/src/org/labkey/test/tests/SpecimenTest.java b/src/org/labkey/test/tests/SpecimenTest.java
@@ -825,7 +825,7 @@ private void verifyRequestingLocationCounts(StudyLocationType... types)
         waitForElement(Locators.bodyTitle().withText("New Specimen Request"));
         int expectedLocationCount = StudyLocationType.untypedSites();
 
-        long additionalLocations = Math.round(Math.pow(2, StudyLocationType.values().length - 1));
+        int additionalLocations = (int) Math.round(Math.pow(2, StudyLocationType.values().length - 1));
 
         for (StudyLocationType type : StudyLocationType.values())
         {

Original file line number	Diff line number	Diff line change
`@@ -825,7 +825,7 @@ private void verifyRequestingLocationCounts(StudyLocationType... types)`
`825`	`825`	`waitForElement(Locators.bodyTitle().withText("New Specimen Request"));`
`826`	`826`	`int expectedLocationCount = StudyLocationType.untypedSites();`
`827`	`827`
`828`		`- long additionalLocations = Math.round(Math.pow(2, StudyLocationType.values().length - 1));`
	`828`	`+ int additionalLocations = (int) Math.round(Math.pow(2, StudyLocationType.values().length - 1));`
`829`	`829`
`830`	`830`	`for (StudyLocationType type : StudyLocationType.values())`
`831`	`831`	`{`