Skip to content

Commit b141a1d

Browse files
Test fixes
1 parent 06aa62c commit b141a1d

4 files changed

Lines changed: 27 additions & 28 deletions

File tree

src/org/labkey/test/pages/issues/BaseUpdatePage.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -110,8 +110,8 @@ protected class ElementCache extends BaseIssuePage.ElementCache
110110
{
111111
protected ElementCache()
112112
{
113-
assignedTo = getSelect("assignedTo");
114-
priority = getSelect("priority");
113+
assignedTo = getSelect("AssignedTo");
114+
priority = getSelect("Priority");
115115
related = getInput("related");
116116
notifyList = getInput("notifyList");
117117
}

src/org/labkey/test/tests/FilterTest.java

Lines changed: 23 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,6 @@
4848
import static org.junit.Assert.assertEquals;
4949
import static org.labkey.test.params.FieldDefinition.ColumnType;
5050
import static org.labkey.test.params.FieldDefinition.DOMAIN_TRICKY_CHARACTERS;
51-
import static org.labkey.test.params.FieldDefinition.LookupInfo;
5251
import static org.labkey.test.util.PermissionsHelper.MemberType;
5352

5453
@Category({Daily.class, Data.class})
@@ -80,7 +79,7 @@ public class FilterTest extends BaseWebDriverTest
8079
protected final static String[] CONVERTED_MONTHS = { "2000-01-01", "2000-04-04", "2000-03-03", "2000-02-02" };
8180

8281
protected final FieldDefinition _list2ColKey = new FieldDefinition("Car", ColumnType.String);
83-
protected final FieldDefinition _list2Col1 = new FieldDefinition(LIST_KEY_NAME2, new LookupInfo(null, "lists", LIST_NAME_COLORS).setTableType(ColumnType.String)).setDescription("The color of the car");
82+
protected final FieldDefinition _list2Col1 = new FieldDefinition(LIST_KEY_NAME2, new FieldDefinition.StringLookup(null, "lists", LIST_NAME_COLORS)).setDescription("The color of the car");
8483
protected final FieldDefinition _list2ColYear = new FieldDefinition("year", ColumnType.Integer).setLabel("year");
8584

8685
@Override
@@ -284,15 +283,15 @@ public void testContainerFilterFacet() throws Exception
284283

285284
HashMap<String, String> projectIssue = new HashMap<>();
286285
projectIssue.put("title", "project issue1");
287-
projectIssue.put("assignedTo", getDisplayName());
288-
projectIssue.put("type", "typea");
289-
projectIssue.put("priority", "1");
286+
projectIssue.put("AssignedTo", getDisplayName());
287+
projectIssue.put("Type", "typea");
288+
projectIssue.put("Priority", "1");
290289
issuesHelper.addIssue(projectIssue);
291290
HashMap<String, String> projectIssue2 = new HashMap<>();
292291
projectIssue2.put("title", "project issue2");
293-
projectIssue2.put("assignedTo", getDisplayName());
294-
projectIssue2.put("type", "typeb");
295-
projectIssue2.put("priority", "2");
292+
projectIssue2.put("AssignedTo", getDisplayName());
293+
projectIssue2.put("Type", "typeb");
294+
projectIssue2.put("Priority", "2");
296295
issuesHelper.addIssue(projectIssue2);
297296

298297
_containerHelper.createSubfolder(getProjectName(), "subfolder");
@@ -310,15 +309,15 @@ public void testContainerFilterFacet() throws Exception
310309

311310
HashMap<String, String> subfolderIssue = new HashMap<>();
312311
subfolderIssue.put("title", "subfolder issue1");
313-
subfolderIssue.put("assignedTo", getDisplayName());
314-
subfolderIssue.put("type", "typed");
315-
subfolderIssue.put("priority", "3");
312+
subfolderIssue.put("AssignedTo", getDisplayName());
313+
subfolderIssue.put("Type", "typed");
314+
subfolderIssue.put("Priority", "3");
316315
issuesHelper.addIssue(subfolderIssue);
317316
HashMap<String, String> subfolderIssue2 = new HashMap<>();
318317
subfolderIssue2.put("title", "subfolder issue2");
319-
subfolderIssue2.put("assignedTo", getDisplayName());
320-
subfolderIssue2.put("type", "typee");
321-
subfolderIssue2.put("priority", "4");
318+
subfolderIssue2.put("AssignedTo", getDisplayName());
319+
subfolderIssue2.put("Type", "typee");
320+
subfolderIssue2.put("Priority", "4");
322321
issuesHelper.addIssue(subfolderIssue2);
323322

324323
goToProjectHome();
@@ -337,16 +336,16 @@ public void testContainerFilterFacet() throws Exception
337336
assertElementPresent(Locator.linkWithText(subfolderIssue2.get("title")));
338337

339338
verifyFacetOptions(region, "Type",
340-
projectIssue.get("type"),
341-
projectIssue2.get("type"),
342-
subfolderIssue.get("type"),
343-
subfolderIssue2.get("type"));
339+
projectIssue.get("Type"),
340+
projectIssue2.get("Type"),
341+
subfolderIssue.get("Type"),
342+
subfolderIssue2.get("Type"));
344343

345344
verifyFacetOptions(region, "Priority",
346-
projectIssue.get("priority"),
347-
projectIssue2.get("priority"),
348-
subfolderIssue.get("priority"),
349-
subfolderIssue2.get("priority"));
345+
projectIssue.get("Priority"),
346+
projectIssue2.get("Priority"),
347+
subfolderIssue.get("Priority"),
348+
subfolderIssue2.get("Priority"));
350349

351350
region.setFacetedFilter("Priority", projectIssue2.get("priority"), subfolderIssue.get("priority"));
352351
assertElementNotPresent(Locator.linkWithText(projectIssue.get("title")));
@@ -355,8 +354,8 @@ public void testContainerFilterFacet() throws Exception
355354
assertElementNotPresent(Locator.linkWithText(subfolderIssue2.get("title")));
356355

357356
verifyFacetOptions(region, "Type",
358-
projectIssue2.get("type"),
359-
subfolderIssue.get("type"));
357+
projectIssue2.get("Type"),
358+
subfolderIssue.get("Type"));
360359
}
361360

362361
private void verifyFacetOptions(DataRegionTable dataRegion, String column, String... options)

src/org/labkey/test/tests/viability/ViabilityTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,7 @@ protected void runUploadTest()
8989
assertEquals("5.0", getFormElement(Locator.name("_pool_160450533-5_0_VisitID")));
9090
assertEquals("3.700E7", getFormElement(Locator.name("_pool_160450533-5_0_TotalCells")));
9191
assertEquals("3.127E7", getFormElement(Locator.name("_pool_160450533-5_0_ViableCells")));
92-
assertEquals("84.5%", getFormElement(Locator.name("_pool_1604505335_0_Viability")));
92+
assertEquals("84.5%", getFormElement(Locator.name("_pool_160450533-5_0_Viability")));
9393
assertNotChecked(Locator.checkboxByName("_pool_160450533-5_0_Unreliable"));
9494
assertEquals("", getFormElement(Locator.name("_pool_160450533-5_0_IntValue")));
9595

src/org/labkey/test/util/IssuesHelper.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -188,7 +188,7 @@ public DetailsPage addIssue(String title, String assignedTo, Map<String, String>
188188
{
189189
Map<String, String> fields = new TreeMap<>();
190190
fields.put("title", title);
191-
fields.put("assignedTo", assignedTo);
191+
fields.put("AssignedTo", assignedTo);
192192
fields.putAll(extraFields);
193193
return addIssue(fields, attachments);
194194
}

0 commit comments

Comments
 (0)