Skip to content

Commit 72582a9

Browse files
committed
Use JSONArray
1 parent 1fb66b1 commit 72582a9

1 file changed

Lines changed: 2 additions & 15 deletions

File tree

src/org/labkey/test/util/exp/SampleTypeAPIHelper.java

Lines changed: 2 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@
1515
*/
1616
package org.labkey.test.util.exp;
1717

18+
import org.json.JSONArray;
1819
import org.junit.Assert;
1920
import org.labkey.remoteapi.CommandException;
2021
import org.labkey.remoteapi.Connection;
@@ -28,14 +29,12 @@
2829
import org.labkey.test.params.experiment.SampleTypeDefinition;
2930
import org.labkey.test.util.DomainUtils;
3031
import org.labkey.test.util.DomainUtils.DomainKind;
31-
import org.labkey.test.util.EscapeUtil;
3232
import org.labkey.test.util.TestDataGenerator;
3333

3434
import java.io.IOException;
3535
import java.util.ArrayList;
3636
import java.util.Arrays;
3737
import java.util.HashSet;
38-
import java.util.Iterator;
3938
import java.util.List;
4039
import java.util.Map;
4140
import java.util.NoSuchElementException;
@@ -150,19 +149,7 @@ public static Map<Integer, String> getSortedRowIdToSamplesMap(String containerPa
150149
public static Map<String, Integer> getRowIdsForSamples(String containerPath, String sampleTypeName, List<String> sampleNames) throws IOException, CommandException
151150
{
152151
// Use json for the value parameter of the filter. This allows for tricky characters like ";" to be passed to the API.
153-
StringBuilder json = new StringBuilder("{json:[");
154-
155-
Iterator<String> iterator = sampleNames.iterator();
156-
157-
while (iterator.hasNext())
158-
{
159-
String sampleName = iterator.next();
160-
json.append(EscapeUtil.toJSONStr(sampleName));
161-
if (iterator.hasNext())
162-
json.append(", ");
163-
else
164-
json.append("]}");
165-
}
152+
StringBuilder json = new StringBuilder("{json:").append(new JSONArray(sampleNames)).append("}");
166153

167154
// Use the details view to avoid column and filter settings on the default view
168155
String detailsView = "~~DETAILS~~";

0 commit comments

Comments
 (0)