AuditLogHelper.checkAuditEventDiffCount should set maxRows when no filters provided

cnathe · cnathe · commit 5a0628d02a55 · 2025-07-02T13:20:15.000-05:00
diff --git a/src/org/labkey/test/util/AuditLogHelper.java b/src/org/labkey/test/util/AuditLogHelper.java
@@ -176,7 +176,7 @@ public void checkAuditEventDiffCount(String containerPath, AuditEvent auditEvent
 
     public void checkAuditEventDiffCount(String containerPath, AuditEvent auditEventName, String eventDiffFieldName, List<Filter> filters, List<Integer> expectedDiffCounts) throws IOException, CommandException
     {
-        Integer maxRows = null;//expectedDiffCounts.size(); TODO decide on this up before merge
+        Integer maxRows = filters == null || filters.isEmpty() ? expectedDiffCounts.size() : null;
         List<Map<String, Object>> events = getAuditLogsFromLKS(containerPath, auditEventName, List.of("InventoryUpdateType", eventDiffFieldName), filters, maxRows, ContainerFilter.CurrentAndSubfolders).getRows();
         assertEquals("Unexpected number of events", expectedDiffCounts.size(), events.size());
         for (int i = 0; i < expectedDiffCounts.size(); i++)

Original file line number	Diff line number	Diff line change
`@@ -176,7 +176,7 @@ public void checkAuditEventDiffCount(String containerPath, AuditEvent auditEvent`
`176`	`176`
`177`	`177`	`public void checkAuditEventDiffCount(String containerPath, AuditEvent auditEventName, String eventDiffFieldName, List<Filter> filters, List<Integer> expectedDiffCounts) throws IOException, CommandException`
`178`	`178`	`{`
`179`		`- Integer maxRows = null;//expectedDiffCounts.size(); TODO decide on this up before merge`
	`179`	`+ Integer maxRows = filters == null \|\| filters.isEmpty() ? expectedDiffCounts.size() : null;`
`180`	`180`	`List<Map<String, Object>> events = getAuditLogsFromLKS(containerPath, auditEventName, List.of("InventoryUpdateType", eventDiffFieldName), filters, maxRows, ContainerFilter.CurrentAndSubfolders).getRows();`
`181`	`181`	`assertEquals("Unexpected number of events", expectedDiffCounts.size(), events.size());`
`182`	`182`	`for (int i = 0; i < expectedDiffCounts.size(); i++)`