Skip to content

Commit 5974f92

Browse files
committed
Remove WrapsFieldKey.java
1 parent c9c63d0 commit 5974f92

4 files changed

Lines changed: 8 additions & 22 deletions

File tree

src/org/labkey/test/components/ui/grids/FieldReferenceManager.java

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33
import org.jetbrains.annotations.NotNull;
44
import org.jetbrains.annotations.Nullable;
55
import org.labkey.test.params.FieldKey;
6-
import org.labkey.test.params.WrapsFieldKey;
76
import org.labkey.test.util.CachingSupplier;
87
import org.labkey.test.util.selenium.WebElementUtils;
98
import org.openqa.selenium.NoSuchElementException;
@@ -53,9 +52,9 @@ public FieldReference getColumnHeader(int index)
5352
{
5453
List<Supplier<FieldReference>> options;
5554

56-
if (fieldIdentifier instanceof WrapsFieldKey fk)
55+
if (fieldIdentifier instanceof FieldKey fk)
5756
{
58-
options = List.of(() -> findColumnHeaderByFieldKey(fk.getFieldKey())); // We know it is a FieldKey
57+
options = List.of(() -> findColumnHeaderByFieldKey(fk)); // We know it is a FieldKey
5958
}
6059
else
6160
{

src/org/labkey/test/params/FieldInfo.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* Immutable alternative to 'FieldDefinition'
88
* Use this for shared global field information
99
*/
10-
public class FieldInfo implements WrapsFieldKey
10+
public class FieldInfo
1111
{
1212
private final FieldKey _fieldKey;
1313
private final String _label;
@@ -57,7 +57,6 @@ public String getLabel()
5757
return Objects.requireNonNullElseGet(getRawLabel(), () -> FieldDefinition.labelFromName(_fieldKey.getName()));
5858
}
5959

60-
@Override
6160
public FieldKey getFieldKey()
6261
{
6362
return _fieldKey;

src/org/labkey/test/params/FieldKey.java

Lines changed: 5 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
import java.util.Iterator;
1010
import java.util.List;
1111

12-
public class FieldKey implements CharSequence, WrapsFieldKey
12+
public class FieldKey implements CharSequence
1313
{
1414
public static final FieldKey EMPTY = new FieldKey(""); // Useful as a sort of FieldKey builder starting point
1515
public static final FieldKey SOURCES_FK = new FieldKey("DataInputs");
@@ -61,9 +61,9 @@ public static FieldKey fromParts(String... parts)
6161
*/
6262
public static FieldKey fromFieldKey(CharSequence fieldKey)
6363
{
64-
if (fieldKey instanceof WrapsFieldKey fk)
64+
if (fieldKey instanceof FieldKey fk)
6565
{
66-
return fk.getFieldKey();
66+
return fk;
6767
}
6868
else
6969
{
@@ -78,8 +78,8 @@ public static FieldKey fromFieldKey(CharSequence fieldKey)
7878
*/
7979
public static FieldKey fromName(CharSequence nameOrFieldKey)
8080
{
81-
if (nameOrFieldKey instanceof WrapsFieldKey fk)
82-
return fk.getFieldKey();
81+
if (nameOrFieldKey instanceof FieldKey fk)
82+
return fk;
8383
else
8484
return fromParts(nameOrFieldKey.toString());
8585
}
@@ -144,12 +144,6 @@ public String[] getNameArray()
144144
return Arrays.stream(_fieldKey.split(SEPARATOR)).map(FieldKey::decodePart).toArray(String[]::new);
145145
}
146146

147-
@Override
148-
public FieldKey getFieldKey()
149-
{
150-
return this;
151-
}
152-
153147
@Override
154148
public @NotNull String toString()
155149
{

src/org/labkey/test/params/WrapsFieldKey.java

Lines changed: 0 additions & 6 deletions
This file was deleted.

0 commit comments

Comments
 (0)