Helper to create dataset categories with retry

Author: labkey-tchad

src/org/labkey/test/pages/reports/ManageViewsPage.java

@@ -17,11 +17,16 @@
 
 import org.labkey.test.Locator;
 import org.labkey.test.components.ChartQueryDialog;
+import org.labkey.test.components.ext4.Window;
 import org.labkey.test.components.html.BootstrapMenu;
 import org.labkey.test.pages.LabKeyPage;
 import org.labkey.test.util.LogMethod;
 import org.openqa.selenium.WebDriver;
 import org.openqa.selenium.WebElement;
+import org.openqa.selenium.support.ui.ExpectedConditions;
+import org.openqa.selenium.support.ui.WebDriverWait;
+
+import java.time.Duration;
 
 import static org.labkey.test.components.ext4.Window.Window;
 
@@ -34,7 +39,7 @@ public ManageViewsPage(WebDriver driver)
 
     public void clickAddReport(String reportType)
     {
-        BootstrapMenu.find(getDriver(),"Add Report").clickSubMenu(true,reportType);
+        new BootstrapMenu.BootstrapMenuFinder(getDriver()).withButtonTextContaining("Add Report").find().clickSubMenu(true,reportType);
     }
 
     public ChartQueryDialog clickAddChart()
@@ -89,4 +94,21 @@ public void viewReport(String reportName)
         mouseOver(reportLink);
         clickAndWait(reportLink);
     }
+
+    public void createCategory(String categoryName)
+    {
+        Locator.linkWithText("Manage Categories").findElement(getDriver()).click();
+        Window<?> categoryWindow = new Window.WindowFinder(getDriver()).withTitle("Manage Categories").waitFor();
+        for (int retry = 0; retry < 3; retry++)
+        {
+            categoryWindow.clickButton("New Category", 0);
+            WebElement newCategoryField = Locator.input("label").withAttributeContaining("id", "textfield").notHidden().waitForElement(categoryWindow, WAIT_FOR_JAVASCRIPT);
+            setFormElementJS(newCategoryField, categoryName);
+            fireEvent(newCategoryField, SeleniumEvent.blur);
+            new WebDriverWait(getDriver(), Duration.ofSeconds(2)).until(ExpectedConditions.invisibilityOf(newCategoryField));
+            Locator.tagWithText("div", categoryName).waitForElement(categoryWindow, 2_000);
+        }
+        clickButton("Done", 0);
+        categoryWindow.waitForClose();
+    }
 }

src/org/labkey/test/tests/SampleTypeLinkToStudyTest.java

@@ -24,12 +24,10 @@
 import org.labkey.test.params.FieldDefinition;
 import org.labkey.test.params.experiment.SampleTypeDefinition;
 import org.labkey.test.util.DataRegionTable;
-import org.labkey.test.util.Ext4Helper;
 import org.labkey.test.util.PortalHelper;
 import org.labkey.test.util.SampleTypeHelper;
 import org.labkey.test.util.StudyHelper;
 import org.labkey.test.util.TestDataGenerator;
-import org.openqa.selenium.WebElement;
 
 import java.io.File;
 import java.io.IOException;
@@ -773,17 +771,7 @@ private void createNewVisits(String label, String startRange, String endRange)
     private void createDatasetCategory(String projectName, String name)
     {
         goToProjectHome(projectName);
-        goToManageViews();
-        Locator.linkWithText("Manage Categories").findElement(getDriver()).click();
-        _extHelper.waitForExtDialog("Manage Categories");
-        Window<?> categoryWindow = new Window.WindowFinder(getDriver()).withTitle("Manage Categories").waitFor();
-        categoryWindow.clickButton("New Category", 0);
-        WebElement newCategoryField = Locator.input("label").withAttributeContaining("id", "textfield").notHidden().waitForElement(getDriver(), WAIT_FOR_JAVASCRIPT);
-        setFormElementJS(newCategoryField, name);
-        fireEvent(newCategoryField, SeleniumEvent.blur);
-        waitForElement(Ext4Helper.Locators.window("Manage Categories").append("//div").withText(name));
-        clickButton("Done", 0);
-        _extHelper.waitForExtDialogToDisappear("Manage Categories");
+        goToManageViews().createCategory(name);
     }
 
     private String getCategory(String projectName, String datasetName)