SignInPage: PR Feedback

labkey-alan · labkey-alan · commit 10ff78f6e3b5 · 2026-06-17T09:07:43.000-05:00
diff --git a/src/org/labkey/test/pages/core/login/SignInPage.java b/src/org/labkey/test/pages/core/login/SignInPage.java
@@ -61,7 +61,7 @@ protected ElementCache newElementCache()
         return new ElementCache();
     }
 
-    protected class ElementCache extends LabKeyPage<?>.ElementCache
+    protected class ElementCache extends LabKeyPage<ElementCache>.ElementCache
     {
         WebElement emailInput = Locator.id("email").findWhenNeeded(getDriver());
         WebElement passwordInput = Locator.id("password").findWhenNeeded(getDriver());

Original file line number	Diff line number	Diff line change
`@@ -61,7 +61,7 @@ protected ElementCache newElementCache()`
`61`	`61`	`return new ElementCache();`
`62`	`62`	`}`
`63`	`63`
`64`		`- protected class ElementCache extends LabKeyPage<?>.ElementCache`
	`64`	`+ protected class ElementCache extends LabKeyPage<ElementCache>.ElementCache`
`65`	`65`	`{`
`66`	`66`	`WebElement emailInput = Locator.id("email").findWhenNeeded(getDriver());`
`67`	`67`	`WebElement passwordInput = Locator.id("password").findWhenNeeded(getDriver());`