Skip to content

Commit 03da154

Browse files
Use the project when removing members for a project group
1 parent a90b8bb commit 03da154

4 files changed

Lines changed: 8 additions & 8 deletions

File tree

src/org/labkey/test/tests/UserPermissionsTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -267,7 +267,7 @@ public void testAuditLogForGroupUpdates()
267267

268268
log("Remove user from group and verify logs");
269269
goToProjectHome();
270-
permissionsHelper.removeUserFromGroup(GAMMA_SUBMITTER_GROUP_NAME, GAMMA_SUBMITTER_USER);
270+
permissionsHelper.removeUserFromGroup(GAMMA_SUBMITTER_GROUP_NAME, GAMMA_SUBMITTER_USER, getProjectName());
271271
verifyAuditLog("User: " + GAMMA_SUBMITTER_USER + " was deleted from Group: " + GAMMA_SUBMITTER_GROUP_NAME);
272272
}
273273

src/org/labkey/test/util/ApiPermissionsHelper.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -658,12 +658,12 @@ private List<String> getGroupNames(String project)
658658
}
659659

660660
@Override
661-
public void removeUserFromGroup(String groupName, String userName)
661+
public void removeUserFromGroup(String groupName, String userName, String projectPath)
662662
{
663663
Integer groupId = getGroupId(groupName);
664664
if (groupId == null)
665665
throw new IllegalArgumentException("Attempting to remove members from non-existent site group: " + groupName);
666-
removeMembersFromGroup(groupId, userName);
666+
removeMembersFromGroup(groupId, projectPath, userName);
667667
}
668668

669669
@Override
@@ -675,7 +675,7 @@ public void removeUserFromSiteGroup(String groupName, String userName)
675675
removeMembersFromGroup(groupId, userName);
676676
}
677677

678-
private void removeMembersFromGroup(Integer groupId, String... members)
678+
private void removeMembersFromGroup(Integer groupId, String projectPath, String... members)
679679
{
680680
BulkUpdateGroupCommand command = new BulkUpdateGroupCommand(groupId);
681681
command.setCreateGroup(false);
@@ -685,7 +685,7 @@ private void removeMembersFromGroup(Integer groupId, String... members)
685685
try
686686
{
687687
Connection connection = getConnection();
688-
command.execute(connection, "/");
688+
command.execute(connection, projectPath);
689689
}
690690
catch (IOException | CommandException e)
691691
{

src/org/labkey/test/util/PermissionsHelper.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -161,7 +161,7 @@ public void deleteGroup(String groupName)
161161
@LogMethod(quiet = true)
162162
public abstract void deleteGroup(@LoggedParam String groupName, boolean failIfNotFound);
163163

164-
public abstract void removeUserFromGroup(String groupName, String userName);
164+
public abstract void removeUserFromGroup(String groupName, String userName, String projectName);
165165
public abstract void removeUserFromSiteGroup(String groupName, String userName);
166166

167167
public abstract boolean doesGroupExist(String groupName, String projectName);

src/org/labkey/test/util/UIPermissionsHelper.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -317,11 +317,11 @@ public void deleteGroup(@LoggedParam String groupName, boolean failIfNotFound)
317317
@Override
318318
public void removeUserFromSiteGroup(String groupName, String userEmail)
319319
{
320-
removeUserFromGroup(groupName, userEmail);
320+
removeUserFromGroup(groupName, userEmail, "/");
321321
}
322322

323323
@Override
324-
public void removeUserFromGroup(String groupName, String userEmail)
324+
public void removeUserFromGroup(String groupName, String userEmail, String projectPath)
325325
{
326326
if (!_driver.isTextPresent("Group " + groupName))
327327
selectGroup(groupName);

0 commit comments

Comments
 (0)