Auto-refactor lint cleanup

SequencedCollections: get(0) -> getFirst(), etc
Add missing @NotNull/@nullable
Simplify test assertions
Map operation simplification
Remove redundant throws clause
Switch to parameterized log message
C-style array -> Java-style array declaration
Delete overridden methods identical to parent
Switch statement -> enhanced switch statement
Remove redundant imports

Author: labkey-jeckels

server/bootstrap/src/org/labkey/bootstrap/LabKeyBootstrapClassLoader.java

@@ -377,7 +377,7 @@ public File getDeletedModulesDirectory()
             }
             catch (IOException x)
             {
-                _log.info("Could not set hidden attribute on directory: " + deleted.getPath());
+                _log.info("Could not set hidden attribute on directory: {}", deleted.getPath());
             }
         }
 

server/bootstrap/src/org/labkey/bootstrap/ModuleArchive.java

@@ -87,7 +87,7 @@ private String nameFromModuleXML(InputStream is) throws IOException
                 @Override
                 public void startElement(String uri, String localName, String qName, Attributes attributes) throws SAXException
                 {
-                    String parent = elementStack.isEmpty() ? "" : elementStack.get(elementStack.size()-1);
+                    String parent = elementStack.isEmpty() ? "" : elementStack.getLast();
                     elementStack.add(qName+"#"+attributes.getValue("id"));
                     if (qName.equals("property") && "bean#moduleBean".equals(parent))
                     {
@@ -99,7 +99,7 @@ public void startElement(String uri, String localName, String qName, Attributes
                 @Override
                 public void endElement(String uri, String localName, String qName) throws SAXException
                 {
-                    elementStack.remove(elementStack.size()-1);
+                    elementStack.removeLast();
                 }
             });
 

server/embedded/src/org/labkey/embedded/LabKeyDeleteAction.java

@@ -151,7 +151,7 @@ private List<PathWithAttributes> selectFilesToDelete(Path basePath, List<PathWit
         if (logToRetain != null && !_copiedOriginal && logToRetain.getAttributes().size() > 0)
         {
             Path target = logToRetain.getPath().getParent().resolve("labkey-errors-" + DATE_FORMAT.format(new Date()) + ".log");
-            LOGGER.info("Retaining labkey-errors.log file before it gets deleted by rotation. Copying to " + target);
+            LOGGER.info("Retaining labkey-errors.log file before it gets deleted by rotation. Copying to {}", target);
 
             try
             {
@@ -161,7 +161,7 @@ private List<PathWithAttributes> selectFilesToDelete(Path basePath, List<PathWit
             }
             catch (IOException e)
             {
-                LOGGER.warn("Failed to retain error log file " + logToRetain.getPath(), e);
+                LOGGER.warn("Failed to retain error log file {}", logToRetain.getPath(), e);
             }
             _copiedOriginal = true;
         }

server/embedded/src/org/labkey/embedded/LabKeySpringBootClassLoader.java

@@ -43,7 +43,7 @@ public LabKeySpringBootClassLoader(ClassLoader parent)
                         if (is != null)
                         {
                             addURL(url);
-                            LOG.info("Added URL that resolves log4j2.xml to class loader: " + url);
+                            LOG.info("Added URL that resolves log4j2.xml to class loader: {}", url);
                         }
                     }
                     catch (IOException e)
@@ -65,7 +65,7 @@ public Class<?> loadClass(String name, boolean resolve) throws ClassNotFoundExce
             ClassLoader parent = getParent();
             while (parent != null)
             {
-                LOG.debug("Looking for SessionAppending - checking ClassLoader " + parent);
+                LOG.debug("Looking for SessionAppending - checking ClassLoader {}", parent);
                 if (parent.getClass().getName().equals("jdk.internal.loader.ClassLoaders$AppClassLoader") ||
                         parent.getClass().getName().equals("org.springframework.boot.loader.launch.LaunchedClassLoader"))
                 {

server/embedded/src/org/labkey/embedded/LabKeyTomcatServletWebServerFactory.java

@@ -394,12 +394,12 @@ private String getPropValue(Map<Integer, String> propValues, Integer resourceKey
     {
         if (propValues == null)
         {
-            LOG.debug(String.format("%1$s property was not provided, using default", propName));
+            LOG.debug("{} property was not provided, using default", propName);
             return defaultValue;
         }
 
         if (!propValues.containsKey(resourceKey))
-            LOG.debug(String.format("%1$s property was not provided for resource [%2$s], using default [%3$s]", propName, resourceKey, defaultValue));
+            LOG.debug("{} property was not provided for resource [{}], using default [{}]", propName, resourceKey, defaultValue);
 
         String val = propValues.getOrDefault(resourceKey, defaultValue);
         return val != null && !val.isBlank() ? val.trim() : defaultValue;