Skip to content

Commit 2f526a0

Browse files
Co-locate Claude review checklists with their skills (#1370)
#### Changes * Move jest and react checklist files into `.claude/skills/code-review-jest/` and `.claude/skills/code-review-react/` respectively. * Promote the shared reviewer-priority and review-format guidance to `.claude/skills/review-priority-and-format.md` (renamed from `common.md`); both code-review skills reference it via `../review-priority-and-format.md`. * Update Prerequisite links in each rule file to the new shared path. * Remove the now-empty `.agents/` directory. Co-authored-by: Claude Opus 4.7 (1M context) <[email protected]>
1 parent 495fa6b commit 2f526a0

9 files changed

Lines changed: 8 additions & 8 deletions

File tree

.agents/review-checklists/jest/business-logic.md renamed to .claude/skills/code-review-jest/business-logic.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# Business Logic
22

3-
> **Prerequisite:** Review and apply the common guidelines in [`common.md`](../common.md) before using this checklist.
3+
> **Prerequisite:** Review and apply the shared guidelines in [`review-priority-and-format.md`](../review-priority-and-format.md) before using this checklist.
44
55
## Jest tests must assert on meaningful outcomes
66

.agents/review-checklists/jest/code-quality.md renamed to .claude/skills/code-review-jest/code-quality.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# Code Quality
22

3-
> **Prerequisite:** Review and apply the common guidelines in [`common.md`](../common.md) before using this checklist.
3+
> **Prerequisite:** Review and apply the shared guidelines in [`review-priority-and-format.md`](../review-priority-and-format.md) before using this checklist.
44
55
## Arrange / Act / Assert (AAA) structure
66

.agents/review-checklists/jest/performance.md renamed to .claude/skills/code-review-jest/performance.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# Performance
22

3-
> **Prerequisite:** Review and apply the common guidelines in [`common.md`](../common.md) before using this checklist.
3+
> **Prerequisite:** Review and apply the shared guidelines in [`review-priority-and-format.md`](../review-priority-and-format.md) before using this checklist.
44
55
## No redundant or near-duplicate tests
66

.claude/skills/code-review-jest/skill.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ Use this skill whenever the user asks to review Jest test code (especially `.tes
1818
Stick to the checklist below for every applicable file and mode. Apply only the Jest checklist rules to test files — do not apply React component rules to component code that happens to be visible via imports in the test file.
1919

2020
## Checklist
21-
See [.agents/review-checklists/common.md](../../../.agents/review-checklists/common.md) for reviewer priority and standard review format, and [.agents/review-checklists/jest/code-quality.md](../../../.agents/review-checklists/jest/code-quality.md), [.agents/review-checklists/jest/performance.md](../../../.agents/review-checklists/jest/performance.md), [.agents/review-checklists/jest/business-logic.md](../../../.agents/review-checklists/jest/business-logic.md) for the living checklist split by category—treat it as the canonical set of rules to follow.
21+
See [review-priority-and-format.md](../review-priority-and-format.md) for reviewer priority and standard review format, and [code-quality.md](code-quality.md), [performance.md](performance.md), [business-logic.md](business-logic.md) for the living checklist split by category—treat it as the canonical set of rules to follow.
2222

2323
Use the rule's `Urgency` to place findings in the "urgent issues" vs "suggestions" sections.
2424

.agents/review-checklists/react/business-logic.md renamed to .claude/skills/code-review-react/business-logic.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# Rule Catalog — Business Logic
22

3-
> **Prerequisite:** Review and apply the common guidelines in [`common.md`](../common.md) before using this checklist.
3+
> **Prerequisite:** Review and apply the shared guidelines in [`review-priority-and-format.md`](../review-priority-and-format.md) before using this checklist.
44
55
## Avoid using array index as React key
66

.agents/review-checklists/react/code-quality.md renamed to .claude/skills/code-review-react/code-quality.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# Rule Catalog — Code Quality
22

3-
> **Prerequisite:** Review and apply the common guidelines in [`common.md`](../common.md) before using this checklist.
3+
> **Prerequisite:** Review and apply the shared guidelines in [`review-priority-and-format.md`](../review-priority-and-format.md) before using this checklist.
44
55
## Props interface should be declared separately
66

.agents/review-checklists/react/performance.md renamed to .claude/skills/code-review-react/performance.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# Rule Catalog — Performance
22

3-
> **Prerequisite:** Review and apply the common guidelines in [`common.md`](../common.md) before using this checklist.
3+
> **Prerequisite:** Review and apply the shared guidelines in [`review-priority-and-format.md`](../review-priority-and-format.md) before using this checklist.
44
55
## Event handlers should be memoized with `useCallback`
66

.claude/skills/code-review-react/skill.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ Use this skill whenever the user asks to review frontend code (especially `.tsx`
1818
Stick to the checklist below for every applicable file and mode. Apply only the React/frontend checklist rules — do not apply Jest test rules to test code that may be co-located or visible in the same file.
1919

2020
## Checklist
21-
See [.agents/review-checklists/common.md](../../../.agents/review-checklists/common.md) for reviewer priority and standard review format, and [.agents/review-checklists/react/code-quality.md](../../../.agents/review-checklists/react/code-quality.md), [.agents/review-checklists/react/performance.md](../../../.agents/review-checklists/react/performance.md), [.agents/review-checklists/react/business-logic.md](../../../.agents/review-checklists/react/business-logic.md) for the living checklist split by category—treat it as the canonical set of rules to follow.
21+
See [review-priority-and-format.md](../review-priority-and-format.md) for reviewer priority and standard review format, and [code-quality.md](code-quality.md), [performance.md](performance.md), [business-logic.md](business-logic.md) for the living checklist split by category—treat it as the canonical set of rules to follow.
2222

2323
Additionally, check for WCAG 2.2 Level AA accessibility violations using [wcag-22-checklist.md](../wcag-compliance/wcag-22-checklist.md). Use category **Accessibility** for these findings. Prioritize urgent WCAG criteria (missing alt text, keyboard traps, no focus indicators, missing form labels, broken ARIA) alongside Correctness-level issues.
2424

File renamed without changes.

0 commit comments

Comments
 (0)