Skip to content

Commit fb40b66

Browse files
committed
Fix some object instantiation problems
1 parent 51182b7 commit fb40b66

2 files changed

Lines changed: 2 additions & 14 deletions

File tree

api/src/org/labkey/api/workflow/Job.java

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -5,12 +5,9 @@
55
import org.jetbrains.annotations.NotNull;
66
import org.json.JSONObject;
77
import org.labkey.api.attachments.AttachmentFile;
8-
import org.labkey.api.collections.ArrayListMap;
9-
import org.labkey.api.collections.CaseInsensitiveHashMap;
108
import org.labkey.api.data.Container;
119
import org.labkey.api.data.ContainerManager;
1210
import org.labkey.api.data.CreatedModified;
13-
import org.labkey.api.data.ObjectFactory;
1411
import org.labkey.api.exp.Identifiable;
1512
import org.labkey.api.exp.Lsid;
1613
import org.labkey.api.exp.ObjectProperty;
@@ -323,10 +320,7 @@ public void setHasMedia(boolean hasMedia)
323320
_hasMedia = hasMedia;
324321
}
325322

326-
public Map<String, Object> toMap()
327-
{
328-
return new CaseInsensitiveHashMap<>(ObjectFactory.Registry.getFactory(Job.class).toMap(this, new ArrayListMap<>()));
329-
}
323+
public abstract Map<String, Object> toMap();
330324

331325
@JsonIgnore
332326
public List<Task> getSubsequentTasks(long taskId)

api/src/org/labkey/api/workflow/Task.java

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -5,11 +5,8 @@
55
import com.fasterxml.jackson.annotation.JsonProperty;
66
import org.jetbrains.annotations.NotNull;
77
import org.json.JSONObject;
8-
import org.labkey.api.collections.ArrayListMap;
9-
import org.labkey.api.collections.CaseInsensitiveHashMap;
108
import org.labkey.api.data.Container;
119
import org.labkey.api.data.CreatedModified;
12-
import org.labkey.api.data.ObjectFactory;
1310
import org.labkey.api.util.GUID;
1411

1512
import java.util.Date;
@@ -203,10 +200,7 @@ public void setJobId(Long jobId)
203200

204201
public abstract Job getJob();
205202

206-
public Map<String, Object> toMap()
207-
{
208-
return new CaseInsensitiveHashMap<>(ObjectFactory.Registry.getFactory(Task.class).toMap(this, new ArrayListMap<>()));
209-
}
203+
public abstract Map<String, Object> toMap();
210204

211205
// Determine if the template task with existing jobs can be updated to the new task definition
212206
// Only entityFilter field is allowed to be changed for a referenced template task

0 commit comments

Comments
 (0)