claude cr feedback

Author: cnathe

api/src/org/labkey/api/reports/ExternalScriptEngine.java

@@ -84,7 +84,7 @@ public class ExternalScriptEngine extends AbstractScriptEngine implements LabKey
     public static final String DEFAULT_WORKING_DIRECTORY = "ExternalScript";
     private static final Pattern scriptCmdPattern = Pattern.compile("'([^']+)'|\\\"([^\\\"]+)\\\"|(^[^\\s]+)|(\\s[^\\s^'^\\\"]+)");
 
-    private static final int MAX_PACKAGES_PER_RUN = 100;
+    private static final int MAX_PACKAGES_PER_RUN = 250;
 
     private FileLike _workingDirectory;
 

api/src/org/labkey/api/reports/report/ScriptPackageUsageTracker.java

@@ -15,8 +15,10 @@
  */
 package org.labkey.api.reports.report;
 
+import org.apache.logging.log4j.Logger;
 import org.labkey.api.reports.ExternalScriptEngine;
 import org.labkey.api.usageMetrics.SimpleMetricsService;
+import org.labkey.api.util.logging.LogHelper;
 
 import java.util.Map;
 import java.util.Set;
@@ -36,6 +38,8 @@
  */
 public class ScriptPackageUsageTracker
 {
+    private static final Logger LOG = LogHelper.getLogger(ScriptPackageUsageTracker.class, "Tracks R & Python package usage by server-side scripts");
+
     private static final String MODULE_NAME = "API";
     private static final String FEATURE_AREA_SUFFIX = "PackageUsage";
     private static final int MAX_METRIC_NAME_LENGTH = 255;
@@ -67,7 +71,14 @@ public static void record(String language, String packageName)
         if (packageName == null || packageName.isBlank() || isBasePackage(language, packageName))
             return;
 
-        SimpleMetricsService.get().increment(MODULE_NAME, language + FEATURE_AREA_SUFFIX, truncateMetricName(packageName));
+        try
+        {
+            SimpleMetricsService.get().increment(MODULE_NAME, language + FEATURE_AREA_SUFFIX, truncateMetricName(packageName));
+        }
+        catch (Exception e)
+        {
+            LOG.warn("Failed to record {} package usage for '{}'", language, packageName, e);
+        }
     }
 
     /**