Comments

Author: labkey-adam

api/src/org/labkey/api/action/BaseViewAction.java

@@ -349,7 +349,8 @@ protected Object newInstance(Class<?> c)
         return commandClass.isRecord() ? bindParametersToRecord(commandClass, params, getCommandName()) : defaultBindParameters(getCommand(), params);
     }
 
-    // Simple binding for Java records: no support for binding errors, arrays, lists, etc.
+    // Simple binding for Java records: provides binding errors for missing primitive parameters and type conversions
+    // failures. Current no support for array or list parameter types.
     public static <R> BindException bindParametersToRecord(Class<R> recordClass, PropertyValues pvs, String commandName)
     {
         // Note: We don't support record-based forms implementing HasAllowBindParameter since we must populate all
@@ -367,7 +368,8 @@ public static <R> BindException bindParametersToRecord(Class<R> recordClass, Pro
         }
         catch (IllegalArgumentException | ConversionException e)
         {
-            // We have no instance to bind to, so report a global error with details
+            // Missing primitive parameter or type conversion error. We have no instance to bind to, so report a global
+            // error with details.
             errors = new NullSafeBindException(new Object(), commandName);
             errors.reject(ERROR_MSG, "Unable to bind parameters to " + recordClass.getSimpleName() + ": " + e.getMessage());
         }

api/src/org/labkey/api/data/RecordFactory.java

@@ -69,6 +69,8 @@ public RecordFactory(Class<K> clazz)
             .toList();
     }
 
+    // Throws IllegalArgumentException for missing primitive parameters and ConversionExceptions for parameters that
+    // fail type conversion
     private <MAP extends Map<String, ?> & CaseInsensitiveCollection> K fromCaseInsensitiveMap(MAP m)
     {
         Object[] params = Arrays.stream(_parameters).map(p -> {