Fix LovCombo dropping string selections under native RegExp.escape

Newer browsers (Chrome, Firefox 140+) ship a native RegExp.escape that throws a TypeError on non-String input. Ext.ux.form.LovCombo.setValue() previously passed JSON.stringify(value) to RegExp.escape to avoid that, but JSON.stringify() quotes string values, so they no longer matched the raw, unquoted output of getCheckedValue() and every selection in a string-valued combo (e.g. the WNPRC EHR Time of Day multi-select) was silently dropped. Use String() instead: it yields a valid String for RegExp.escape without quoting string values, fixing both the numeric-valueField crash and the string-valueField regression.

LabKey/internal-issues#1266

Author: labkey-martyp

core/webapp/Ext.ux.form.LovCombo.js

@@ -293,8 +293,10 @@ Ext.ux.form.LovCombo = Ext.extend(Ext.form.ComboBox, {
                 this.store.suspendEvents(true);
 				this.store.clearFilter();
 				this.store.each(function (r) {
+					// Issue 7144: String() (not JSON.stringify) so native RegExp.escape doesn't throw on a
+					// numeric valueField, while string values stay unquoted to match getCheckedValue() output.
 					var checked = !(!v.match(
-							'(^|' + this.separator + ')' + RegExp.escape(JSON.stringify(r.get(this.valueField)))
+							'(^|' + this.separator + ')' + RegExp.escape(String(r.get(this.valueField)))
 							+ '(' + this.separator + '|$)'));
 					r.set(this.checkField, checked);
 				}, this);