Allow users to revert and enable "Submit" buttons during validation via an experimental feature flag if anything goes awry

Author: labkey-bpatel

ehr/resources/web/ehr/panel/DataEntryPanel.js

@@ -102,13 +102,16 @@ Ext4.define('EHR.panel.DataEntryPanel', {
             }
         }
 
-        var btns = this.getToolbarItems();
-        if (btns){
-            Ext4.Array.forEach(btns, function(toolbar){
-                toolbar.items.each(function(item){
-                    processItem(item);
+        var ehrContext = LABKEY.getModuleContext('ehr');
+        if (ehrContext && !ehrContext.isSubmitEnabledOnValidation) {
+            var btns = this.getToolbarItems();
+            if (btns) {
+                Ext4.Array.forEach(btns, function (toolbar) {
+                    toolbar.items.each(function (item) {
+                        processItem(item);
+                    }, this);
                 }, this);
-            }, this);
+            }
         }
     },
 

ehr/src/org/labkey/ehr/EHRManager.java

@@ -134,6 +134,8 @@ public class EHRManager
 
     public static final String SECURITY_PACKAGE = EHRCompletedInsertPermission.class.getPackage().getName();
 
+    public static final String EXPERIMENTAL_SUBMIT_ENABLED_ON_VALIDATION = "ehrSubmitEnabledDuringValidation";
+
     // Column name constants to reduce hardcoding
     private static final class ColumnNames
     {

ehr/src/org/labkey/ehr/EHRModule.java

@@ -58,6 +58,8 @@
 import org.labkey.api.query.SimpleTableDomainKind;
 import org.labkey.api.security.User;
 import org.labkey.api.security.roles.RoleManager;
+import org.labkey.api.settings.AppProps;
+import org.labkey.api.settings.OptionalFeatureService;
 import org.labkey.api.util.ContextListener;
 import org.labkey.api.util.JobRunner;
 import org.labkey.api.util.StartupListener;
@@ -289,6 +291,11 @@ public void moduleStartupComplete(ServletContext servletContext)
 
         // Register the Security Escalation Audit Log
         AuditLogService.get().registerAuditType(new EHRSecurityEscalatorAuditProvider());
+
+        OptionalFeatureService.get().addExperimentalFeatureFlag(EHRManager.EXPERIMENTAL_SUBMIT_ENABLED_ON_VALIDATION,
+                "Enable 'Submit' buttons during validation",
+                "User can submit form while validation is in progress",
+                false);
     }
 
     @Override
@@ -327,6 +334,9 @@ public JSONObject getPageContextJson(ContainerUser context)
         Map<String, String> map = getDefaultPageContextJson(c);
         Map<String, Object> ret = new HashMap<>(map);
 
+        // Expose the experimental 'submit enabled on validation' flag to client-side JavaScript
+        ret.put("isSubmitEnabledOnValidation", AppProps.getInstance().isOptionalFeatureEnabled(EHRManager.EXPERIMENTAL_SUBMIT_ENABLED_ON_VALIDATION));
+
         if (map.containsKey(EHRManager.EHRStudyContainerPropName) && map.get(EHRManager.EHRStudyContainerPropName) != null)
         {
             User u = context.getUser();