Skip to content

Commit 48081c4

Browse files
committed
Show bogus queryKey error
1 parent 34bfebd commit 48081c4

1 file changed

Lines changed: 21 additions & 22 deletions

File tree

pepdb/src/org/scharp/atlas/pepdb/PepDBController.java

Lines changed: 21 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,6 @@
3232
import org.labkey.api.view.ActionURL;
3333
import org.labkey.api.view.DetailsView;
3434
import org.labkey.api.view.GridView;
35-
import org.labkey.api.view.HttpView;
3635
import org.labkey.api.view.InsertView;
3736
import org.labkey.api.view.JspView;
3837
import org.labkey.api.view.NavTree;
@@ -170,29 +169,29 @@ public class GetPeptidesAction extends SimpleViewAction<PeptideQueryForm>
170169
@Override
171170
public ModelAndView getView(PeptideQueryForm form, BindException errors) throws Exception
172171
{
173-
if (!form.validate(errors))
172+
if (form.validate(errors))
174173
{
175-
return new JspView<>(PAGE_PEPTIDE_GROUP_SELECT, form, errors);
176-
}
177-
PropertyValues pv = this.getPropertyValues();
178-
ViewContext ctx = getViewContext();
179-
HttpSession session = ctx.getRequest().getSession(true);
180-
session.setAttribute("QUERY_FORM", form);
181-
GridView gridView = switch (form.getQueryKey())
182-
{
183-
case PepDBSchema.COLUMN_PEPTIDE_GROUP_ID -> getGridViewByGroup(form, pv);
184-
case PepDBSchema.COLUMN_PEPTIDE_POOL_ID -> getGridViewByPool(form, pv);
185-
case PepDBSchema.COLUMN_PROTEIN_CAT_ID -> getGridViewByProtein(form, pv);
186-
case PepDBSchema.COLUMN_PEPTIDE_SEQUENCE -> getGridViewBySequence(form, pv);
187-
case PepDBSchema.COLUMN_PARENT_SEQUENCE -> getGridViewByParent(form, pv);
188-
case PepDBSchema.COLUMN_CHILD_SEQUENCE -> getGridViewByChild(form, pv);
189-
default -> null;
190-
};
191-
if (gridView == null)
192-
{
193-
HttpView.redirect(new ActionURL(SearchForPeptidesAction.class, getContainer()));
174+
PropertyValues pv = this.getPropertyValues();
175+
GridView gridView = switch (form.getQueryKey())
176+
{
177+
case PepDBSchema.COLUMN_PEPTIDE_GROUP_ID -> getGridViewByGroup(form, pv);
178+
case PepDBSchema.COLUMN_PEPTIDE_POOL_ID -> getGridViewByPool(form, pv);
179+
case PepDBSchema.COLUMN_PROTEIN_CAT_ID -> getGridViewByProtein(form, pv);
180+
case PepDBSchema.COLUMN_PEPTIDE_SEQUENCE -> getGridViewBySequence(form, pv);
181+
case PepDBSchema.COLUMN_PARENT_SEQUENCE -> getGridViewByParent(form, pv);
182+
case PepDBSchema.COLUMN_CHILD_SEQUENCE -> getGridViewByChild(form, pv);
183+
default -> null;
184+
};
185+
if (gridView != null)
186+
{
187+
ViewContext ctx = getViewContext();
188+
HttpSession session = ctx.getRequest().getSession(true);
189+
session.setAttribute("QUERY_FORM", form);
190+
return gridView;
191+
}
192+
errors.reject(null, "Unrecognized queryKey: " + form.getQueryKey());
194193
}
195-
return gridView;
194+
return new JspView<>(PAGE_PEPTIDE_GROUP_SELECT, form, errors);
196195
}
197196

198197
@Override

0 commit comments

Comments
 (0)