Code review feedback

Author: labkey-klum

flow/src/org/labkey/flow/controllers/editscript/EditScriptForm.java

@@ -16,8 +16,8 @@
 
 package org.labkey.flow.controllers.editscript;
 
-import org.apache.logging.log4j.Logger;
 import org.apache.logging.log4j.LogManager;
+import org.apache.logging.log4j.Logger;
 import org.fhcrc.cpas.flow.script.xml.ScriptDocument;
 import org.jetbrains.annotations.NotNull;
 import org.labkey.api.security.permissions.UpdatePermission;
@@ -73,12 +73,7 @@ public void reset()
     {
         try
         {
-            ActionURL url = getViewContext().getActionURL();
-            // Read scriptId from the action URL (falling back to the request parameter) so it resolves under both
-            // real browser requests and in-JVM mock dispatch, mirroring how runId/compId below are read from the URL.
-            String scriptIdStr = url.getParameter("scriptId");
-            if (scriptIdStr == null)
-                scriptIdStr = getRequest().getParameter("scriptId");
+            String scriptIdStr = getRequest().getParameter("scriptId");
             if (scriptIdStr == null)
             {
                 throw new NotFoundException("scriptId required");
@@ -98,7 +93,7 @@ public void reset()
                 throw new NotFoundException("scriptId not found: " + scriptIdStr);
             }
             // GitHub Issue #1892: validate container
-            flowObject.checkContainer(getContainer(), getUser(), url);
+            flowObject.checkContainer(getContainer(), getUser(), getViewContext().getActionURL());
             _runCount = flowObject.getRunCount();
             step = FlowProtocolStep.fromRequest(getRequest());
             _run = FlowRun.fromURL(getViewContext().getActionURL(), getRequest(), getViewContext().getContainer(), getUser());