Skip to content

Commit 5c7a35f

Browse files
committed
Regression coverage for 52245
1 parent 4bf6571 commit 5c7a35f

2 files changed

Lines changed: 32 additions & 5 deletions

File tree

ms2/test/src/org/labkey/test/ms2/MS2TestBase.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,7 @@ protected void doCleanup(boolean afterTest) throws TestTimeoutException
8282

8383
protected void createProjectAndFolder()
8484
{
85-
_containerHelper.createProject(getProjectName(), null);
85+
_containerHelper.createProject(getProjectName(), "MS2");
8686
_containerHelper.createSubfolder(getProjectName(), FOLDER_NAME, "MS2");
8787

8888
log("Set bad pipeline root.");

ms2/test/src/org/labkey/test/tests/ms2/MS2Test.java

Lines changed: 31 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -71,13 +71,11 @@ protected void setupMS2()
7171
protected void verifyMS2()
7272
{
7373
verifyFirstRun();
74-
7574
validateSecondRun();
76-
7775
validateRunGroups();
78-
7976
queryValidationTest();
8077
pepXMLtest();
78+
validateContainerFilter();
8179
}
8280

8381
private void verifyFirstRun()
@@ -921,7 +919,7 @@ private void validateRunGroups()
921919
verifyGroupAudit();
922920
}
923921

924-
//verify audit trail registers runs added to or removed from groups.
922+
//verify audit trail registers runs added to or removed from groups.
925923
private void verifyGroupAudit()
926924
{
927925
List<Map<String, Object>> rows = executeSelectRowCommand("auditLog", "ExperimentAuditEvent").getRows();
@@ -1224,4 +1222,33 @@ public Set<String> getFilters()
12241222
}
12251223
return result;
12261224
}
1225+
1226+
/**
1227+
* Issue 52245 - container filter not getting propagated to run group lookup
1228+
*/
1229+
private void validateContainerFilter()
1230+
{
1231+
// create a run group at the project level
1232+
goToProjectHome(getProjectName());
1233+
clickAndWait(Locator.linkWithText("Run Groups"));
1234+
clickButton("Create Run Group");
1235+
setFormElement(Locator.name("name"), RUN_GROUP3_NAME);
1236+
clickButton("Submit");
1237+
1238+
navigateToFolder(FOLDER_NAME);
1239+
DataRegionTable runsTable = new DataRegionTable(REGION_NAME_SEARCH_RUNS, this);
1240+
runsTable.checkAllOnPage();
1241+
runsTable.clickHeaderMenu("Add to run group", RUN_GROUP3_NAME);
1242+
1243+
goToProjectHome(getProjectName());
1244+
goToSchemaBrowser();
1245+
DataRegionTable dataTable = viewQueryData("ms2", "XTandemPeptides");
1246+
dataTable.setContainerFilter(DataRegionTable.ContainerFilterType.CURRENT_AND_SUBFOLDERS);
1247+
1248+
_customizeViewsHelper.openCustomizeViewPanel();
1249+
_customizeViewsHelper.addColumn(new String[]{"Fraction", "Run", "ExperimentRunLSID", "RunGroups"});
1250+
_customizeViewsHelper.applyCustomView();
1251+
dataTable.setFilter("Fraction/Run/ExperimentRunLSID/RunGroups", "Is Blank");
1252+
assertEquals("All rows should have a value for the run group", 0, dataTable.getDataRowCount());
1253+
}
12271254
}

0 commit comments

Comments
 (0)