Skip to content

Commit 47d2b52

Browse files
committed
Get rid of more CustomizeView methods
1 parent 577c3ab commit 47d2b52

3 files changed

Lines changed: 8 additions & 6 deletions

File tree

ms2/test/src/org/labkey/test/tests/ms2/LibraTest.java

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@
2626
import org.labkey.test.categories.MS2;
2727
import org.labkey.test.components.CustomizeView;
2828
import org.labkey.test.ms2.MS2TestBase;
29+
import org.labkey.test.params.FieldKey;
2930
import org.labkey.test.util.DataRegionExportHelper;
3031
import org.labkey.test.util.DataRegionTable;
3132
import org.labkey.test.util.TextSearcher;
@@ -127,9 +128,9 @@ private void spectraCountTest()
127128
// Customize view to pull in other columns
128129
_customizeViewsHelper.openCustomizeViewPanel();
129130
_customizeViewsHelper.addColumn("TrimmedPeptide");
130-
_customizeViewsHelper.addColumn(new String[] {"Protein", "ProtSequence"});
131-
_customizeViewsHelper.addColumn(new String[] {"Protein", "BestName"});
132-
_customizeViewsHelper.addColumn(new String[] {"Protein", "Mass"});
131+
_customizeViewsHelper.addColumn(FieldKey.fromParts("Protein", "ProtSequence"));
132+
_customizeViewsHelper.addColumn(FieldKey.fromParts("Protein", "BestName"));
133+
_customizeViewsHelper.addColumn(FieldKey.fromParts("Protein", "Mass"));
133134
_customizeViewsHelper.saveDefaultView();
134135
assertTextPresent("84731", "MPEETQAQDQPMEEEEVETFAFQAEIAQLM");
135136

ms2/test/src/org/labkey/test/tests/ms2/MS2Test.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1249,7 +1249,7 @@ private void validateContainerFilter()
12491249
dataTable.setContainerFilter(DataRegionTable.ContainerFilterType.CURRENT_AND_SUBFOLDERS);
12501250

12511251
_customizeViewsHelper.openCustomizeViewPanel();
1252-
_customizeViewsHelper.addColumn(new String[]{"Fraction", "Run", "ExperimentRunLSID", "RunGroups"});
1252+
_customizeViewsHelper.addColumn(FieldKey.fromParts("Fraction", "Run", "ExperimentRunLSID", "RunGroups"));
12531253
_customizeViewsHelper.applyCustomView();
12541254
assertNotEquals("All rows should have a value for the run group", 0, dataTable.getDataRowCount());
12551255

ms2/test/src/org/labkey/test/tests/ms2/SequestImportTest.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@
2424
import org.labkey.test.categories.Daily;
2525
import org.labkey.test.categories.MS2;
2626
import org.labkey.test.components.CustomizeView;
27+
import org.labkey.test.params.FieldKey;
2728
import org.labkey.test.util.DataRegionTable;
2829
import org.labkey.test.util.FileBrowserHelper;
2930
import org.labkey.test.util.LogMethod;
@@ -38,8 +39,8 @@ public class SequestImportTest extends BaseWebDriverTest
3839
{
3940
private static final String PROJECT_NAME = "SequestImport" + TRICKY_CHARACTERS_FOR_PROJECT_NAMES;
4041

41-
private static final String[] TOTAL_PEPTIDES_FIELD_KEY = {"PeptideCounts", "TotalPeptides"};
42-
private static final String[] UNIQUE_PEPTIDES_FIELD_KEY = {"PeptideCounts", "DistinctPeptides"};
42+
private static final FieldKey TOTAL_PEPTIDES_FIELD_KEY = FieldKey.fromParts("PeptideCounts", "TotalPeptides");
43+
private static final FieldKey UNIQUE_PEPTIDES_FIELD_KEY = FieldKey.fromParts("PeptideCounts", "DistinctPeptides");
4344

4445
@Override
4546
protected String getProjectName()

0 commit comments

Comments
 (0)