Test fixes, consolidate code, add comments

labkey-jeckels · labkey-jeckels · commit 42f8300d162c · 2025-07-06T13:41:37.000-07:00
diff --git a/luminex/src/org/labkey/luminex/LuminexUploadWizardAction.java b/luminex/src/org/labkey/luminex/LuminexUploadWizardAction.java
@@ -432,6 +432,7 @@ else if (titrationEntry.getValue().isStandard())
                 public void writeSameCheckboxCell(RenderContext ctx, HtmlWriter out)
                 {
                     String titrationCellName = PageFlowUtil.filter(getTitrationColumnCellName(titrationEntry.getValue().getName()));
+                    // Use propName because ids can't have spaces
                     String groupName = ColumnInfo.propNameFromName(getColumns().get(0).getFormFieldName(ctx));
                     String id = groupName + "CheckBox";
 
diff --git a/luminex/src/org/labkey/luminex/query/NegativeBeadDisplayColumnGroup.java b/luminex/src/org/labkey/luminex/query/NegativeBeadDisplayColumnGroup.java
@@ -44,6 +44,7 @@ public void writeSameCheckboxCell(RenderContext ctx, HtmlWriter out)
     {
         TD(
             isCopyable() ? (DOM.Renderable) ret -> {
+                // Use propName because ids can't have spaces
                 String inputName = ColumnInfo.propNameFromName(_inputName);
                 String id = inputName + "CheckBox";
                 InputBuilder.checkbox().name(id).id(id).appendTo(out);

Original file line number	Diff line number	Diff line change
`@@ -432,6 +432,7 @@ else if (titrationEntry.getValue().isStandard())`
`432`	`432`	`public void writeSameCheckboxCell(RenderContext ctx, HtmlWriter out)`
`433`	`433`	`{`
`434`	`434`	`String titrationCellName = PageFlowUtil.filter(getTitrationColumnCellName(titrationEntry.getValue().getName()));`
	`435`	`+ // Use propName because ids can't have spaces`
`435`	`436`	`String groupName = ColumnInfo.propNameFromName(getColumns().get(0).getFormFieldName(ctx));`
`436`	`437`	`String id = groupName + "CheckBox";`
`437`	`438`
Original file line number	Diff line number	Diff line change
`@@ -44,6 +44,7 @@ public void writeSameCheckboxCell(RenderContext ctx, HtmlWriter out)`
`44`	`44`	`{`
`45`	`45`	`TD(`
`46`	`46`	`isCopyable() ? (DOM.Renderable) ret -> {`
	`47`	`+ // Use propName because ids can't have spaces`
`47`	`48`	`String inputName = ColumnInfo.propNameFromName(_inputName);`
`48`	`49`	`String id = inputName + "CheckBox";`
`49`	`50`	`InputBuilder.checkbox().name(id).id(id).appendTo(out);`