Skip to content

feat: use kube-utils certmanager for webhook certificate auto-rotation#356

Merged
ColdsteelRail merged 7 commits into
mainfrom
upgrade-webhook-self-sign
May 17, 2026
Merged

feat: use kube-utils certmanager for webhook certificate auto-rotation#356
ColdsteelRail merged 7 commits into
mainfrom
upgrade-webhook-self-sign

Conversation

@ColdsteelRail
Copy link
Copy Markdown
Member

  • Replace manual certificate generation with kube-utils/webhook/certmanager
  • Add volumeMounts in Helm chart for webhook-certs Secret
  • Unify Secret name to "webhook-certs" (matching Helm chart)
  • Auto-detect and rotate expired certificates
  • Add design plan document in docs/plans/

Fixes TLS handshake timeout issue when Helm updates controller.

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

2. What is the scope of this PR (e.g. component or file name):

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

6. Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ColdsteelRail ColdsteelRail force-pushed the upgrade-webhook-self-sign branch from 7f1ee99 to 58602d1 Compare April 27, 2026 12:26
ColdsteelRail and others added 6 commits May 17, 2026 14:26
- Replace manual certificate generation with kube-utils/webhook/certmanager
- Add volumeMounts in Helm chart for webhook-certs Secret
- Unify Secret name to "webhook-certs" (matching Helm chart)
- Auto-detect and rotate expired certificates
- Add design plan document in docs/plans/

Fixes TLS handshake timeout issue when Helm updates controller.

Co-Authored-By: Claude Opus 4.6 <[email protected]>
- Document pre-commit checklist: make build lint fmt vet
- Include project structure and key dependencies
- Add code conventions and commit message style
- Reference webhook certificate management design

Co-Authored-By: Claude Opus 4.6 <[email protected]>
Stop tracking plan documents in git. Update go.mod/go.sum after
rebase onto main.

Co-Authored-By: Claude Opus 4.6 <[email protected]>
@ColdsteelRail ColdsteelRail force-pushed the upgrade-webhook-self-sign branch from 58602d1 to daed24d Compare May 17, 2026 06:31
@codecov
Copy link
Copy Markdown

codecov Bot commented May 17, 2026

Codecov Report

❌ Patch coverage is 0% with 15 lines in your changes missing coverage. Please review.
✅ Project coverage is 47.23%. Comparing base (101f952) to head (3ce229c).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pkg/webhook/webhook.go 0.00% 15 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #356      +/-   ##
==========================================
+ Coverage   46.23%   47.23%   +0.99%     
==========================================
  Files         123      122       -1     
  Lines        7672     7491     -181     
==========================================
- Hits         3547     3538       -9     
+ Misses       3807     3631     -176     
- Partials      318      322       +4     
Flag Coverage Δ
unittests 47.23% <0.00%> (+0.99%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ColdsteelRail ColdsteelRail merged commit e40b0a3 into main May 17, 2026
12 of 13 checks passed
@ColdsteelRail ColdsteelRail deleted the upgrade-webhook-self-sign branch May 17, 2026 09:15
@github-actions github-actions Bot locked and limited conversation to collaborators May 17, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

提供灰度流量的能力

2 participants