feat: use kube-utils certmanager for webhook certificate auto-rotation#356
Merged
Conversation
7f1ee99 to
58602d1
Compare
- Replace manual certificate generation with kube-utils/webhook/certmanager - Add volumeMounts in Helm chart for webhook-certs Secret - Unify Secret name to "webhook-certs" (matching Helm chart) - Auto-detect and rotate expired certificates - Add design plan document in docs/plans/ Fixes TLS handshake timeout issue when Helm updates controller. Co-Authored-By: Claude Opus 4.6 <[email protected]>
- Document pre-commit checklist: make build lint fmt vet - Include project structure and key dependencies - Add code conventions and commit message style - Reference webhook certificate management design Co-Authored-By: Claude Opus 4.6 <[email protected]>
Co-Authored-By: Claude Opus 4.6 <[email protected]>
Co-Authored-By: Claude Opus 4.6 <[email protected]>
Stop tracking plan documents in git. Update go.mod/go.sum after rebase onto main. Co-Authored-By: Claude Opus 4.6 <[email protected]>
58602d1 to
daed24d
Compare
Co-Authored-By: Claude Opus 4.6 <[email protected]>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #356 +/- ##
==========================================
+ Coverage 46.23% 47.23% +0.99%
==========================================
Files 123 122 -1
Lines 7672 7491 -181
==========================================
- Hits 3547 3538 -9
+ Misses 3807 3631 -176
- Partials 318 322 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
zoumo
approved these changes
May 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes TLS handshake timeout issue when Helm updates controller.
1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):
2. What is the scope of this PR (e.g. component or file name):
3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):
4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):
5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:
6. Release note
Please refer to Release Notes Language Style Guide to write a quality release note.