[FEATURE] Make branch v5-dev for TYPO3 v14 compatibel to powermail v14 dev

[asche76]

Summary / Description

Short description of the bug.

Version

Version in which the bug occurs.

Steps to reproduce

How one can reproduce the issue - this is very important

Expected behaviour

What you expected to happen.

Actual behavior

What actually happens.

Additional

Possible fix

If you can, link to the line of code that might be responsible
for the problem or create a pull request if you have created
the fix already.

Miscellaneous

Add any other information like screenshots. You can also paste
any relevant logs. Please use code blocks (```) to format console
output, logs, and code as it's very hard to read otherwise.

[asche76]

the combination of insert record, paste_reference v5-dev and powermail v14 dev plugin causes this errors:
direct in right side preview / overview of records:
500
Oops, an error occurred!
Cannot assign string to property In2code\Powermail\Hook\PluginPreviewRenderer::$flexFormData of type ?TYPO3\CMS\Core\Domain\FlexFormFieldValues

Request: 8f8478b3921b5

and in T3 backend log:
Core: Exception handler (WEB): Uncaught TYPO3 Exception: Cannot assign string to property In2code\Powermail\Hook\PluginPreviewRenderer::$flexFormData of type ?TYPO3\CMS\Core\Domain\FlexFormFieldValues | TypeError thrown in file /typo3conf/ext/powermail/Classes/Hook/PluginPreviewRenderer.php in line 49. Requested URL: htyxc.de/typo3/module/web/layout?token=--AnonymizedToken--530882689083a029518b68de&id=3356&

without paste_reference v5-dev it looks good

[DavidBruchmann]

Thanks, first for confirming general functionality, and also for reporting the bug.

Can you advise how to reproduce the bug, preferable in most easy way?

[DavidBruchmann]

might be that I got it wrong about the general functionality, which seems to refer to powermail rather than paste_reference. Did you test paste_reference without powermail?

[DavidBruchmann]

@asche76 after some work on the extension, perhaps you can check again.
Actually I don't expect the error to be gone, but perhaps we've luck.

[Kephson]

Hi, I released a new version for TYPO3 13.4 (4.0.4) and an intial version for TYPO3 14.3 (5.0.0).

[asche76]

sadly no changes (i use latest powermail v14 dev from today morning) and paste_reference 5.
paste_reference disabled - all is good:

paste_reference activated:

Core: Exception handler (WEB): Uncaught TYPO3 Exception: Cannot assign string to property In2code\Powermail\Hook\PluginPreviewRenderer::$flexFormData of type ?TYPO3\CMS\Core\Domain\FlexFormFieldValues | TypeError thrown in file /.../typo3conf/ext/powermail/Classes/Hook/PluginPreviewRenderer.php in line 49.
Requested URL: h.../typo3/module/web/layout?token=--AnonymizedToken--d364b21b8b0400c212c34b68&id=3356

Request: 05f9fe4f2fad0

[DavidBruchmann]

I don't have a license or copy of powermail v14-dev. I requested one but didn't get feedback yet. So I can't reproduce it and don't know what I had to change.

[DavidBruchmann]

I can imagine that the error would be gone if the default value of the table field tt_content.pi_flexform would be [] (opening and closing squared bracket). For existing elements this value had to be set for trying.
usually the default value is null

Furthermore this is an issue for powermail in general I guess, as in v13 it seems a check is missing if the field is filled at all:

    public function renderPageModulePreviewContent(GridColumnItem $item): string
    {
        $row = $item->getRecord();

        $flexFormService = GeneralUtility::makeInstance(FlexFormService::class);

        $flexforms = $flexFormService->convertFlexFormContentToArray($row['pi_flexform']);

        if (!is_array($flexforms)) {
            return 'ERROR: ' . htmlspecialchars($flexforms);    // line 49  <<<<<<<<<<<<<<<<<<
        }

        $this->flexFormData = $flexforms;

        $preview = '';
        if (!ConfigurationUtility::isDisablePluginInformationActive() && $this->flexFormData !== []) {
            $preview = match ($row['CType']) {
                'powermail_pi1' => $this->getPluginInformation('Pi1', $row),
                'powermail_pi2' => $this->getPluginInformation('Pi2', $row),
                'powermail_pi3' => $this->getPluginInformation('Pi3', $row),
                'powermail_pi4' => $this->getPluginInformation('Pi4', $row),
                default => '',
            };
        }
        ...
    }

just changing the default value and the value of existing records would certainly be a hack, even if it's working. Instead the FlexFormService should assign [] if the field is empty

$flexforms = $flexFormService->convertFlexFormContentToArray($row['pi_flexform']);

Also I can't be sure that these lines are the same in powermail v14-dev, but that's something you could look up, @asche76