added debug logs

Author: pvagare-ks

keepercommander/importer/cyberark/pam/import_builder.py

@@ -291,6 +291,27 @@ def format_duration(seconds: float) -> str:
     return f"{s}s"
 
 
+def format_unmapped_section(unmapped_items: Optional[List[dict]]) -> str:
+    """Format the UNMAPPED manual-action section for debug logging."""
+    if not unmapped_items:
+        return ''
+    lines = [
+        ' UNMAPPED — REQUIRES MANUAL ACTION',
+        ' ' + '-' * 40,
+    ]
+    by_category = {}  # type: Dict[str, List[dict]]
+    for item in unmapped_items:
+        cat = item.get("category", "Other")
+        by_category.setdefault(cat, []).append(item)
+    for cat, items in sorted(by_category.items()):
+        lines.append(f'   {cat}:')
+        for item in items:
+            lines.append(f'     {item.get("item", "")}')
+            lines.append(f'       Action: {item.get("action", "")}')
+        lines.append('')
+    return "\n".join(lines)
+
+
 def build_report(project_name: str, safes_processed: int, total_accounts: int,
                  resource_counts: Dict[str, Dict[str, int]],
                  platform_counts: Dict[str, Dict[str, Any]],
@@ -402,20 +423,9 @@ def build_report(project_name: str, safes_processed: int, total_accounts: int,
             lines.append(f'   Incomplete (missing fields): {incomplete_count}')
         lines.append('')
 
-    # UNMAPPED section
+    # UNMAPPED details are debug-only (see format_unmapped_section / logging.debug)
     if unmapped_items:
-        lines.append(' UNMAPPED — REQUIRES MANUAL ACTION')
-        lines.append(' ' + '-' * 40)
-        by_category = {}  # type: Dict[str, List[dict]]
-        for item in unmapped_items:
-            cat = item.get("category", "Other")
-            by_category.setdefault(cat, []).append(item)
-        for cat, items in sorted(by_category.items()):
-            lines.append(f'   {cat}:')
-            for item in items:
-                lines.append(f'     {item.get("item", "")}')
-                lines.append(f'       Action: {item.get("action", "")}')
-            lines.append('')
+        logging.debug('\n%s', format_unmapped_section(unmapped_items))
 
     # Gateway deployment
     gw_token = ''
@@ -435,9 +445,13 @@ def build_report(project_name: str, safes_processed: int, total_accounts: int,
     # Next steps
     lines.append(' NEXT STEPS')
     lines.append(' ' + '-' * 40)
-    lines.append(f'   1. Review UNMAPPED section — action each item')
-    lines.append(f'   2. Verify: pam gateway list')
-    lines.append(f'   3. Cleanup: pam project cyberark-cleanup --name "{project_name}"')
+    step = 1
+    if unmapped_items:
+        lines.append(f'   {step}. Review unmapped items in debug log (--debug)')
+        step += 1
+    lines.append(f'   {step}. Verify: pam gateway list')
+    step += 1
+    lines.append(f'   {step}. Cleanup: pam project cyberark-cleanup --name "{project_name}"')
     lines.append('')
 
     # Command (redacted)

tests/test_cyberark_pam_import.py

@@ -2555,32 +2555,37 @@ def test_returns_429_after_max_retries(self, mock_dns, mock_requests, mock_sleep
 class TestEnhancedReport:
     """Tests for the enhanced build_report with all sections."""
 
-    def test_report_has_all_sections(self):
+    def test_report_has_all_sections(self, caplog):
+        import logging
         from keepercommander.importer.cyberark.cyberark_pam import build_report
-        report = build_report(
-            project_name="Test",
-            safes_processed=3,
-            total_accounts=50,
-            resource_counts={"pamMachine": {"ok": 20, "skip": 0, "err": 0},
-                             "login": {"ok": 10, "skip": 0, "err": 0}},
-            platform_counts={"UnixSSH": {"rotation": "general", "count": 20}},
-            skipped=[{"reason": "password retrieval failed"}],
-            incomplete_count=2,
-            duration=120.0,
-            unmapped_items=[{"category": "Master Policy",
-                             "item": "Dual control = Active",
-                             "action": "Use ticketing"}],
-            server="pvwa.example.com",
-        )
+        with caplog.at_level(logging.DEBUG):
+            report = build_report(
+                project_name="Test",
+                safes_processed=3,
+                total_accounts=50,
+                resource_counts={"pamMachine": {"ok": 20, "skip": 0, "err": 0},
+                                 "login": {"ok": 10, "skip": 0, "err": 0}},
+                platform_counts={"UnixSSH": {"rotation": "general", "count": 20}},
+                skipped=[{"reason": "password retrieval failed"}],
+                incomplete_count=2,
+                duration=120.0,
+                unmapped_items=[{"category": "Master Policy",
+                                 "item": "Dual control = Active",
+                                 "action": "Use ticketing"}],
+                server="pvwa.example.com",
+            )
         assert "SOURCE SUMMARY" in report
         assert "IMPORT RESULTS" in report
         assert "PLATFORM MAPPING" in report
         assert "SKIPPED ACCOUNTS" in report
-        assert "UNMAPPED" in report
+        assert "UNMAPPED — REQUIRES MANUAL ACTION" not in report
+        assert "Dual control" not in report
+        assert "debug log" in report
         assert "NEXT STEPS" in report
         assert "COMMAND" in report
         assert "pvwa.example.com" in report
-        assert "Dual control" in report
+        assert "UNMAPPED — REQUIRES MANUAL ACTION" in caplog.text
+        assert "Dual control" in caplog.text
 
     def test_report_gateway_token(self):
         from keepercommander.importer.cyberark.cyberark_pam import build_report