Skip to content

Commit b7cfeaf

Browse files
authored
Merge pull request #402 from MrS-ibra/fix/ui-focus
Fix text entry focus issues across lobby UI
2 parents a795103 + a7ad5e1 commit b7cfeaf

5 files changed

Lines changed: 5 additions & 5 deletions

File tree

GeneralsMD/Code/GameEngine/Source/GameClient/GUI/GUICallbacks/Menus/PopupHostGame.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -395,7 +395,7 @@ void PopupHostGameInit( WindowLayout *layout, void *userData )
395395
GadgetCheckBoxSetChecked( checkBoxLimitArmies, usingStats? FALSE : customPref.getFactionsLimited() );
396396
#endif
397397

398-
TheWindowManager->winSetFocus( parentPopup );
398+
TheWindowManager->winSetFocus(textEntryGameName);
399399
TheWindowManager->winSetModal( parentPopup );
400400

401401
#if defined(GENERALS_ONLINE)

GeneralsMD/Code/GameEngine/Source/GameClient/GUI/GUICallbacks/Menus/PopupJoinGame.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -112,7 +112,7 @@ void PopupJoinGameInit( WindowLayout *layout, void *userData )
112112
UnicodeString lobbyName(from_utf8(lobbyTryingToJoin.name).c_str());
113113
GadgetStaticTextSetText(staticTextGameName, lobbyName);
114114

115-
TheWindowManager->winSetFocus( parentPopup );
115+
TheWindowManager->winSetFocus(textEntryGamePassword);
116116
TheWindowManager->winSetModal( parentPopup );
117117

118118
}

GeneralsMD/Code/GameEngine/Source/GameClient/GUI/GUICallbacks/Menus/WOLBuddyOverlay.cpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1325,6 +1325,7 @@ WindowMsgHandledType WOLBuddyOverlaySystem( GameWindow *window, UnsignedInt msg,
13251325
pSocialInterface->ClearUnreadChatMessagesForUser(profileID);
13261326
updateBuddyInfo(true, true); // use cache
13271327
}
1328+
TheWindowManager->winSetFocus(buddyControls.textEntryEdit);
13281329
}
13291330
}
13301331
}

GeneralsMD/Code/GameEngine/Source/GameClient/GUI/GUICallbacks/Menus/WOLGameSetupMenu.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2122,9 +2122,9 @@ void WOLGameSetupMenuInit( WindowLayout *layout, void *userData )
21222122
enterTime = timeGetTime();
21232123

21242124
// Set Keyboard to chat entry
2125-
TheWindowManager->winSetFocus( textEntryChat );
21262125
raiseMessageBoxes = true;
21272126
TheTransitionHandler->setGroup("GameSpyGameOptionsMenuFade");
2127+
TheWindowManager->winSetFocus(textEntryChat);
21282128

21292129
#if defined(GENERALS_ONLINE)
21302130
// NGMP: Did we just enter a lobby with modified camera height?

GeneralsMD/Code/GameEngine/Source/GameClient/GUI/GUICallbacks/Menus/WOLLobbyMenu.cpp

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1387,8 +1387,6 @@ void WOLLobbyMenuInit( WindowLayout *layout, void *userData )
13871387
}
13881388
*/
13891389

1390-
// Set Keyboard to chat window
1391-
TheWindowManager->winSetFocus( textEntryChat );
13921390
raiseMessageBoxes = true;
13931391

13941392
TheLobbyQueuedUTMs.clear();
@@ -1737,6 +1735,7 @@ void WOLLobbyMenuUpdate( WindowLayout * layout, void *userData)
17371735
{
17381736
TheTransitionHandler->remove("MainMenuDefaultMenuLogoFade");
17391737
TheTransitionHandler->setGroup("WOLCustomLobbyFade");
1738+
TheWindowManager->winSetFocus(textEntryChat);
17401739
initialGadgetDelay = 2;
17411740
justEntered = FALSE;
17421741
}

0 commit comments

Comments
 (0)