Unitcell class creates Index out of error atmakerings method

[abmajith]

HI @jonwright

It happens only for the certain combination of lattice parameters, not for all lattice parameters

Traceback (most recent call last):

  File "/home/noordhee/BMLine_Projects/ewoksImageD11/ewoks3dxrd/src/orangecontrib/ewoks3dxrd/lattice_filter.py", line 114, in _plotRings
    unit_cell.makerings(limit=limit)

  File "/home/noordhee/BMLine_Projects/ewoksImageD11/ewoks3dxrd/venv/lib/python3.12/site-packages/ImageD11/unitcell.py", line 498, in makerings
    peak = self.peaks[0]
           ~~~~~~~~~~^^^

IndexError: list index out of range

[jonwright]

It suggests there are no peaks found. Which lattice parameters and limit are you testing?

We could add something to suppress that exception, but you still need a way to prevent it going forward in the processing. When there are no peaks the indexing is not going to go well.

[abmajith]

It suggests there are no peaks found. Which lattice parameters and limit are you testing?

We could add something to suppress that exception, but you still need a way to prevent it going forward in the processing. When there are no peaks the indexing is not going to go well.

We are using the lattice parameters: (a,b,c,alpha,beta,gamma, space_group) = (1.0, 0.01, 1.0, 90, 90, 90, 229)

we found this error while just plotting the rings for the given lattice parameter in the GUI, not explicitly computing the ds,eta for the given column file,

           unit_cell = UnitCell(
                lattice_parameters=params["lattice_parameters"],
                symmetry=int(params["lattice_space_group"]),
            )
            unit_cell.makerings(limit=limit)

            for i, ring_ds in enumerate(unit_cell.ringds):
                self._plot.addCurve(
                    [ring_ds, ring_ds], [-190, 190], legend=f"Ring_{i}", linewidth=2
                )
            self._plot.setGraphXLabel("Reciprocal Distance (ds)")
            self._plot.setGraphYLabel("Azimuthal Angle (eta)")

[jonwright]

I think there are no rings up to your limit. What do you want to happen in this case?

[abmajith]

I think there are no rings up to your limit. What do you want to happen in this case?

ohh, its like that, then i should increase the limit and check