Clarify node point coordinates are absolute, not room-relative - #357
Conversation
Companion issue ESPresense/ESPresense-companion#955: the 'within room' wording led multi-story users to enter floor-relative z values, which excludes nodes from locating and renders them at ground level. Co-Authored-By: Claude Fable 5 <[email protected]> Claude-Session: https://claude.ai/code/session_01GbJPc22rkttkVsifQgUSbY
|
Warning Review limit reached
Next review available in: 59 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Deploying espresense with
|
| Latest commit: |
56cd6b2
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://d8099289.espresense.pages.dev |
| Branch Preview URL: | https://docs-node-point-absolute.espresense.pages.dev |
1 participant
Fixes the wording that caused ESPresense/ESPresense-companion#955 (and duplicates): the Nodes section said
pointis "x,y,z coordinates within room", but companion treats all coordinates as absolute — z must include the floor's base elevation. Users on multi-story homes who followed the docs got nodes silently excluded from locating and rendered at ground level in the 3D view.Companion-side warning for this misconfiguration: ESPresense/ESPresense-companion#1635
🤖 Generated with Claude Code
https://claude.ai/code/session_01GbJPc22rkttkVsifQgUSbY