Skip to content

Aura Designer: default new icon/square border inset to 0 #138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Krathe82 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Aura Designer: default new icon/square border inset to 0 #138

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions AuraDesigner/Indicators.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2101,7 +2101,7 @@ function Indicators:ConfigureIcon(frame, config, defaults, auraName, priority)
if borderEnabled == nil then borderEnabled = config.borderEnabled end
if borderEnabled == nil then borderEnabled = true end
local borderThickness = config.BorderSize or config.borderThickness or 1
local borderInset = config.BorderInset or config.borderInset or 1
local borderInset = config.BorderInset or config.borderInset or 0

local adBorder = GetOrCreateADIconBorder(icon)
-- Border geometry: BorderSize is the band THICKNESS on its own — Inset no
Expand Down Expand Up @@ -2914,7 +2914,7 @@ function Indicators:ConfigureSquare(frame, config, defaults, auraName, priority)
if borderEnabled == nil then borderEnabled = config.showBorder end
if borderEnabled == nil then borderEnabled = true end
local borderThickness = config.BorderSize or config.borderThickness or 1
local borderInset = config.BorderInset or config.borderInset or 1
local borderInset = config.BorderInset or config.borderInset or 0

local adBorder = GetOrCreateADSquareBorder(sq)
adBorder.dfADIconSize = borderThickness
Expand Down
8 changes: 4 additions & 4 deletions AuraDesigner/Options.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -585,7 +585,7 @@ local function EnsureTypeConfig(auraName, typeKey)
-- aura's icon sub-config; everything else (style, colour,
-- gradient, shadow, offset, blend) reads from TYPE_DEFAULTS
-- via proxy fall-through until the user overrides it.
ShowBorder = true, BorderSize = 1, BorderInset = 1,
ShowBorder = true, BorderSize = 1, BorderInset = 0,
hideSwipe = false,
-- Duration text
showDuration = gd.showDuration ~= false,
Expand Down Expand Up @@ -614,7 +614,7 @@ local function EnsureTypeConfig(auraName, typeKey)
size = gd.iconSize or 24, scale = gd.iconScale or 1.0, alpha = 1.0,
color = {r = 1, g = 1, b = 1, a = 1},
-- Border (canonical keys, Stage 5.2; legacy migrated on load)
ShowBorder = true, BorderSize = 1, BorderInset = 1,
ShowBorder = true, BorderSize = 1, BorderInset = 0,
hideSwipe = false,
-- Duration text
showDuration = gd.showDuration ~= false,
Expand Down Expand Up @@ -748,7 +748,7 @@ local TYPE_DEFAULTS = {
-- see no visual change. Style / Gradient* / Shadow* defaults seed
-- CreateBorderControls' dropdowns and pickers so they read sensible
-- values on first open.
ShowBorder = true, BorderSize = 1, BorderInset = 1,
ShowBorder = true, BorderSize = 1, BorderInset = 0,
BorderColor = {r = 0, g = 0, b = 0, a = 0.8},
BorderStyle = "SOLID",
BorderBlendMode = "BLEND",
Expand Down Expand Up @@ -853,7 +853,7 @@ local TYPE_DEFAULTS = {
-- defaults to opaque black, matching the square's pre-migration
-- hardcoded border so existing users see no change. The rest seed
-- CreateBorderControls' dropdowns / pickers on first open.
ShowBorder = true, BorderSize = 1, BorderInset = 1,
ShowBorder = true, BorderSize = 1, BorderInset = 0,
BorderColor = {r = 0, g = 0, b = 0, a = 1},
BorderStyle = "SOLID",
BorderBlendMode = "BLEND",
Expand Down