From 6b981cc4a9c13936f71dea1bce73cd697429aef6 Mon Sep 17 00:00:00 2001 From: Krathe Date: Mon, 8 Jun 2026 19:31:18 +0100 Subject: [PATCH] Aura Designer: default icon/square border inset to 0 (was 1) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit New icon and square indicators defaulted their Border Inset to 1, so a fresh indicator (and the reset-to-default button) sat 1px inset instead of flush — inconsistent with the bar and border indicator types, and with every main-frame border, which all default to 0. Flipped icon + square inset to 0 across the three places that must agree: - TYPE_DEFAULTS (drives the editor slider + reset) - the EnsureTypeConfig seed (older per-type sub-config shape) - the render fallback in Indicators.lua (config.BorderInset or ... or 1 -> 0) Border Offset X/Y were already 0. Existing indicators that stored an explicit inset are unaffected; only ones relying on the default shift 1 -> 0. --- AuraDesigner/Indicators.lua | 4 ++-- AuraDesigner/Options.lua | 8 ++++---- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/AuraDesigner/Indicators.lua b/AuraDesigner/Indicators.lua index 2dd7c80a..18a12b68 100644 --- a/AuraDesigner/Indicators.lua +++ b/AuraDesigner/Indicators.lua @@ -2101,7 +2101,7 @@ function Indicators:ConfigureIcon(frame, config, defaults, auraName, priority) if borderEnabled == nil then borderEnabled = config.borderEnabled end if borderEnabled == nil then borderEnabled = true end local borderThickness = config.BorderSize or config.borderThickness or 1 - local borderInset = config.BorderInset or config.borderInset or 1 + local borderInset = config.BorderInset or config.borderInset or 0 local adBorder = GetOrCreateADIconBorder(icon) -- Border geometry: BorderSize is the band THICKNESS on its own — Inset no @@ -2914,7 +2914,7 @@ function Indicators:ConfigureSquare(frame, config, defaults, auraName, priority) if borderEnabled == nil then borderEnabled = config.showBorder end if borderEnabled == nil then borderEnabled = true end local borderThickness = config.BorderSize or config.borderThickness or 1 - local borderInset = config.BorderInset or config.borderInset or 1 + local borderInset = config.BorderInset or config.borderInset or 0 local adBorder = GetOrCreateADSquareBorder(sq) adBorder.dfADIconSize = borderThickness diff --git a/AuraDesigner/Options.lua b/AuraDesigner/Options.lua index 8a2c8a63..1a6f8a72 100644 --- a/AuraDesigner/Options.lua +++ b/AuraDesigner/Options.lua @@ -585,7 +585,7 @@ local function EnsureTypeConfig(auraName, typeKey) -- aura's icon sub-config; everything else (style, colour, -- gradient, shadow, offset, blend) reads from TYPE_DEFAULTS -- via proxy fall-through until the user overrides it. - ShowBorder = true, BorderSize = 1, BorderInset = 1, + ShowBorder = true, BorderSize = 1, BorderInset = 0, hideSwipe = false, -- Duration text showDuration = gd.showDuration ~= false, @@ -614,7 +614,7 @@ local function EnsureTypeConfig(auraName, typeKey) size = gd.iconSize or 24, scale = gd.iconScale or 1.0, alpha = 1.0, color = {r = 1, g = 1, b = 1, a = 1}, -- Border (canonical keys, Stage 5.2; legacy migrated on load) - ShowBorder = true, BorderSize = 1, BorderInset = 1, + ShowBorder = true, BorderSize = 1, BorderInset = 0, hideSwipe = false, -- Duration text showDuration = gd.showDuration ~= false, @@ -748,7 +748,7 @@ local TYPE_DEFAULTS = { -- see no visual change. Style / Gradient* / Shadow* defaults seed -- CreateBorderControls' dropdowns and pickers so they read sensible -- values on first open. - ShowBorder = true, BorderSize = 1, BorderInset = 1, + ShowBorder = true, BorderSize = 1, BorderInset = 0, BorderColor = {r = 0, g = 0, b = 0, a = 0.8}, BorderStyle = "SOLID", BorderBlendMode = "BLEND", @@ -853,7 +853,7 @@ local TYPE_DEFAULTS = { -- defaults to opaque black, matching the square's pre-migration -- hardcoded border so existing users see no change. The rest seed -- CreateBorderControls' dropdowns / pickers on first open. - ShowBorder = true, BorderSize = 1, BorderInset = 1, + ShowBorder = true, BorderSize = 1, BorderInset = 0, BorderColor = {r = 0, g = 0, b = 0, a = 1}, BorderStyle = "SOLID", BorderBlendMode = "BLEND",