Aura Designer: default new icon/square border inset to 0#138
Open
Krathe82 wants to merge 1 commit into
Open
Conversation
New icon and square indicators defaulted their Border Inset to 1, so a fresh indicator (and the reset-to-default button) sat 1px inset instead of flush — inconsistent with the bar and border indicator types, and with every main-frame border, which all default to 0. Flipped icon + square inset to 0 across the three places that must agree: - TYPE_DEFAULTS (drives the editor slider + reset) - the EnsureTypeConfig seed (older per-type sub-config shape) - the render fallback in Indicators.lua (config.BorderInset or ... or 1 -> 0) Border Offset X/Y were already 0. Existing indicators that stored an explicit inset are unaffected; only ones relying on the default shift 1 -> 0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
New Aura Designer icon and square indicators defaulted their Border Inset to 1, so a freshly added indicator — and the reset-to-default button — sat 1px inset instead of flush against the icon edge. This was inconsistent with the bar and border indicator types, and with every main-frame border, which all default to 0.
Fix
Set the icon and square inset default to 0 across the three places that have to agree, or the editor and the rendered result disagree:
TYPE_DEFAULTS— drives the editor slider and reset-to-defaultEnsureTypeConfigseed — the older per-type sub-config shapeIndicators.lua(config.BorderInset or … or 1→0)Border Offset X/Y were already 0. Existing indicators that stored an explicit inset are unaffected — only ones relying on the default shift 1 → 0 (a 1px change, and only where the inset was never customised).