Skip to content

Commit 75d6cc9

Browse files
author
Aaron Gustavo Nieves
committed
Simplify issue #130 test docblocks and drop redundant comment
1 parent ff5c838 commit 75d6cc9

3 files changed

Lines changed: 0 additions & 11 deletions

File tree

config/services.php

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,6 @@
6060
'lazy' => true,
6161
]);
6262

63-
// Issue #130 (DI state must survive kernel reboots when the service is persisted).
6463
$services->set(App\Service\ExternalApiStub::class)
6564
->public();
6665
};

src/Service/ExternalApiStub.php

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,10 +6,6 @@
66

77
/**
88
* A stand-in for an external API client whose response can be faked at runtime.
9-
*
10-
* Used by App\Tests\Functional\IssuesCest to reproduce issue #130: a service
11-
* configured on the fly after a request must keep that configuration on the
12-
* next request when it is persisted, even though the kernel reboots in between.
139
*/
1410
final class ExternalApiStub
1511
{

tests/Functional/IssuesCest.php

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -136,12 +136,6 @@ public function ensureMessageObjectsCanBeFetched(FunctionalTester $I)
136136

137137
/**
138138
* @see https://github.com/Codeception/module-symfony/issues/130
139-
*
140-
* A service configured on the fly after a request keeps that configuration
141-
* on the next request when it is persisted, even though the kernel reboots
142-
* between requests (the default rebootable client). This mirrors pure
143-
* Symfony, where DI state is preserved by persisting the service (or
144-
* disabling the reboot) rather than by changing when the kernel reboots.
145139
*/
146140
public function keepConfiguredServiceStateAcrossKernelReboot(FunctionalTester $I)
147141
{

0 commit comments

Comments
 (0)