Add ci.yml (#164)

* Added ci.yml

* Updated ci.yml

* Run virtualenv as a module to fix issue with CI in GitHub Actions

* Run virtualenv as a module to fix issue with CI in GitHub Actions

* Fixed linting error

* Install/upgrade pip setuptools and wheel when running tests

* Fixed linting errors

* Requirements are installed in venv, no need to install them at the sytem level

Author: jasonking3

.github/workflows/ci.yml

@@ -0,0 +1,27 @@
+---
+name: CI
+on:
+  workflow_dispatch:
+  pull_request:
+    branches:
+      - master
+
+jobs:
+  tests:
+    runs-on: ubuntu-latest
+    env:
+      USING_COVERAGE: '3.6,3.8'
+    strategy:
+      matrix:
+        python-version: ["3.6", "3.8"]
+    steps:
+      - uses: actions/checkout@v2
+        with:
+          submodules: recursive
+      - uses: "actions/setup-python@v2"
+        with:
+          python-version: "${{ matrix.python-version }}"
+      - name: Install requirements
+        run: pip install --upgrade pip setuptools wheel
+      - name: Run tests
+        run: "./test.bash"

Makefile

@@ -19,17 +19,17 @@ help: ## Display help
 all: clean venv_python_viptela check test dist ## Setup python-viptela env and run tests
 
 venv: ## Creates the needed virtual environment.
-	test -d $(VENV) || virtualenv -p $(PYTHON_EXE) $(VENV) $(ARGS)
+	test -d $(VENV) || $(PYTHON_EXE) -m venv $(VENV) $(ARGS)
 
 $(VENV): $(VENV_BIN)/activate ## Build virtual environment
 
 $(VENV_BIN)/activate: requirements.txt test-requirements.txt
-	test -d $(VENV) || virtualenv -p $(PYTHON_EXE) $(VENV)
+	test -d $(VENV) || $(PYTHON_EXE) -m venv $(VENV)
 	echo "export TOP_DIR=$(TOPDIR)" >> $(VENV_BIN)/activate
-	. $(VENV_BIN)/activate; pip install -U pip; pip install -r requirements.txt -r test-requirements.txt
+	. $(VENV_BIN)/activate; pip install --upgrade pip setuptools wheel; pip install -r requirements.txt -r test-requirements.txt
 
 deps: venv ## Installs the needed dependencies into the virtual environment.
-	$(VENV_BIN)/pip install -U pip
+	$(VENV_BIN)/pip install --upgrade pip setuptools wheel
 	$(VENV_BIN)/pip install -r requirements.txt -r test-requirements.txt
 
 dev: deps ## Installs python_viptela in develop mode.
@@ -65,7 +65,7 @@ dist: build ## Creates the distribution.
 
 
 test: deps ## Run python-viptela tests
-	. $(VENV_BIN)/activate; pip install -U pip; pip install -r requirements.txt -r test-requirements.txt;tox -r
+	. $(VENV_BIN)/activate; pip install --upgrade pip setuptools wheel; pip install -r requirements.txt -r test-requirements.txt;tox -r
 
 clean: ## Clean python-viptela $(VENV)
 	$(RM) -rf $(VENV)

vmanage/cli/deactivate/central_policy.py

@@ -5,18 +5,18 @@
 
 @click.command('central-policy')
 @click.option('--name', '-n', help="Name of policy to deactivate.")
-@click.option('--id', '-i', help="Id of policy to deactivate.")
+@click.option('--id', '-i', 'policy_id', help="Id of policy to deactivate.")
 @click.pass_obj
-def central_policy(ctx, name, id):
+def central_policy(ctx, name, policy_id):
     """
     deactivate Central Policy
     """
 
     vmanage_central_policy = CentralPolicy(ctx.auth, ctx.host, ctx.port)
     vmanage_utilities = Utilities(ctx.auth, ctx.host, ctx.port)
     central_policy_dict = vmanage_central_policy.get_central_policy_dict(remove_key=True)
-    if id:
-        vmanage_central_policy.deactivate_central_policy(id)
+    if policy_id:
+        vmanage_central_policy.deactivate_central_policy(policy_id)
     elif name:
         if name in central_policy_dict:
             click.echo(f'Deactivating Central Policy {name}')

vmanage/cli/decommission/device.py

@@ -3,15 +3,15 @@
 
 
 @click.command('device')
-@click.argument('device', required=True)
+@click.argument('device_name', required=True)
 @click.pass_obj
-def device(ctx, device):
+def device(ctx, device_name):
     """
     Decommission device
     """
 
     vmanage_device = Device(ctx.auth, ctx.host, ctx.port)
-    status = vmanage_device.get_device_status(device, key='host-name')
+    status = vmanage_device.get_device_status(device_name, key='host-name')
     if 'uuid' in status:
         vmanage_device.put_device_decommission(status['uuid'])
     else:

vmanage/cli/reset/__init__.py

@@ -2,7 +2,6 @@
 from vmanage.cli.reset.interface import interface
 
 
-
 @click.group('reset')
 def reset():
     """