Skip to content

Commit 032054b

Browse files
author
Greg Smith
committed
Fixed build failures due to ESP-IDF VS Code plug-in changes to how sdkconfig files are handled for multi-projects. Nasty issue cost many hours to find. Thanks Espressif for that undocumented trap :(
Also changed Pirate Midi Mini V2 to target 8MB flash instead of 16MB, to work on wider variety of processors (8MB build can work on both 8MB and 16MB versions.)
1 parent 05673df commit 032054b

3 files changed

Lines changed: 27 additions & 27 deletions

File tree

‎TaskList.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,4 +14,4 @@ Similar for Bluetooth Peripheral mode.
1414

1515
## More footswitch inputs
1616
For platforms that have the available IO, add extra footswitches.
17-
17+
Also change MAX_EXTERNAL_EFFECT_FOOTSWITCHES to be more than 8. 12 or even 16?

‎source/esp_idf_project_configuration.json‎

Lines changed: 22 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
"sdkconfig.defaults",
99
"sdkconfig.ws169"
1010
],
11-
"sdkconfigFilePath": "${workspaceFolder}/build_ws169"
11+
"sdkconfigFilePath": "${workspaceFolder}/build_ws169/sdkconfig"
1212
},
1313
"env": {},
1414
"flashBaudRate": "",
@@ -34,7 +34,7 @@
3434
"sdkconfig.defaults",
3535
"sdkconfig.ws169land"
3636
],
37-
"sdkconfigFilePath": "${workspaceFolder}/build_ws169land"
37+
"sdkconfigFilePath": "${workspaceFolder}/build_ws169land/sdkconfig"
3838
},
3939
"env": {},
4040
"flashBaudRate": "",
@@ -60,7 +60,7 @@
6060
"sdkconfig.defaults",
6161
"sdkconfig.ws169t"
6262
],
63-
"sdkconfigFilePath": "${workspaceFolder}/build_ws169t"
63+
"sdkconfigFilePath": "${workspaceFolder}/build_ws169t/sdkconfig"
6464
},
6565
"env": {},
6666
"flashBaudRate": "",
@@ -86,7 +86,7 @@
8686
"sdkconfig.defaults",
8787
"sdkconfig.ws169tland"
8888
],
89-
"sdkconfigFilePath": "${workspaceFolder}/build_ws169tland"
89+
"sdkconfigFilePath": "${workspaceFolder}/build_ws169tland/sdkconfig"
9090
},
9191
"env": {},
9292
"flashBaudRate": "",
@@ -112,7 +112,7 @@
112112
"sdkconfig.defaults",
113113
"sdkconfig.ws43B"
114114
],
115-
"sdkconfigFilePath": "${workspaceFolder}/build_ws43b"
115+
"sdkconfigFilePath": "${workspaceFolder}/build_ws43b/sdkconfig"
116116
},
117117
"env": {},
118118
"flashBaudRate": "",
@@ -138,7 +138,7 @@
138138
"sdkconfig.defaults",
139139
"sdkconfig.ws35b"
140140
],
141-
"sdkconfigFilePath": "${workspaceFolder}/build_ws35b"
141+
"sdkconfigFilePath": "${workspaceFolder}/build_ws35b/sdkconfig"
142142
},
143143
"env": {},
144144
"flashBaudRate": "",
@@ -164,7 +164,7 @@
164164
"sdkconfig.defaults",
165165
"sdkconfig.jc3248w"
166166
],
167-
"sdkconfigFilePath": "${workspaceFolder}/build_jc3248w"
167+
"sdkconfigFilePath": "${workspaceFolder}/build_jc3248w/sdkconfig"
168168
},
169169
"env": {},
170170
"flashBaudRate": "",
@@ -190,7 +190,7 @@
190190
"sdkconfig.defaults",
191191
"sdkconfig.wszero"
192192
],
193-
"sdkconfigFilePath": "${workspaceFolder}/build_wszero"
193+
"sdkconfigFilePath": "${workspaceFolder}/build_wszero/sdkconfig"
194194
},
195195
"env": {},
196196
"flashBaudRate": "",
@@ -216,7 +216,7 @@
216216
"sdkconfig.defaults",
217217
"sdkconfig.devkitc_N8R2"
218218
],
219-
"sdkconfigFilePath": "${workspaceFolder}/build_devkitc_N8R2"
219+
"sdkconfigFilePath": "${workspaceFolder}/build_devkitc_N8R2/sdkconfig"
220220
},
221221
"env": {},
222222
"flashBaudRate": "",
@@ -242,7 +242,7 @@
242242
"sdkconfig.defaults",
243243
"sdkconfig.devkitc_N16R8"
244244
],
245-
"sdkconfigFilePath": "${workspaceFolder}/build_devkitc_N16R8"
245+
"sdkconfigFilePath": "${workspaceFolder}/build_devkitc_N16R8/sdkconfig"
246246
},
247247
"env": {},
248248
"flashBaudRate": "",
@@ -268,7 +268,7 @@
268268
"sdkconfig.defaults",
269269
"sdkconfig.m5atoms3r"
270270
],
271-
"sdkconfigFilePath": "${workspaceFolder}/build_m5atoms3r"
271+
"sdkconfigFilePath": "${workspaceFolder}/build_m5atoms3r/sdkconfig"
272272
},
273273
"env": {},
274274
"flashBaudRate": "",
@@ -294,7 +294,7 @@
294294
"sdkconfig.defaults",
295295
"sdkconfig.lgtdisps3"
296296
],
297-
"sdkconfigFilePath": "${workspaceFolder}/build_lgtdisps3"
297+
"sdkconfigFilePath": "${workspaceFolder}/build_lgtdisps3/sdkconfig"
298298
},
299299
"env": {},
300300
"flashBaudRate": "",
@@ -320,7 +320,7 @@
320320
"sdkconfig.defaults",
321321
"sdkconfig.ws19t"
322322
],
323-
"sdkconfigFilePath": "${workspaceFolder}/build_ws19t"
323+
"sdkconfigFilePath": "${workspaceFolder}/build_ws19t/sdkconfig"
324324
},
325325
"env": {},
326326
"flashBaudRate": "",
@@ -346,7 +346,7 @@
346346
"sdkconfig.defaults",
347347
"sdkconfig.ws43devonly"
348348
],
349-
"sdkconfigFilePath": "${workspaceFolder}/build_ws7_43"
349+
"sdkconfigFilePath": "${workspaceFolder}/build_ws7_43/sdkconfig"
350350
},
351351
"env": {},
352352
"flashBaudRate": "",
@@ -372,7 +372,7 @@
372372
"sdkconfig.defaults",
373373
"sdkconfig.pirate169"
374374
],
375-
"sdkconfigFilePath": "${workspaceFolder}/build_pirate169"
375+
"sdkconfigFilePath": "${workspaceFolder}/build_pirate169/sdkconfig"
376376
},
377377
"env": {},
378378
"flashBaudRate": "",
@@ -398,7 +398,7 @@
398398
"sdkconfig.defaults",
399399
"sdkconfig.pirate169land"
400400
],
401-
"sdkconfigFilePath": "${workspaceFolder}/build_pirate169land"
401+
"sdkconfigFilePath": "${workspaceFolder}/build_pirate169land/sdkconfig"
402402
},
403403
"env": {},
404404
"flashBaudRate": "",
@@ -424,7 +424,7 @@
424424
"sdkconfig.defaults",
425425
"sdkconfig.piratezero"
426426
],
427-
"sdkconfigFilePath": "${workspaceFolder}/build_piratezero"
427+
"sdkconfigFilePath": "${workspaceFolder}/build_piratezero/sdkconfig"
428428
},
429429
"env": {},
430430
"flashBaudRate": "",
@@ -450,7 +450,7 @@
450450
"sdkconfig.defaults",
451451
"sdkconfig.pirate43B"
452452
],
453-
"sdkconfigFilePath": "${workspaceFolder}/build_pirate43B"
453+
"sdkconfigFilePath": "${workspaceFolder}/build_pirate43B/sdkconfig"
454454
},
455455
"env": {},
456456
"flashBaudRate": "",
@@ -476,7 +476,7 @@
476476
"sdkconfig.defaults",
477477
"sdkconfig.pirateminiv2"
478478
],
479-
"sdkconfigFilePath": "${workspaceFolder}/build_pirateminiv2"
479+
"sdkconfigFilePath": "${workspaceFolder}/build_pirateminiv2/sdkconfig"
480480
},
481481
"env": {},
482482
"flashBaudRate": "",
@@ -502,7 +502,7 @@
502502
"sdkconfig.defaults",
503503
"sdkconfig.pirateplusv2"
504504
],
505-
"sdkconfigFilePath": "${workspaceFolder}/build_pirateplusv2"
505+
"sdkconfigFilePath": "${workspaceFolder}/build_pirateplusv2/sdkconfig"
506506
},
507507
"env": {},
508508
"flashBaudRate": "",
@@ -528,7 +528,7 @@
528528
"sdkconfig.defaults",
529529
"sdkconfig.piratepro"
530530
],
531-
"sdkconfigFilePath": "${workspaceFolder}/build_piratepro"
531+
"sdkconfigFilePath": "${workspaceFolder}/build_piratepro/sdkconfig"
532532
},
533533
"env": {},
534534
"flashBaudRate": "",
@@ -554,7 +554,7 @@
554554
"sdkconfig.defaults",
555555
"sdkconfig.piratemax35"
556556
],
557-
"sdkconfigFilePath": "${workspaceFolder}/build_piratemax35"
557+
"sdkconfigFilePath": "${workspaceFolder}/build_piratemax35/sdkconfig"
558558
},
559559
"env": {},
560560
"flashBaudRate": "",

‎source/sdkconfig.pirateminiv2‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,13 @@
11
# Settings for Waveshare 1.69 in Pirate Midi housing, with portrait mode display
22
CONFIG_PARTITION_TABLE_CUSTOM=y
3-
CONFIG_PARTITION_TABLE_CUSTOM_FILENAME="partitions.csv"
4-
CONFIG_PARTITION_TABLE_FILENAME="partitions.csv"
3+
CONFIG_PARTITION_TABLE_CUSTOM_FILENAME="partitions_8MB.csv"
4+
CONFIG_PARTITION_TABLE_FILENAME="partitions_8MB.csv"
55
CONFIG_PARTITION_TABLE_OFFSET=0x8000
66
CONFIG_PARTITION_TABLE_MD5=y
77
CONFIG_ESPTOOLPY_FLASHMODE_QIO=y
88
CONFIG_ESPTOOLPY_FLASHMODE="qio"
9-
CONFIG_ESPTOOLPY_FLASHSIZE_16MB=y
10-
CONFIG_ESPTOOLPY_FLASHSIZE="16MB"
9+
CONFIG_ESPTOOLPY_FLASHSIZE_8MB=y
10+
CONFIG_ESPTOOLPY_FLASHSIZE="8MB"
1111
CONFIG_SPIRAM_MODE_QUAD=y
1212
CONFIG_ESP_DEFAULT_CPU_FREQ_MHZ_160=y
1313
CONFIG_LV_COLOR_16_SWAP=y

0 commit comments

Comments
 (0)