fix: harden framework and template workflows

Merge follow-up fixes with focused local validation. CI install failures were external Electron/ffmpeg artifact fetch failures.

Author: steve8708

.changeset/fix-chat-share-popover-handoff.md

@@ -0,0 +1,5 @@
+---
+"@agent-native/core": patch
+---
+
+Keep the chat share popover mounted outside the overflow menu before opening it.

.changeset/fix-magic-link-signup-attribution.md

@@ -0,0 +1,5 @@
+---
+"@agent-native/core": patch
+---
+
+Preserve signup analytics attribution through Better Auth magic-link verification.

.changeset/hide-workspace-notice-in-workspace.md

@@ -0,0 +1,5 @@
+---
+"@agent-native/core": patch
+---
+
+Hide the workspace destination notice inside workspace apps and present it as an amber warning banner elsewhere.

.changeset/retry-chat-completion-handoff.md

@@ -0,0 +1,5 @@
+---
+"@agent-native/core": patch
+---
+
+Retry transient chat completion persistence failures before handing off background continuations.

packages/code-agents-ui/src/CodeAgentsApp.tsx

@@ -1025,7 +1025,7 @@ export default function CodeAgentsApp({
   }, [host]);
 
   const loadRemoteConnectorStatus = useCallback(async () => {
-    if (!host.getRemoteConnectorStatus) return;
+    if (!isActive || !host.getRemoteConnectorStatus) return;
     try {
       const result = await withHostCallTimeout(
         host.getRemoteConnectorStatus(),
@@ -1036,10 +1036,10 @@ export default function CodeAgentsApp({
     } catch (err) {
       setRemoteConnectorError(err instanceof Error ? err.message : String(err));
     }
-  }, [host]);
+  }, [host, isActive]);
 
   const loadHostMetadata = useCallback(async () => {
-    if (!host.getHostMetadata) return;
+    if (!isActive || !host.getHostMetadata) return;
     try {
       const result = await host.getHostMetadata();
       setHostMetadata(result);
@@ -1049,7 +1049,7 @@ export default function CodeAgentsApp({
         error: err instanceof Error ? err.message : String(err),
       });
     }
-  }, [host]);
+  }, [host, isActive]);
 
   const runComputerSetupAction = useCallback(
     async (action: CodeAgentComputerSetupAction) => {

packages/core/src/agent/production-agent.spec.ts

@@ -51,6 +51,7 @@ import {
   resolveSkillReferenceContent,
   runAgentLoop,
   runAgentLoopWithMainChatInternalContinuations,
+  runCompletionCallbackWithDatabaseRetry,
   shouldChainBackgroundContinuation,
   MAX_IDENTICAL_TOOL_CALLS,
   MAX_SAME_ERROR_ACROSS_ARGUMENTS,
@@ -65,6 +66,24 @@ import type { ActiveRun } from "./run-manager.js";
 import { attachToolSearch, searchToolRegistry } from "./tool-search.js";
 import type { AgentChatEvent, RunEvent } from "./types.js";
 
+describe("runCompletionCallbackWithDatabaseRetry", () => {
+  it("retries transient database failures before giving up the completion boundary", async () => {
+    const callback = vi
+      .fn()
+      .mockRejectedValueOnce({
+        code: "ECHECKOUTTIMEOUT",
+        message: "database checkout timed out",
+      })
+      .mockResolvedValue(undefined);
+    const sleep = vi.fn(async (_ms: number) => {});
+
+    await runCompletionCallbackWithDatabaseRetry(callback, { sleep });
+
+    expect(callback).toHaveBeenCalledTimes(2);
+    expect(sleep).toHaveBeenCalledWith(250);
+  });
+});
+
 function actionEntry(opts: {
   description?: string;
   readOnly?: boolean;

packages/core/src/agent/production-agent.ts

@@ -20,7 +20,7 @@ import {
 } from "../action.js";
 import { readAppState } from "../application-state/script-helpers.js";
 import { isReadOnlyShellCommand } from "../coding-tools/index.js";
-import { getDbExec } from "../db/client.js";
+import { getDbExec, isTransientDatabaseError } from "../db/client.js";
 import { extensionIdFromPathname } from "../extensions/path.js";
 import { preUploadAttachments } from "../file-upload/pre-upload-attachments.js";
 import { isMcpActionResult } from "../mcp-client/app-result.js";
@@ -1188,6 +1188,35 @@ export async function resolveAgentOwnerEmail(
 }
 
 const MAX_RETRIES = 3;
+const COMPLETION_DATABASE_RETRY_DELAYS_MS = [250, 750, 1_500] as const;
+
+/**
+ * A transient database failure in the completion callback used to prevent a
+ * background continuation from ever being handed off. Keep the retry bounded
+ * and database-only so a permanent persistence error still fails loudly.
+ */
+export async function runCompletionCallbackWithDatabaseRetry(
+  callback: () => void | Promise<void>,
+  options?: { sleep?: (ms: number) => Promise<void> },
+): Promise<void> {
+  const sleep =
+    options?.sleep ??
+    ((ms: number) => new Promise<void>((resolve) => setTimeout(resolve, ms)));
+
+  for (let attempt = 0; ; attempt += 1) {
+    try {
+      await callback();
+      return;
+    } catch (error) {
+      const retryDelay = COMPLETION_DATABASE_RETRY_DELAYS_MS[attempt];
+      if (!isTransientDatabaseError(error) || retryDelay === undefined) {
+        throw error;
+      }
+      await sleep(retryDelay);
+    }
+  }
+}
+
 /**
  * Retry budget override for `builder_gateway_error` — the no-detail Builder
  * gateway fallback. Production data shows this code is almost never
@@ -9181,7 +9210,9 @@ export function createProductionAgentHandler(
       options.onRunComplete || trackedProgressRunId
         ? async (run: ActiveRun) => {
             try {
-              await options.onRunComplete?.(run, threadId);
+              await runCompletionCallbackWithDatabaseRetry(() =>
+                options.onRunComplete?.(run, threadId),
+              );
             } catch (err) {
               await completeTrackedProgressRun(run, err);
               throw err;

packages/core/src/agent/run-manager.spec.ts

@@ -2430,6 +2430,42 @@ describe("run manager soft timeout", () => {
     consoleError.mockRestore();
   });
 
+  it("does not advertise a continuation when completion persistence fails before handoff", async () => {
+    const consoleError = vi
+      .spyOn(console, "error")
+      .mockImplementation(() => {});
+    const events: AgentChatEvent[] = [];
+    const run = startRun(
+      "run-completion-boundary-failed",
+      "thread-completion-boundary-failed",
+      async (send) => {
+        send({ type: "text", text: "partial response" });
+        send({ type: "auto_continue", reason: "stream_ended" });
+      },
+      async () => {
+        throw new Error("thread_data write failed");
+      },
+      { softTimeoutMs: 0 },
+    );
+    run.subscribers.add((event) => events.push(event.event));
+
+    await run.finalized;
+
+    expect(events).toContainEqual({
+      type: "error",
+      error: "Agent response could not be saved.",
+    });
+    expect(events).not.toContainEqual({
+      type: "auto_continue",
+      reason: "stream_ended",
+    });
+    expect(setRunTerminalReason).toHaveBeenCalledWith(
+      "run-completion-boundary-failed",
+      "completion_error",
+    );
+    consoleError.mockRestore();
+  });
+
   it("normalizes missing SQL abort reasons to user aborts", async () => {
     vi.mocked(getRunAbortState).mockResolvedValue({ aborted: true });
     let abortReason: unknown;

packages/core/src/agent/run-manager.ts

@@ -675,6 +675,13 @@ function terminalReasonForRun(
   abortReason: string | undefined,
   completionError: unknown,
 ): string {
+  if (
+    finalStatus !== "aborted" &&
+    completionError &&
+    terminalEvent?.type === "auto_continue"
+  ) {
+    return "completion_error";
+  }
   if (terminalEvent?.type === "auto_continue") {
     return terminalEvent.reason || "auto_continue";
   }
@@ -1633,13 +1640,18 @@ export function startRun(
             : terminalEventForCompletion?.event.type === "error" ||
                 terminalEventForCompletion?.event.type === "missing_api_key"
               ? terminalEventForCompletion.event
-              : terminalEventForCompletion?.event.type === "auto_continue"
+              : terminalEventForCompletion?.event.type === "auto_continue" &&
+                  run.continuationTerminalEvent
                 ? // The run was checkpointed at a soft-timeout/loop boundary and
                   // is recoverable: the partial turn is in agent_run_events and
-                  // the continuation run will re-attempt the thread_data save.
+                  // the handed-off continuation run will re-attempt the
+                  // thread_data save.
                   // Even though the completion save failed (finalStatus stays
                   // "errored" for SQL/diagnostics), re-emit the auto_continue so
-                  // the client resumes instead of seeing a dead chat.
+                  // the client resumes instead of seeing a dead chat. A
+                  // pending auto_continue without this handoff marker is not
+                  // recoverable: advertising it makes the client poll a dead
+                  // run until it reports background_run_lost.
                   terminalEventForCompletion.event
                 : {
                     type: "error",

packages/core/src/client/AgentPanel.header.spec.ts

@@ -307,7 +307,7 @@ describe("AgentPanel header overflow actions", () => {
     expect(overflowMenu).toContain(
       "<DropdownMenuShortcut>{widenChatHint}</DropdownMenuShortcut>",
     );
-    expect(overflowMenu.match(/deferAgentPanelOverlayOpen/g)).toHaveLength(2);
+    expect(overflowMenu.match(/deferAgentPanelOverlayOpen/g)).toHaveLength(3);
     expect(overflowMenu).toContain('t("agentPanel.openFullView")');
     expect(overflowMenu).toContain("onSelect={onFullViewRequest}");
     expect(source).toContain("onFullViewRequest={onFullscreenRequest}");
@@ -324,10 +324,12 @@ describe("AgentPanel header overflow actions", () => {
       source.indexOf("const renderPageChatOverlay"),
     );
 
-    expect(overflowMenu).toContain('resourceType="chat_thread"');
-    expect(overflowMenu).toContain('trigger="label-icon"');
-    expect(overflowMenu).toContain('triggerClassName="w-full justify-start"');
+    expect(overflowMenu).toContain("<IconShare3");
+    expect(overflowMenu).toContain("setShareFromMenuOpen(true)");
+    expect(overflowMenu).not.toContain('trigger="label-icon"');
     expect(overflowMenu).toContain("activeTabMessageCount <= 0");
+    expect(source).toContain("defaultOpen={onCollapse && shareFromMenuOpen}");
+    expect(source).toContain("onCollapse ? setShareFromMenuOpen : undefined");
   });
 });