feat: implement default transport in all http clients

Author: ianaya89

CHANGELOG.md

@@ -4,6 +4,10 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [0.4.26](https://github.com/Altinity/terraform-provider-altinitycloud/compare/v0.4.25...v0.4.26)
+### Changed
+- Implement default transport configuration for all SDK HTTP client [1de625f](https://github.com/Altinity/terraform-provider-altinitycloud/commit/1de625f).
+
 ## [0.4.25](https://github.com/Altinity/terraform-provider-altinitycloud/compare/v0.4.24...v0.4.25)
 ### Changed
 - Bump github.com/hashicorp/terraform-plugin-log to `0.10.0` [#192](https://github.com/Altinity/terraform-provider-altinitycloud/pull/192).

internal/provider/provider.go

@@ -6,7 +6,6 @@ import (
 	"crypto/x509"
 	"errors"
 	"fmt"
-	"net"
 	"net/http"
 	"os"
 	"runtime"
@@ -129,19 +128,25 @@ func (p *altinityCloudProvider) Configure(ctx context.Context, req provider.Conf
 		}
 	}
 
+	defaultTransport, ok := http.DefaultTransport.(*http.Transport)
+	if !ok {
+		resp.Diagnostics.AddError(
+			"Failed to configure HTTP client",
+			"Unable to get default HTTP transport",
+		)
+		return
+	}
+
 	client := client.NewClient(
 		&http.Client{
 			Transport: &http.Transport{
-				Proxy: http.ProxyFromEnvironment,
-				DialContext: (&net.Dialer{
-					Timeout:   30 * time.Second,
-					KeepAlive: 30 * time.Second,
-				}).DialContext,
-				ForceAttemptHTTP2:     true,
-				MaxIdleConns:          16,
-				IdleConnTimeout:       45 * time.Second,
-				TLSHandshakeTimeout:   10 * time.Second,
-				ExpectContinueTimeout: 1 * time.Second,
+				Proxy:                 defaultTransport.Proxy,
+				DialContext:           defaultTransport.DialContext,
+				ForceAttemptHTTP2:     defaultTransport.ForceAttemptHTTP2,
+				MaxIdleConns:          defaultTransport.MaxIdleConns,
+				IdleConnTimeout:       defaultTransport.IdleConnTimeout,
+				TLSHandshakeTimeout:   defaultTransport.TLSHandshakeTimeout,
+				ExpectContinueTimeout: defaultTransport.ExpectContinueTimeout,
 				TLSClientConfig: &tls.Config{
 					RootCAs: rootCAs,
 				},

internal/sdk/auth/auth.go

@@ -53,8 +53,20 @@ func (a *Auth) GenerateCertificate(ctx context.Context, envName string) (string,
 }
 
 func (a *Auth) signCertificateRequest(ctx context.Context, csrPEM []byte) ([]byte, error) {
+	defaultTransport, ok := http.DefaultTransport.(*http.Transport)
+	if !ok {
+		return nil, fmt.Errorf("failed to get default HTTP transport")
+	}
+
 	httpClient := &http.Client{
 		Transport: &http.Transport{
+			Proxy:                 defaultTransport.Proxy,
+			DialContext:           defaultTransport.DialContext,
+			ForceAttemptHTTP2:     defaultTransport.ForceAttemptHTTP2,
+			MaxIdleConns:          defaultTransport.MaxIdleConns,
+			IdleConnTimeout:       defaultTransport.IdleConnTimeout,
+			TLSHandshakeTimeout:   defaultTransport.TLSHandshakeTimeout,
+			ExpectContinueTimeout: defaultTransport.ExpectContinueTimeout,
 			TLSClientConfig: &tls.Config{
 				RootCAs: a.RootCAs,
 			},

internal/sdk/crypto/crypto.go

@@ -83,8 +83,20 @@ func (c *Crypto) Decrypt(pkPem string, value string) (string, error) {
 }
 
 func (c *Crypto) fetchPublicKey(ctx context.Context, tlsCert tls.Certificate) (pem []byte, err error) {
+	defaultTransport, ok := http.DefaultTransport.(*http.Transport)
+	if !ok {
+		return nil, fmt.Errorf("failed to get default HTTP transport")
+	}
+
 	httpClient := &http.Client{
 		Transport: &http.Transport{
+			Proxy:                 defaultTransport.Proxy,
+			DialContext:           defaultTransport.DialContext,
+			ForceAttemptHTTP2:     defaultTransport.ForceAttemptHTTP2,
+			MaxIdleConns:          defaultTransport.MaxIdleConns,
+			IdleConnTimeout:       defaultTransport.IdleConnTimeout,
+			TLSHandshakeTimeout:   defaultTransport.TLSHandshakeTimeout,
+			ExpectContinueTimeout: defaultTransport.ExpectContinueTimeout,
 			TLSClientConfig: &tls.Config{
 				RootCAs: c.RootCAs,
 				Certificates: []tls.Certificate{