Tapable.plugin is deprecated

[tlaak]

WebpackShellPlugin is causing a warning with Webpack 4. When I run node --trace-deprecation ./node_modules/.bin/webpackI get this:

(node:83992) DeprecationWarning: Tapable.plugin is deprecated. Use new API on `.hooks` instead
    at WebpackShellPlugin.apply (/projectDir/node_modules/webpack-shell-plugin/lib/index.js:236:16)

I would have submitted a PR, but looks like I can't build the project without errors and it doesn't pass linting. In addition, there hasn't been much activity in a year so in case someone else is encountering the same issue, you can fix it locally.

Just replace all compiler.plugin('hookName', ...) calls with compiler.hook.[hookName].tap or compiler.hook.[hookName].tapAsync if it's asynchronous and gets a callback as an argument.

[thetutlage]

Yes, it happens coz of changes in Webpack 4 plugin API.

[iSynth]

How to fix?

[tlaak]

This should work, in src/webpack-shell-plugin.js

[iSynth]

@tlaak

Thanks!

[tlaak]

@iSynth you can also try patching it with https://github.com/ds300/patch-package/ while waiting for a proper fix

[karneaud]

did anyone fix this?

[jchook]

I fixed this by ditching the plugin and using the new Webpack Plugin API directly from my webpack config:

const exec = require('child_process').exec;
module.exports = {
  
  // ... other config here ...
  
  plugins: [
  
    // ... other plugins here ...
  
    {
      apply: (compiler) => {
        compiler.hooks.afterEmit.tap('AfterEmitPlugin', (compilation) => {
          exec('<path to your post-build script here>', (err, stdout, stderr) => {
            if (stdout) process.stdout.write(stdout);
            if (stderr) process.stderr.write(stderr);
          });
        });
      }
    }
  ]
};

[mindplay-dk]

@tlaak if you fixed it, why not submit a PR? :-)

[tlaak]

I was planning to do it, but when I forked the repo, I noticed that it doesn't build without errors etc.

If this repo hasn't had any activity during the last year, I'd say the chances of it getting approved are quite slim.

[mindplay-dk]

@tlaak alright, thanks for the reply - went with the solution by @jchook which worked 👍