refactor: fix eslint

Author: northword

eslint.config.js

@@ -3,7 +3,11 @@ import antfu from "@antfu/eslint-config";
 
 export default antfu({
   javascript: true,
-  typescript: true,
+  typescript: {
+    overrides: {
+      "e18e/prefer-static-regex": "off",
+    },
+  },
   stylistic: {
     semi: true,
     quotes: "double",

src/core/builder/fluent.ts

@@ -255,6 +255,6 @@ export function generateFluentDts(messages: string[]) {
 /* eslint-disable */
 // @ts-nocheck
 export type FluentMessageId =
-${Array.from(messages).sort().map(id => `  | '${id}'`).join("\n")};
+${messages.toSorted().map(id => `  | '${id}'`).join("\n")};
 `;
 }

src/core/builder/index.ts

@@ -46,7 +46,7 @@ export default class Build extends Base {
     }
 
     await this.ctx.hooks.callHook("build:done", this.ctx);
-    this.logger.success(`Build finished in ${(new Date().getTime() - t.getTime()) / 1000} s.`);
+    this.logger.success(`Build finished in ${(Date.now() - t.getTime()) / 1000} s.`);
   }
 
   private async prepareAssets() {

src/core/builder/replace.ts

@@ -8,6 +8,7 @@ export function replace(contents: string, from: RegExp | RegExp[], to: string |
   const froms = Array.isArray(from) ? from : [from];
   const tos = Array.isArray(to)
     ? to
+    // eslint-disable-next-line e18e/prefer-array-fill -- `Array.from({length: froms.length}).fill(to)` breaks type infer
     : Array.from({ length: froms.length }, () => to);
 
   if (froms.length !== tos.length) {
@@ -51,8 +52,8 @@ export default async function replaceDefine(dist: string, define: BuildConfig["d
     //   `${dist}/addon/**/*.css`,
     //   `${dist}/addon/**/*.json`,
     // ],
-    from: Array.from(replaceMap.keys()),
-    to: Array.from(replaceMap.values()),
+    from: [...replaceMap.keys()],
+    to: [...replaceMap.values()],
     // isGlob: false,
   });
 }

src/core/releaser/index.ts

@@ -64,7 +64,7 @@ export default class Release extends Base {
 
     await this.ctx.hooks.callHook("release:done", this.ctx);
     this.logger.success(
-      `Done in ${(new Date().getTime() - t.getTime()) / 1000} s.`,
+      `Done in ${(Date.now() - t.getTime()) / 1000} s.`,
     );
   }
 

src/core/tester/test-bundler.ts

@@ -172,5 +172,5 @@ export function findImpactedTests(changedFilePath: string, buildMetadata: BuildR
       impactedTestFiles.add(testFilePath);
     }
   }
-  return Array.from(impactedTestFiles);
+  return [...impactedTestFiles];
 }

src/utils/prefs-manager.ts

@@ -120,7 +120,8 @@ export class PrefsManager {
       return false;
     else if (!Number.isNaN(Number(value)))
       return Number(value);
-    else if (value.match(/^["'](.*)["']$/))
+    // eslint-disable-next-line regexp/no-unused-capturing-group
+    else if (/^["'](.*)["']$/.test(value))
       return value.replace(/^["'](.*)["']$/, "$1");
     else
       return value;

src/utils/string.ts

@@ -34,7 +34,7 @@ export function toArray<T>(value: T | T[]): T[] {
  * @see https://github.com/sodiray/radash/blob/069b26cdd7d62e6ac16a0ad3baa1c9abcca420bc/src/string.ts#L111-L126
  */
 export function template(str: string, data: Record<string, any>, regex: RegExp = /\{\{(.+?)\}\}/g): string {
-  return Array.from(str.matchAll(regex)).reduce((acc, match) => {
+  return [...str.matchAll(regex)].reduce((acc, match) => {
     return acc.replace(match[0], data[match[1]]);
   }, str);
 }