fix: regress logger

Author: northword

packages/scaffold/src/core/builder/fluent.ts

@@ -172,17 +172,25 @@ export class MessageManager {
     }
   }
 
-  // Validate that all HTML messages exist in all FTL locales
   validateMessages() {
+    // Check miss 1: Cross check in diff locale - seems no need
+    // messagesByLocale.forEach((messageInThisLang, lang) => {
+    //   // Needs Nodejs 22
+    //   const diff = allMessages.difference(messageInThisLang);
+    //   if (diff.size)
+    //     this.logger.warn(`FTL messages '${Array.from(diff).join(", ")}' don't exist the locale '${lang}'`);
+    // });
+
+    // Check miss 2: Check ids in HTML but not in ftl
     this.htmlMessages.forEach((msg) => {
       if (this.ignores.includes(msg))
         return;
 
-      this.ftlMessages.forEach((messages, locale) => {
-        if (!messages.has(msg)) {
-          logger.warn(`Missing message: ${styleText.blue(msg)} in locale: ${locale}`);
-        }
-      });
+      const missingLocales = [...this.ftlMessages.entries()]
+        .filter(([_, messages]) => !messages.has(msg))
+        .map(([locale]) => locale);
+      if (missingLocales.length > 0)
+        logger.warn(`I10N id ${styleText.blue(msg)} missing in locale: ${missingLocales.join(", ")}`);
     });
   }
 
@@ -223,7 +231,7 @@ export function processHTMLFile(
     }
 
     if (!allMessages.has(id)) {
-      logger.warn(`Missing FTL: ${styleText.blue(id)} in ${styleText.gray(filePath)}`);
+      logger.warn(`I10N id ${styleText.blue(id)} in path ${styleText.gray(filePath)} does not exist in any locale, skip renaming it.`);
       return match;
     }
 

packages/scaffold/test/unit/fluent.test.ts

@@ -80,7 +80,7 @@ describe("processHTMLFile", () => {
 
     expect(processedContent).toBe("<div data-l10n-id=\"missingMessage\"></div>");
     expect(foundMessages.includes("missingMessage")).toBe(true);
-    expect(logger.warn).toHaveBeenCalledWith(expect.stringContaining("Missing FTL:"));
+    expect(logger.warn).toHaveBeenCalledWith(expect.stringContaining("does not exist in any locale, skip renaming it"));
   });
 
   it("should not modify the content if no matching messages are found", () => {
@@ -135,7 +135,7 @@ describe("message-manager", () => {
     messageManager.validateMessages();
 
     expect(logger.warn).toHaveBeenCalledWith(
-      expect.stringMatching(/Missing message: .*goodbye.* in locale: fr/),
+      expect.stringMatching(/I10N id .*goodbye.* missing in locale: fr/),
     );
   });