Skip to content

Commit 74879cf

Browse files
committed
fix(builder): do not fill strict_max_version in update.json
1 parent 3f1bd9f commit 74879cf

4 files changed

Lines changed: 7 additions & 27 deletions

File tree

packages/scaffold/src/config.ts

Lines changed: 4 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -110,26 +110,12 @@ const defaultConfig = {
110110
enable: true,
111111
template: {
112112
manifest_version: 2,
113-
name: "__addonName__",
114-
version: "__buildVersion__",
115-
description: "__description__",
116-
homepage_url: "__homepage__",
117-
author: "__author__",
118-
icons: {
119-
48: "content/icons/[email protected]",
120-
96: "content/icons/favicon.png",
121-
},
113+
name: "",
114+
version: "",
122115
applications: {
123116
zotero: {
124-
id: "__addonID__",
125-
update_url: "__updateURL__",
126-
strict_min_version: "6.999",
127-
strict_max_version: "7.0.*",
128-
},
129-
gecko: {
130-
id: "__addonID__",
131-
update_url: "__updateURL__",
132-
strict_min_version: "102",
117+
id: "",
118+
update_url: "",
133119
},
134120
},
135121
},

packages/scaffold/src/core/builder.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -129,7 +129,6 @@ export default class Build extends Base {
129129
...(version && { version }),
130130
manifest_version: 2,
131131
applications: {
132-
// @ts-expect-error 此处不包含版本限制
133132
zotero: {
134133
id,
135134
update_url: updateURL,
@@ -332,7 +331,7 @@ export default class Build extends Base {
332331
}),
333332
applications: {
334333
zotero: {
335-
strict_min_version: min,
334+
...(min && { strict_min_version: min }),
336335
...(max && { strict_max_version: max }),
337336
},
338337
},

packages/scaffold/src/types/manifest.ts

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -11,13 +11,8 @@ export interface Manifest {
1111
zotero: {
1212
id: string;
1313
update_url: string;
14-
strict_min_version: string;
14+
strict_min_version?: string;
1515
strict_max_version?: string;
1616
};
17-
gecko: {
18-
id: string;
19-
update_url: string;
20-
strict_min_version: string;
21-
};
2217
};
2318
}

packages/scaffold/src/types/update-json.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ export interface UpdateJSON {
1717
update_hash?: string;
1818
applications: {
1919
zotero: {
20-
strict_min_version: string;
20+
strict_min_version?: string;
2121
strict_max_version?: string;
2222
};
2323
[application: string]: {

0 commit comments

Comments
 (0)