fix(test-runner): unresolved placeholders

northword · northword · commit 2251a2e70171 · 2026-03-20T17:54:09.000+08:00
fix: #167
diff --git a/src/core/tester/test-bundler-template/index.ts b/src/core/tester/test-bundler-template/index.ts
@@ -6,7 +6,7 @@ import mochaSetupRaw from "./raw/mocha-setup.js?raw";
 
 export function generateManifest(): Record<string, unknown> {
   const manifestStr = manifestRaw
-    .replace("__TESTER_PLUGIN_ID__", TESTER_PLUGIN_ID);
+    .replaceAll("__TESTER_PLUGIN_ID__", TESTER_PLUGIN_ID);
 
   return JSON.parse(manifestStr);
 }
@@ -17,10 +17,10 @@ export function generateBootstrap(options: {
   waitForPlugin: string;
 }): string {
   return bootstrapRaw
-    .replace("__PORT__", String(options.port))
-    .replace("__STARTUP_DELAY__", String(options.startupDelay || 1000))
-    .replace("__WAIT_FOR_PLUGIN__", options.waitForPlugin)
-    .replace("__TESTER_PLUGIN_REF__", TESTER_PLUGIN_REF);
+    .replaceAll("__PORT__", String(options.port))
+    .replaceAll("__STARTUP_DELAY__", String(options.startupDelay || 1000))
+    .replaceAll("__WAIT_FOR_PLUGIN__", options.waitForPlugin)
+    .replaceAll("__TESTER_PLUGIN_REF__", TESTER_PLUGIN_REF);
 }
 
 export function generateHtml(
@@ -29,7 +29,9 @@ export function generateHtml(
 ): string {
   const tests = testFiles.map(f => `<script src="${f}"></script>`).join("\n    ");
 
-  return htmlRaw.replace("__TEST_FILES__", tests).replace("___SETUP_CODE___", setupCode);
+  return htmlRaw
+    .replaceAll("__TEST_FILES__", tests)
+    .replaceAll("__SETUP_CODE__", setupCode);
 }
 
 export function generateMochaSetup(options: {
@@ -39,8 +41,8 @@ export function generateMochaSetup(options: {
   exitOnFinish: boolean;
 }): string {
   return mochaSetupRaw
-    .replace("__TIMEOUT__", String(options.timeout || 10000))
-    .replace("__PORT__", String(options.port))
-    .replace("__ABORT_ON_FAIL__", String(options.abortOnFail))
-    .replace("__EXIT_ON_FINISH__", String(options.exitOnFinish ? "true" : "false"));
+    .replaceAll("__TIMEOUT__", String(options.timeout || 10000))
+    .replaceAll("__PORT__", String(options.port))
+    .replaceAll("__ABORT_ON_FAIL__", String(options.abortOnFail))
+    .replaceAll("__EXIT_ON_FINISH__", String(options.exitOnFinish ? "true" : "false"));
 }
diff --git a/src/core/tester/test-bundler-template/raw/bootstrap.js b/src/core/tester/test-bundler-template/raw/bootstrap.js
@@ -55,7 +55,7 @@ async function launchTests() {
   // Delay to allow plugin to fully load before opening the test page
   await Zotero.Promise.delay(__STARTUP_DELAY__);
 
-  const waitForPlugin = "${WAIT_FOR_PLUGIN}";
+  const waitForPlugin = "__WAIT_FOR_PLUGIN__";
 
   if (waitForPlugin) {
     // Wait for a plugin to be installed
@@ -72,7 +72,7 @@ async function launchTests() {
 
   Services.ww.openWindow(
     null,
-    "chrome://${TESTER_PLUGIN_REF}/content/index.xhtml",
+    "chrome://__TESTER_PLUGIN_REF__/content/index.xhtml",
     "Zotero Plugin Scaffold Test Runnner",
     "chrome,centerscreen,resizable=yes",
     {}
diff --git a/src/core/tester/test-bundler-template/raw/index.html b/src/core/tester/test-bundler-template/raw/index.html
@@ -1,5 +1,4 @@
 <!-- Generated by zotero-plugin-scaffold -->
-<!doctype html>
 <html lang="en" xmlns="http://www.w3.org/1999/xhtml">
   <head>
     <meta charset="UTF-8" />

Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,4 @@`
`1`	`1`	`<!-- Generated by zotero-plugin-scaffold -->`
`2`		`-<!doctype html>`
`3`	`2`	`<html lang="en" xmlns="http://www.w3.org/1999/xhtml">`
`4`	`3`	`<head>`
`5`	`4`	`<meta charset="UTF-8" />`