Skip to content

Commit a8f82a1

Browse files
committed
Fix misc issues
1 parent 9cd1bd0 commit a8f82a1

2 files changed

Lines changed: 3 additions & 4 deletions

File tree

.github/actions/universal-package/action.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ runs:
4141
# We also manually depend on GNU libiconv as Apple iconv is broken since macOS 14. This is necessary as MacVim
4242
# itself it built against it and we need both to match.
4343
sed -i.bak '/^[[:blank:]]*def install$/i\'$'\n depends_on "libiconv"\n' ${formula}.rb
44-
sed -i.bak '/^[[:blank:]]*def install$/a\'$'\n ENV["CFLAGS"] += " -I'$(brew --prefix)$'/opt/libiconv/lib"\n' ${formula}.rb
44+
sed -i.bak '/^[[:blank:]]*def install$/a\'$'\n ENV["CFLAGS"] += " -I'$(brew --prefix)$'/opt/libiconv/include"\n' ${formula}.rb
4545
sed -i.bak '/^[[:blank:]]*def install$/a\'$'\n ENV["LDFLAGS"] += " -L'$(brew --prefix)$'/opt/libiconv/lib"\n' ${formula}.rb
4646
fi
4747

.github/workflows/macvim-buildtest.yaml

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,7 @@ jobs:
8989
xcode-select -p
9090
xcodebuild -version
9191
92-
# Set up, install, and cache libiconv library to work around broken Apple iconv since macOS 14.
92+
# Set up, install, and cache GNU libiconv library to work around broken Apple iconv since macOS 14.
9393

9494
- name: Set up libiconv
9595
if: inputs.publish
@@ -121,7 +121,6 @@ jobs:
121121

122122
- name: Install packages
123123
run: |
124-
# GNU iconv is installed to work around broken Apple iconv
125124
brew install --quiet libtool
126125
127126
- name: Install packages for testing
@@ -233,7 +232,7 @@ jobs:
233232
sed -i.bak -f ci/config.mk.optimized.sed src/auto/config.mk
234233
fi
235234
236-
# Use Homebrew libiconv since Apple iconv is broken since macOS 14
235+
# Use Homebrew GNU libiconv since Apple iconv has been broken since macOS 14
237236
sed -i.bak -f ci/config.mk.brew-libiconv.sed src/auto/config.mk
238237
239238
- name: Modify configure result

0 commit comments

Comments
 (0)