fix(sea): address copilot review — mixed-major guard, emitWarning leak, test cleanup

- lib/sea.ts: add assertSingleTargetMajor() and call from both sea() and
  seaEnhanced(). SEA prep blobs are Node-major specific, so mixing majors
  in one run (e.g. -t node22-linux-x64,node24-linux-x64) silently produced
  broken executables. Reject up front instead.
- prelude/sea-bootstrap.js: restore the original process.emitWarning as
  soon as the SEA loader warning is suppressed, so user code does not
  observe a permanently wrapped emitWarning.
- test/utils.js: filesAfter() gains { tolerateWindowsEbusy } option that
  only swallows EBUSY on win32 during cleanup.
- test/test-85..92: drop copy-pasted try/catch noop around filesAfter and
  use the new option. test-91/92 also switch from inlined spawn+CRLF
  logic to the shared assertSeaOutput helper.

Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>

Author: robertsLando

lib/sea.ts

@@ -441,6 +441,31 @@ function resolveMinTargetMajor(
   );
 }
 
+/**
+ * SEA prep blobs are Node-major specific (e.g. Node 25.8 added an
+ * exec_argv_extension header field), so a single blob cannot be safely
+ * baked into binaries of different Node majors. Reject mixed-major target
+ * lists up front instead of silently producing broken executables.
+ */
+function assertSingleTargetMajor(
+  targets: (NodeTarget & Partial<Target>)[],
+): void {
+  const hostMajor = parseInt(process.version.slice(1), 10);
+  const majors = new Set(
+    targets.map((t) => {
+      const v = parseInt(t.nodeRange.replace('node', ''), 10);
+      return Number.isNaN(v) ? hostMajor : v;
+    }),
+  );
+  if (majors.size > 1) {
+    throw wasReported(
+      `SEA mode cannot mix Node.js majors in a single run ` +
+        `(got ${[...majors].sort((a, b) => a - b).join(', ')}). ` +
+        `Run pkg once per Node major.`,
+    );
+  }
+}
+
 /**
  * Pick the node binary used to generate the SEA prep blob.
  *
@@ -460,8 +485,9 @@ function resolveMinTargetMajor(
  *     cross-major + cross-platform build will fail at spawn time — pkg
  *     has no way to produce a host-platform binary of the target major.
  *
- * All targets share a single node major (validated in bin.ts), so
- * inspecting only nodePaths[0] is sufficient.
+ * All targets share a single node major (enforced by
+ * {@link assertSingleTargetMajor}), so inspecting only nodePaths[0] is
+ * sufficient.
  */
 function pickBlobGeneratorBinary(
   minTargetMajor: number,
@@ -516,6 +542,8 @@ export async function seaEnhanced(
     );
   }
 
+  assertSingleTargetMajor(opts.targets);
+
   const minTargetMajor = resolveMinTargetMajor(opts.targets);
   if (minTargetMajor < 22) {
     throw wasReported(
@@ -632,6 +660,7 @@ export async function seaEnhanced(
 /** Create NodeJS executable using sea */
 export default async function sea(entryPoint: string, opts: SeaOptions) {
   assertHostSeaNodeVersion();
+  assertSingleTargetMajor(opts.targets);
 
   entryPoint = resolve(process.cwd(), entryPoint);
 

prelude/sea-bootstrap.js

@@ -38,13 +38,15 @@ if (manifest.entryIsESM) {
   var url = require('url');
 
   // Suppress the ExperimentalWarning emitted once on first use of
-  // vm.USE_MAIN_CONTEXT_DEFAULT_LOADER. We chain it onto the original
-  // emitWarning so every other warning still reaches listeners.
+  // vm.USE_MAIN_CONTEXT_DEFAULT_LOADER. Restore the original emitWarning
+  // as soon as we swallow it so user code doesn't observe a wrapped
+  // emitWarning for the rest of the process lifetime.
   var origEmitWarning = process.emitWarning;
   process.emitWarning = function (warning) {
     var msg =
       typeof warning === 'string' ? warning : warning && warning.message;
     if (msg && msg.indexOf('vm.USE_MAIN_CONTEXT_DEFAULT_LOADER') !== -1) {
+      process.emitWarning = origEmitWarning;
       return;
     }
     return origEmitWarning.apply(this, arguments);

test/test-85-sea-enhanced/main.js

@@ -34,8 +34,4 @@ const expected =
 
 utils.assertSeaOutput('test-85-sea-enhanced', expected);
 
-try {
-  utils.filesAfter(before, newcomers);
-} catch (_error) {
-  // noop — Windows EBUSY workaround
-}
+utils.filesAfter(before, newcomers, { tolerateWindowsEbusy: true });

test/test-86-sea-assets/main.js

@@ -29,8 +29,4 @@ utils.assertSeaOutput(
   'config:test-value\ndata:hello world\n',
 );
 
-try {
-  utils.filesAfter(before, newcomers);
-} catch (_error) {
-  // noop — Windows EBUSY workaround
-}
+utils.filesAfter(before, newcomers, { tolerateWindowsEbusy: true });

test/test-87-sea-esm/main.js

@@ -28,8 +28,4 @@ utils.pkg.sync([input, '--sea'], { stdio: 'inherit' });
 
 utils.assertSeaOutput('test-87-sea-esm', 'add:5\ngreeting:hello world\n');
 
-try {
-  utils.filesAfter(before, newcomers);
-} catch (_error) {
-  // noop — Windows EBUSY workaround
-}
+utils.filesAfter(before, newcomers, { tolerateWindowsEbusy: true });

test/test-89-sea-fs-ops/main.js

@@ -38,8 +38,4 @@ const expectedOutput =
 
 utils.assertSeaOutput('test-89-sea-fs-ops', expectedOutput);
 
-try {
-  utils.filesAfter(before, newcomers);
-} catch (_error) {
-  // noop — Windows EBUSY workaround
-}
+utils.filesAfter(before, newcomers, { tolerateWindowsEbusy: true });

test/test-90-sea-worker-threads/main.js

@@ -32,8 +32,4 @@ const expected =
 
 utils.assertSeaOutput('test-90-sea-worker-threads', expected);
 
-try {
-  utils.filesAfter(before, newcomers);
-} catch (_error) {
-  // noop — Windows EBUSY workaround
-}
+utils.filesAfter(before, newcomers, { tolerateWindowsEbusy: true });

test/test-91-sea-esm-entry/main.js

@@ -24,19 +24,6 @@ const before = utils.filesBefore(newcomers);
 
 utils.pkg.sync([input, '--sea'], { stdio: 'inherit' });
 
-const expected = 'add:5\ngreet:hello world\n';
-
-const platformSuffix = { linux: 'linux', darwin: 'macos', win32: 'win.exe' };
-const suffix = platformSuffix[process.platform];
-if (suffix) {
-  const actual = utils.spawn
-    .sync(`./test-91-sea-esm-entry-${suffix}`, [])
-    .replace(/\r\n/g, '\n');
-  assert.equal(actual, expected, 'Output matches');
-}
+utils.assertSeaOutput('test-91-sea-esm-entry', 'add:5\ngreet:hello world\n');
 
-try {
-  utils.filesAfter(before, newcomers);
-} catch (_error) {
-  // noop
-}
+utils.filesAfter(before, newcomers, { tolerateWindowsEbusy: true });

test/test-92-sea-tla/main.js

@@ -24,19 +24,6 @@ const before = utils.filesBefore(newcomers);
 
 utils.pkg.sync([input, '--sea'], { stdio: 'inherit' });
 
-const expected = 'before-tla\nafter-tla:42\n';
-
-const platformSuffix = { linux: 'linux', darwin: 'macos', win32: 'win.exe' };
-const suffix = platformSuffix[process.platform];
-if (suffix) {
-  const actual = utils.spawn
-    .sync(`./test-92-sea-tla-${suffix}`, [])
-    .replace(/\r\n/g, '\n');
-  assert.equal(actual, expected, 'Output matches');
-}
+utils.assertSeaOutput('test-92-sea-tla', 'before-tla\nafter-tla:42\n');
 
-try {
-  utils.filesAfter(before, newcomers);
-} catch (_error) {
-  // noop
-}
+utils.filesAfter(before, newcomers, { tolerateWindowsEbusy: true });

test/utils.js

@@ -209,8 +209,12 @@ module.exports.filesBefore = function (n) {
  * after the test are the same as before the test.
  * @param {string[]} before Files that should exist
  * @param {string[]} newComers New files produced by test that should be removed
+ * @param {{ tolerateWindowsEbusy?: boolean }} [options] When
+ *   `tolerateWindowsEbusy` is true, EBUSY failures on win32 during cleanup
+ *   are swallowed. SEA tests need this because Windows briefly keeps a
+ *   handle on an executable after the spawned process has exited.
  */
-module.exports.filesAfter = function (before, newComers) {
+module.exports.filesAfter = function (before, newComers, options) {
   // actual files in the directory
   const a = globSync('**/*').sort();
 
@@ -241,8 +245,21 @@ module.exports.filesAfter = function (before, newComers) {
   }
 
   // remove the files that should not exist
+  const tolerateWindowsEbusy = options && options.tolerateWindowsEbusy === true;
   for (const ni of newComers) {
-    module.exports.vacuum.sync(ni);
+    try {
+      module.exports.vacuum.sync(ni);
+    } catch (error) {
+      if (
+        tolerateWindowsEbusy &&
+        process.platform === 'win32' &&
+        error &&
+        error.code === 'EBUSY'
+      ) {
+        continue;
+      }
+      throw error;
+    }
   }
 };