Skip to content

Commit 41840a5

Browse files
HoratiuVulturgregkh
authored andcommitted
net: phy: micrel: Fix lan8814_config_init
commit bf91f4bc9c1dfba75e457e6a5f11e3cda658729a upstream. The blamed commit introduced the function lanphy_modify_page_reg which as name suggests it, it modifies the registers. In the same commit we have started to use this function inside the drivers. The problem is that in the function lan8814_config_init we passed the wrong page number when disabling the aneg towards host side. We passed extended page number 4(LAN8814_PAGE_COMMON_REGS) instead of extended page 5(LAN8814_PAGE_PORT_REGS) Fixes: a0de636ed7a264 ("net: phy: micrel: Introduce lanphy_modify_page_reg") Signed-off-by: Horatiu Vultur <[email protected]> Reviewed-by: Simon Horman <[email protected]> Link: https://patch.msgid.link/[email protected] Signed-off-by: Jakub Kicinski <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
1 parent ea79363 commit 41840a5

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

drivers/net/phy/micrel.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4328,7 +4328,7 @@ static int lan8814_config_init(struct phy_device *phydev)
43284328
struct kszphy_priv *lan8814 = phydev->priv;
43294329

43304330
/* Disable ANEG with QSGMII PCS Host side */
4331-
lanphy_modify_page_reg(phydev, LAN8814_PAGE_COMMON_REGS,
4331+
lanphy_modify_page_reg(phydev, LAN8814_PAGE_PORT_REGS,
43324332
LAN8814_QSGMII_PCS1G_ANEG_CONFIG,
43334333
LAN8814_QSGMII_PCS1G_ANEG_CONFIG_ANEG_ENA,
43344334
0);

0 commit comments

Comments
 (0)