Skip to content

Commit 1b60457

Browse files
pldrcgregkh
authored andcommitted
drm/amdgpu: Fix unintended error log in VCN5_0_0
commit 46b0e6b9d749cfa891e6969d6565be1131c53aa2 upstream. The error log is supposed to be gaurded under if failure condition. Fixes: faab5ea08367 ("drm/amdgpu: Check vcn sram load return value") Signed-off-by: Sathishkumar S <[email protected]> Reviewed-by: Leo Liu <[email protected]> Signed-off-by: Alex Deucher <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
1 parent 039018b commit 1b60457

1 file changed

Lines changed: 3 additions & 2 deletions

File tree

drivers/gpu/drm/amd/amdgpu/vcn_v5_0_0.c

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -769,9 +769,10 @@ static int vcn_v5_0_0_start_dpg_mode(struct amdgpu_vcn_inst *vinst,
769769

770770
if (indirect) {
771771
ret = amdgpu_vcn_psp_update_sram(adev, inst_idx, 0);
772-
dev_err(adev->dev, "%s: vcn sram load failed %d\n", __func__, ret);
773-
if (ret)
772+
if (ret) {
773+
dev_err(adev->dev, "%s: vcn sram load failed %d\n", __func__, ret);
774774
return ret;
775+
}
775776
}
776777

777778
ring = &adev->vcn.inst[inst_idx].ring_enc[0];

0 commit comments

Comments
 (0)