Skip to content

Commit 2d9082a

Browse files
committed
Correct PMD / Suppress
1 parent 35f0ce8 commit 2d9082a

4 files changed

Lines changed: 4 additions & 5 deletions

File tree

vaadin-simple-grid-filter/src/main/java/software/xdev/vaadin/FilterComponent.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -874,7 +874,8 @@ private void setEnumSelectValues(final FilterField<T, ?> filterField)
874874
.toList());
875875
}
876876

877-
@SuppressWarnings({"PMD.CognitiveComplexity", "PMD.CollapsibleIfStatements"}) // Fixed in v2
877+
@SuppressWarnings({"PMD.CognitiveComplexity", "PMD.CollapsibleIfStatements", "PMD.AvoidDeeplyNestedIfStmts"})
878+
// Fixed in v2
878879
private void createConditionsFromQueryParameters()
879880
{
880881
for(int i = 0; i < this.queryFields.size(); i++)

vaadin-simple-grid-filter/src/main/java/software/xdev/vaadin/comparators/EqualComparator.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ public boolean isApplicable(final Class<?> clazz)
6262
|| Boolean.class.isAssignableFrom(clazz);
6363
}
6464

65-
@SuppressWarnings({"PMD.CognitiveComplexity", "PMD.NPathComplexity"}) // Fixed in v2
65+
@SuppressWarnings("PMD.CognitiveComplexity") // Fixed in v2
6666
@Override
6767
public <B, T> Predicate<B> compare(final ValueProvider<B, T> provider, final String searchQuery)
6868
{

vaadin-simple-grid-filter/src/main/java/software/xdev/vaadin/comparators/NotEqualComparator.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ public boolean isApplicable(final Class<?> clazz)
6262
|| Boolean.class.isAssignableFrom(clazz);
6363
}
6464

65-
@SuppressWarnings({"PMD.CognitiveComplexity", "PMD.NPathComplexity"}) // Fixed in v2
65+
@SuppressWarnings("PMD.CognitiveComplexity") // Fixed in v2
6666
@Override
6767
public <B, T> Predicate<B> compare(final ValueProvider<B, T> provider, final String searchQuery)
6868
{

vaadin-simple-grid-filter/src/main/java/software/xdev/vaadin/comparators/utl/TypeHelper.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,6 @@ public static boolean isDouble(final String str)
4747
}
4848
}
4949

50-
@SuppressWarnings("PMD.UselessOperationOnImmutable")
5150
public static boolean isLocalDate(final String str)
5251
{
5352
Objects.requireNonNull(str);
@@ -63,7 +62,6 @@ public static boolean isLocalDate(final String str)
6362
}
6463
}
6564

66-
@SuppressWarnings("PMD.UselessOperationOnImmutable")
6765
public static boolean isLocalDateTime(final String str)
6866
{
6967
Objects.requireNonNull(str);

0 commit comments

Comments
 (0)