chores: enforce eslint rule to avoid unused variables (jhipster#327)

Author: clementdessoude

.eslintignore

@@ -1,4 +1,4 @@
-/packages/java-parser/samples
-/packages/prettier-plugin-java/samples
-/packages/prettier-plugin-java/test-samples
-node_modules
+packages/java-parser/samples
+packages/prettier-plugin-java/samples
+packages/prettier-plugin-java/test-samples
+node_modules

.eslintrc.yml

@@ -1,6 +1,6 @@
 ---
 extends:
-- eslint:recommended
+  - eslint:recommended
 root: true
 env:
   es6: true
@@ -14,27 +14,27 @@ rules:
   no-inner-declarations: error
   no-unneeded-ternary: error
   no-useless-return: error
+  no-console: error
   no-var: error
   one-var:
-  - error
-  - never
+    - error
+    - never
   prefer-arrow-callback: error
   prefer-const: error
   react/no-deprecated: off
   strict: error
   symbol-description: error
   yoda:
-  - error
-  - never
-  - exceptRange: true
+    - error
+    - never
+    - exceptRange: true
 overrides:
-- files: "packages/*/test/**/*.js"
-  rules:
-    strict: off
-  globals:
-    context: true
-    describe: true
-    it: true
-    before: true
-    after: true
-
+  - files: "packages/*/test/**/*.js"
+    rules:
+      strict: off
+    globals:
+      context: true
+      describe: true
+      it: true
+      before: true
+      after: true

packages/java-parser/scripts/clone-samples.js

@@ -1,4 +1,4 @@
-/* eslint no-console: 0 */
+/* eslint-disable no-console */
 "use strict";
 const cp = require("child_process");
 const path = require("path");

packages/java-parser/src/tokens.js

@@ -1,4 +1,3 @@
-/* eslint-disable no-unused-vars */
 "use strict";
 const { createToken: createTokenOrg, Lexer } = require("chevrotain");
 let chars;

packages/prettier-plugin-java/scripts/clone-samples.js

@@ -1,4 +1,4 @@
-/* eslint no-console: 0 */
+/* eslint-disable no-console */
 "use strict";
 const cp = require("child_process");
 const path = require("path");

packages/prettier-plugin-java/src/printers/arrays.js

@@ -1,7 +1,5 @@
 "use strict";
-/* eslint-disable no-unused-vars */
-
-const { line, softline } = require("prettier").doc.builders;
+const { line } = require("prettier").doc.builders;
 const {
   rejectAndConcat,
   rejectAndJoinSeps,

packages/prettier-plugin-java/src/printers/blocks-and-statements.js

@@ -1,5 +1,4 @@
 "use strict";
-/* eslint-disable no-unused-vars */
 
 const { line, softline, hardline } = require("prettier").doc.builders;
 const { group, indent, concat, join } = require("./prettier-builder");
@@ -523,11 +522,11 @@ class BlocksAndStatementPrettierVisitor {
     return this.visitSingle(ctx);
   }
 
-  isBasicForStatement(ctx) {
+  isBasicForStatement() {
     return "isBasicForStatement";
   }
 
-  isLocalVariableDeclaration(ctx) {
+  isLocalVariableDeclaration() {
     return "isLocalVariableDeclaration";
   }
 }

packages/prettier-plugin-java/src/printers/classes.js

@@ -1,5 +1,4 @@
 "use strict";
-/* eslint-disable no-unused-vars */
 const _ = require("lodash");
 const { line, softline, hardline } = require("prettier").doc.builders;
 const {
@@ -716,15 +715,15 @@ class ClassesPrettierVisitor {
     return { ...ctx.Semicolon[0], image: "" };
   }
 
-  isClassDeclaration(ctx) {
+  isClassDeclaration() {
     return "isClassDeclaration";
   }
 
-  identifyClassBodyDeclarationType(ctx) {
+  identifyClassBodyDeclarationType() {
     return "identifyClassBodyDeclarationType";
   }
 
-  isDims(ctx) {
+  isDims() {
     return "isDims";
   }
 }

packages/prettier-plugin-java/src/printers/expressions.js

@@ -1,8 +1,7 @@
 "use strict";
-/* eslint-disable no-unused-vars */
 
 const _ = require("lodash");
-const { ifBreak, line, softline, hardline } = require("prettier").doc.builders;
+const { ifBreak, line, softline } = require("prettier").doc.builders;
 const { concat, group, indent } = require("./prettier-builder");
 const { printTokenWithComments } = require("./comments");
 const {
@@ -583,27 +582,27 @@ class ExpressionsPrettierVisitor {
     return rejectAndConcat([ctx.ColonColon[0], typeArguments, identifierOrNew]);
   }
 
-  identifyNewExpressionType(ctx) {
+  identifyNewExpressionType() {
     return "identifyNewExpressionType";
   }
 
-  isLambdaExpression(ctx) {
+  isLambdaExpression() {
     return "isLambdaExpression";
   }
 
-  isCastExpression(ctx) {
+  isCastExpression() {
     return "isCastExpression";
   }
 
-  isPrimitiveCastExpression(ctx) {
+  isPrimitiveCastExpression() {
     return "isPrimitiveCastExpression";
   }
 
-  isReferenceTypeCastExpression(ctx) {
+  isReferenceTypeCastExpression() {
     return "isReferenceTypeCastExpression";
   }
 
-  isRefTypeInMethodRef(ctx) {
+  isRefTypeInMethodRef() {
     return "isRefTypeInMethodRef";
   }
 }

packages/prettier-plugin-java/src/printers/interfaces.js

@@ -1,5 +1,4 @@
 "use strict";
-/* eslint-disable no-unused-vars */
 
 const { line, softline, hardline } = require("prettier").doc.builders;
 const { concat, group, indent } = require("./prettier-builder");
@@ -296,15 +295,15 @@ class InterfacesPrettierVisitor {
     return group(rejectAndConcat([rejectAndJoinSeps(commas, elementValues)]));
   }
 
-  identifyInterfaceBodyDeclarationType(ctx) {
+  identifyInterfaceBodyDeclarationType() {
     return "identifyInterfaceBodyDeclarationType";
   }
 
-  identifyAnnotationBodyDeclarationType(ctx) {
+  identifyAnnotationBodyDeclarationType() {
     return "identifyAnnotationBodyDeclarationType";
   }
 
-  isSimpleElementValueAnnotation(ctx) {
+  isSimpleElementValueAnnotation() {
     return "isSimpleElementValueAnnotation";
   }
 }