Skip to content

Commit 6a6a781

Browse files
committed
ci: update env name
1 parent 903a16a commit 6a6a781

5 files changed

Lines changed: 19 additions & 18 deletions

File tree

.github/workflows/ci-lint.yml

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -11,12 +11,7 @@ env:
1111
jobs:
1212
lint:
1313
name: Lint
14-
strategy:
15-
fail-fast: false
16-
matrix:
17-
node-version: ['20']
18-
os: ['ubuntu-latest']
19-
runs-on: ${{ matrix.os }}
14+
runs-on: 'ubuntu-latest'
2015
steps:
2116
- name: 👷 Checkout
2217
uses: actions/[email protected]
@@ -26,7 +21,7 @@ jobs:
2621
- name: 🛠️ Setup workspace
2722
uses: ./.github/workflows/actions/setup-workspace
2823
with:
29-
node-version: ${{ matrix.node-version }}
24+
node-version: '20'
3025

3126
- name: 📃 Run the lint
3227
run: pnpm run style:fix

e2e/package.json

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,10 +12,10 @@
1212
"scripts": {
1313
"test:e2e": "run-s test:e2e:basic test:e2e:workspace",
1414
"test:e2e:basic": "run-s test:e2e:basic:*",
15-
"test:e2e:basic:mocha": "cross-env VSCODE_WDIO_E2E_FRAMEWORK=mocha xvfb-maybe pnpm run wdio",
16-
"test:e2e:basic:jasmine": "cross-env VSCODE_WDIO_E2E_FRAMEWORK=jasmine xvfb-maybe pnpm run wdio",
17-
"test:e2e:basic:cucumber": "cross-env VSCODE_WDIO_E2E_FRAMEWORK=cucumber xvfb-maybe pnpm run wdio",
18-
"test:e2e:workspace": "cross-env VSCODE_WDIO_E2E_FRAMEWORK=workspace xvfb-maybe pnpm run wdio",
15+
"test:e2e:basic:mocha": "cross-env VSCODE_WDIO_E2E_SCENARIO=mocha xvfb-maybe pnpm run wdio",
16+
"test:e2e:basic:jasmine": "cross-env VSCODE_WDIO_E2E_SCENARIO=jasmine xvfb-maybe pnpm run wdio",
17+
"test:e2e:basic:cucumber": "cross-env VSCODE_WDIO_E2E_SCENARIO=cucumber xvfb-maybe pnpm run wdio",
18+
"test:e2e:workspace": "cross-env VSCODE_WDIO_E2E_SCENARIO=workspace xvfb-maybe pnpm run wdio",
1919
"test:smoke": "run-s test:smoke:*",
2020
"test:smoke:update-config": "xvfb-maybe wdio run ./wdioSmoke.conf.ts",
2121
"wdio": "wdio run ./wdio.conf.ts"

e2e/tests/basic.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ import {
1515

1616
import type { SideBarView, ViewControl, Workbench } from 'wdio-vscode-service'
1717

18-
const targetFramework = (process.env.VSCODE_WDIO_E2E_FRAMEWORK || 'mocha') as 'mocha' | 'jasmine'
18+
const targetFramework = (process.env.VSCODE_WDIO_E2E_SCENARIO || 'mocha') as 'mocha' | 'jasmine'
1919

2020
const expected = createExpected(targetFramework)
2121

e2e/tests/basicCucumber.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ import {
1515

1616
import type { SideBarView, ViewControl, Workbench } from 'wdio-vscode-service'
1717

18-
const targetFramework = process.env.VSCODE_WDIO_E2E_FRAMEWORK || 'mocha'
18+
const targetFramework = process.env.VSCODE_WDIO_E2E_SCENARIO || 'mocha'
1919

2020
const expected = createCucumberExpected()
2121

e2e/wdio.conf.ts

Lines changed: 11 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ import type { Frameworks } from '@wdio/types'
99
type TestTargets = 'workspace' | 'mocha' | 'jasmine' | 'cucumber'
1010

1111
const __dirname = path.dirname(url.fileURLToPath(import.meta.url))
12-
const target = (process.env.VSCODE_WDIO_E2E_FRAMEWORK || 'mocha') as TestTargets
12+
const target = (process.env.VSCODE_WDIO_E2E_SCENARIO || 'mocha') as TestTargets
1313

1414
const minimumVersion = minVersion(pkg.engines.vscode)?.version || 'stable'
1515

@@ -33,7 +33,15 @@ function defineSpecs(target: TestTargets) {
3333
const specs = defineSpecs(target)
3434
let screenshotCount = 0
3535

36-
export function createBaseConfig(workspacePath: string): WebdriverIO.Config {
36+
export function createBaseConfig(workspacePath: string, userSettings = {}): WebdriverIO.Config {
37+
const resolvedUserSettings = Object.assign(
38+
{},
39+
{
40+
'webdriverio.logLevel': 'trace',
41+
},
42+
userSettings
43+
)
44+
3745
return {
3846
runner: 'local',
3947
tsConfigPath: './tsconfig.json',
@@ -47,9 +55,7 @@ export function createBaseConfig(workspacePath: string): WebdriverIO.Config {
4755
// points to directory where extension package.json is located
4856
extensionPath: path.resolve('../packages/vscode-webdriverio'),
4957
// optional VS Code settings
50-
userSettings: {
51-
'webdriverio.logLevel': 'trace',
52-
},
58+
userSettings: resolvedUserSettings,
5359
workspacePath: path.resolve(workspacePath),
5460
},
5561
'wdio:enforceWebDriverClassic': true,

0 commit comments

Comments
 (0)